Clean-up some logic with invoice report fields #46858

hungvu193 · 2024-08-06T07:24:19Z

Details

Currently, we're showing all the report fields (except the title field) inside a money report view, we should return the proper field for each report.

Fixed Issues

$ #46303
PROPOSAL: N/A

Tests

We can add Onyx data manually incase your QuickBookOnline doesn't sync custom field:

Onyx.merge('report_507598410605384', {
    fieldList: {
        expensify_field_id_INVOICEEXPENSE: {
            name: 'InvoiceExpense',
            type: 'date',
            values: [],
            disabledOptions: [],
            fieldID: 'field_id_INVOICEEXPENSE',
            orderWeight: 2,
            deletable: false,
            keys: [],
            externalIDs: [],
            isTax: false,
            defaultValue: '2024-08-09',
            target: 'invoice',
            value: '2024-08-09',
        },
        expensify_field_id_DATEFIELDEXPENSE: {
            name: 'DateFieldExpense',
            type: 'date',
            values: [],
            disabledOptions: [],
            fieldID: 'field_id_DATEFIELDEXPENSE',
            orderWeight: 2,
            deletable: false,
            keys: [],
            externalIDs: [],
            isTax: false,
            defaultValue: '2024-08-09',
            target: 'expense',
            value: '2024-08-09',
        },
        expensify_field_id_PAYCHECK: {
            name: 'PayCheck',
            type: 'date',
            values: [],
            disabledOptions: [],
            fieldID: 'field_id_PAYCHECK',
            orderWeight: 2,
            deletable: false,
            keys: [],
            externalIDs: [],
            isTax: false,
            defaultValue: '2024-08-09',
            target: 'paycheck',
            value: '2024-08-09',
        },
    },
});

Login with any account.
Create a new workspace.
Enable Accounting feature from More Feature page.
Go to Accounting, connect with QBO.
Create an expense report in that workspace.
Verify that only expense report fields appear.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-09.at.15.52.49.mov

Android: mWeb Chrome

// connect issue

iOS: Native

Screen.Recording.2024-08-09.at.15.49.14.mov

iOS: mWeb Safari

Safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-09.at.15.41.11.mov

MacOS: Desktop

Screen.Recording.2024-08-09.at.15.44.07.mov

melvin-bot · 2024-08-08T04:30:37Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-08-08T04:38:59Z

This PR is basically ready for review. I'll provide details test steps shortly

mountiny · 2024-08-08T22:52:34Z

@jayeshmangwani can you please test? thanks

hungvu193 · 2024-08-09T08:43:33Z

@jayeshmangwani Added test Onyx data in the Tests steps, let me know if you have any question 😄

jayeshmangwani · 2024-08-09T08:50:20Z

@hungvu193 thanks for the detailed Onyx Data

jayeshmangwani · 2024-08-09T08:52:11Z

@hungvu193 I successfully connected to QBO, but I'm currently unable to reproduce the initial bug(bug 1) on main. The invoice report fields aren't appearing. I've attached a screenshot below.

hungvu193 · 2024-08-09T08:55:31Z

@hungvu193 I successfully connected to QBO, but I'm currently unable to reproduce the initial bug(bug 1) on main. The invoice report fields aren't appearing. I've attached a screenshot below.

it only appears if your QBO has that custom field, I recommended you to use my Onyx data to test instead.

jayeshmangwani · 2024-08-09T08:56:32Z

I recommended you to use my Onyx data to test instead.

ohh, okay okay

hungvu193 · 2024-08-09T08:56:57Z

@trjExpensify Can you trigger the build here so you can test in the meantime?

jayeshmangwani · 2024-08-09T10:01:19Z

@hungvu193 Bug 1 seems to be fixed.

Are we planning to address Bug 2, where the report fields in 'More features' are auto-enabled?

hungvu193 · 2024-08-09T10:16:28Z

@hungvu193 Bug 1 seems to be fixed.

Are we planning to address Bug 2, where the report fields in 'More features' are auto-enabled?

I think it should be fixed from our BE. After connecting to QBO, our BE sent Pusher event to enable Report Fields feature:

jayeshmangwani · 2024-08-09T11:06:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

Changes works well 🚀

jayeshmangwani · 2024-08-09T11:07:51Z

@mountiny All yours 🚀

src/types/onyx/Policy.ts

mountiny

Perfect thanks!

OSBotify · 2024-08-12T14:57:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-12T16:57:15Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.19-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2024-08-12T20:37:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.19-4 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

OSBotify · 2024-08-12T22:09:12Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.19-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-08-13T20:39:19Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.20-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Beamanator · 2024-08-16T19:51:58Z

FYI I believe this was deployed to prod yesterday, from this checklist - #47356

hungvu193 added 2 commits August 6, 2024 14:22

Clean-up some logic with invoice report fields

acbbfe1

fix linting

109aa50

hungvu193 mentioned this pull request Aug 6, 2024

[HOLD for payment 2024-08-27] [$250] [Report fields] Clean-up some logic with invoice report fields #46303

Closed

mountiny self-requested a review August 8, 2024 00:53

hungvu193 marked this pull request as ready for review August 8, 2024 04:30

hungvu193 requested a review from a team as a code owner August 8, 2024 04:30

melvin-bot bot requested review from jayeshmangwani and removed request for a team August 8, 2024 04:30

mountiny assigned hungvu193 Aug 8, 2024

Merge remote-tracking branch 'origin/main' into chore-46303

f01d5cb

jayeshmangwani approved these changes Aug 9, 2024

View reviewed changes

mountiny requested changes Aug 11, 2024

View reviewed changes

src/types/onyx/Policy.ts Outdated Show resolved Hide resolved

hungvu193 added 3 commits August 12, 2024 10:28

Merge remote-tracking branch 'origin/main' into chore-46303

7c3b10d

update target type

1af9614

make target optional

35cc8f4

mountiny approved these changes Aug 12, 2024

View reviewed changes

mountiny merged commit 00057ea into Expensify:main Aug 12, 2024
15 checks passed

github-actions bot mentioned this pull request Aug 12, 2024

Deploy Checklist: New Expensify 2024-08-12 #47219

Closed

90 tasks

github-actions bot mentioned this pull request Aug 13, 2024

Deploy Checklist: New Expensify 2024-08-13 #47356

Closed

72 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean-up some logic with invoice report fields #46858

Clean-up some logic with invoice report fields #46858

hungvu193 commented Aug 6, 2024 •

edited

Loading

melvin-bot bot commented Aug 8, 2024

hungvu193 commented Aug 8, 2024 •

edited

Loading

mountiny commented Aug 8, 2024

hungvu193 commented Aug 9, 2024

jayeshmangwani commented Aug 9, 2024

jayeshmangwani commented Aug 9, 2024

hungvu193 commented Aug 9, 2024 •

edited

Loading

jayeshmangwani commented Aug 9, 2024

hungvu193 commented Aug 9, 2024

jayeshmangwani commented Aug 9, 2024

hungvu193 commented Aug 9, 2024

jayeshmangwani commented Aug 9, 2024

jayeshmangwani left a comment

jayeshmangwani commented Aug 9, 2024

mountiny left a comment

OSBotify commented Aug 12, 2024

OSBotify commented Aug 12, 2024

OSBotify commented Aug 12, 2024

OSBotify commented Aug 12, 2024

OSBotify commented Aug 13, 2024

Beamanator commented Aug 16, 2024

Clean-up some logic with invoice report fields #46858

Clean-up some logic with invoice report fields #46858

Conversation

hungvu193 commented Aug 6, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 8, 2024

hungvu193 commented Aug 8, 2024 • edited Loading

mountiny commented Aug 8, 2024

hungvu193 commented Aug 9, 2024

jayeshmangwani commented Aug 9, 2024

jayeshmangwani commented Aug 9, 2024

hungvu193 commented Aug 9, 2024 • edited Loading

jayeshmangwani commented Aug 9, 2024

hungvu193 commented Aug 9, 2024

jayeshmangwani commented Aug 9, 2024

hungvu193 commented Aug 9, 2024

jayeshmangwani commented Aug 9, 2024

Reviewer Checklist

Screenshots/Videos

jayeshmangwani left a comment

Choose a reason for hiding this comment

jayeshmangwani commented Aug 9, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 12, 2024

OSBotify commented Aug 12, 2024

OSBotify commented Aug 12, 2024

OSBotify commented Aug 12, 2024

OSBotify commented Aug 13, 2024

Beamanator commented Aug 16, 2024

hungvu193 commented Aug 6, 2024 •

edited

Loading

hungvu193 commented Aug 8, 2024 •

edited

Loading

hungvu193 commented Aug 9, 2024 •

edited

Loading