-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Add Xero New Dot Images to the Image repo #47118
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://245c380b.helpdot.pages.dev ⚡️ |
Most of the checklist is not really applicable to this update as there is no bug or fix as such, we are just adding some new images to the image repo. |
recheck |
I have read the CLA Document and I hereby sign the CLA |
recheck |
1 similar comment
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
FYI I believe this was deployed to prod yesterday, from this checklist - #47219 |
Details
This change adds images that have that were created by our design team to our New Expensify Images Repo so that they can be used in our help articles -
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/413228`
$ https://github.com/Expensify/Expensify/issues/416529#issuecomment-2264144982
--->
$
PROPOSAL:
Add Xero images to our New Expensify Image repo so that they can be used in our help articles
Tests
Open the image files to ensure they are clear
N/A
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop