-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#46949: Fix Results, Loading and Empty state Search pages #47164
#46949: Fix Results, Loading and Empty state Search pages #47164
Conversation
@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-12.at.12.46.00.PM.movAndroid: mWeb ChromeScreen.Recording.2024-08-12.at.12.43.12.PM.moviOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-12.at.12.38.37.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-12.at.12.29.10.mp4MacOS: Chrome / SafariScreen.Recording.2024-08-12.at.12.27.16.PM.movMacOS: DesktopScreen.Recording.2024-08-12.at.12.35.50.PM.mov |
Hi @shawnborton, please take a look at this one :) |
@Guccio163 - Please link #46949 in the fixed issues section of the author checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Much better! |
Also, before we merge this one: After consulting with @Kicu, we noticed, that we can solve even bigger problem; The horizontal padding that wasn't added here is afaik added separately every time in |
That sounds lovely. |
@Guccio163 - I suggest these QA steps to include in the author checklist:
|
Sounds really good; I'll add it right now, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well. @Guccio163 will you address this suggestion here before we merge?
Yes, I'm working over it right now and will ask for a second review after the change; From what I see it will be purely restructuring and will not affect any other view's UI, but to be sure I will capture it on video too |
Okay, I shifted the place of adding padding/margin; It should all be all right: inside ![]() ![]() |
…-fork into Guccio163/emptySearchBug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.19-4 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.19-5 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.20-0 🚀
|
FYI I believe this was deployed to prod yesterday, from this checklist - #47356 |
Details
This PR aims to align all 3 possible pages for Search list state: Results, Loading and Empty. Necessary improvements:
<SearchRowSkeleton/>
inSearch/index.tsx
withView
aligning it horizontally, alignment of<EmptySearchView/>
is handled within itself.Possible alternate solution (doesn't require wrapping):
<SearchRowSkeleton/>
to match Results page's20px
(previously12px
)8px
padding from<EmptyStateComponent/>
wrapper (cause of misalignment between Loading and Empty views) with optional style prop.Fixed Issues
$ #46949
PROPOSAL:
Tests
Enable Advanced Approval Workflows in
Permissions
, then go through Search section of various workspaces to observe how Loading state changes into Results or Empty pages (imho the best is to clear Onyx beforehand ;)), they should be horizontally aligned like here:Screen.Recording.2024-08-09.at.15.57.33.mov
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
mWeb_android.mov
iOS: Native
ios.mov
iOS: mWeb Safari
mWeb_ios.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-09.at.15.57.33.mov
Screen.Recording.2024-08-09.at.15.58.59.mov
MacOS: Desktop
desktop.mov