Feat/44315 toggle card continuous reconciliation be integration #47406

koko57 · 2024-08-14T11:59:36Z

Details

Fixed Issues

$ #44315
PROPOSAL:

Tests

PREREQUISITES: workspaceFeed beta and Expensify Card enabled

Go to Workspaces -> select a workspace
Enable Accounting if not enabled
Connect with an accounting system if not connected
Select Card Reconciliation
If you don't have auto-sync enabled you will see a message with a link and the toggle will be disabled.
[Skip steps 6-7 if auto-sync enabled]
Click the link, verify that you will be redirected to accounting advanced settings
Enable auto-sync, go back
Toggle the Continuous Reconciliation toggle, check the Network tab - verify that the request is sent, you get the proper response and you're redirected to the card-reconciliation/account page

Verify that no errors appear in the JS console

Offline tests

QA Steps

PREREQUISITES: workspaceFeed beta and Expensify Card enabled

Go to Workspaces -> select a workspace
Enable Accounting if not enabled
Connect with an accounting system if not connected
Select Card Reconciliation
If you don't have auto-sync enabled you will see a message with a link and the toggle will be disabled.
[Skip steps 6-7 if auto-sync enabled]
Click the link, verify that you will be redirected to accounting advanced settings
Enable auto-sync, go back
Toggle the Continuous Reconciliation toggle, check the Network tab - verify that the request is sent, you get the proper response and you're redirected to the card-reconciliation/account page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-08-14T12:00:06Z

@bondydaa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

koko57 · 2024-08-14T12:03:31Z

@mountiny I couldn't test it properly - I don't know how to connect with accounting. Is it possible to connect somehow just for testing purposes? But the request is sent, I got an empty array as onyxData response (but maybe bc I'm not connected correctly).

mountiny · 2024-08-14T12:21:15Z

@bondydaa Sorry for the ping, handling this with Maria as part of the workspace feeds project

src/CONST.ts

mountiny · 2024-08-14T14:34:16Z

@koko57

Is it possible to connect somehow just for testing purposes?

I think you need to create a real free trial account for the QBO to connect

And the empty response is expected if you do not have the connection

allgandalf · 2024-08-16T05:18:20Z

~~Taking this over from @DylanDylann , @mountiny can you assign me here, thanks~~

Sorry, we had a misunderstanding @DylanDylann is still going to review this

DylanDylann · 2024-08-16T08:01:55Z

src/pages/workspace/accounting/reconciliation/CardReconciliationPage.tsx

    const [bankAccountList] = useOnyx(ONYXKEYS.BANK_ACCOUNT_LIST);

    const paymentBankAccountID = cardSettings?.paymentBankAccountID ?? 0;
    const bankAccountTitle = bankAccountList?.[paymentBankAccountID]?.title ?? '';

    const policyID = policy?.id ?? '-1';
    const {connection} = route.params;
-    const autoSync = !!policy?.connections?.[connection]?.config?.autoSync?.enabled;
+    const connectionName = AccountingUtils.getConnectionNameFromRouteParam(connection) as ConnectionName;
+    const autoSync = !!policy?.connections?.[connectionName]?.config?.autoSync?.enabled;

    // eslint-disable-next-line rulesdir/prefer-early-return


Let's fix this eslint

DylanDylann · 2024-08-16T08:44:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2024-08-16.at.15.54.44.mov

…conciliation-be-integration # Conflicts: # src/libs/API/parameters/index.ts # src/libs/actions/Card.ts

mountiny

I believe there is a small mistake in the failureData

mountiny · 2024-08-19T10:56:03Z

src/libs/actions/Card.ts

+        {
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: `${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_CONTINUOUS_RECONCILIATION_CONNECTION}${workspaceAccountID}`,
+            value: null,


This should be null OR the previous value if the shouldUseReconciliation was true, right?

@mountiny I've updated the failure data, let me know what do you think

mountiny

Thanks, Maria already approved so going to merge this now

OSBotify · 2024-08-19T14:00:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-19T16:15:05Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.22-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-19T17:11:46Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.22-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-20T22:44:50Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.22-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

koko57 added 4 commits August 12, 2024 20:56

feat: add ToggleCardContinuousReconciliation command

35bb4e3

minor fixes

a152ce8

fix: resolve conflicts

69b3d6d

fix: last improvements

7f28038

koko57 requested a review from a team as a code owner August 14, 2024 11:59

melvin-bot bot requested review from bondydaa and removed request for a team August 14, 2024 12:00

fix: resolve conflicts

d44a90d

mountiny requested review from mountiny and removed request for bondydaa August 14, 2024 12:20

mountiny assigned koko57 and MariaHCD Aug 14, 2024

fix: typecheck

6196c61

DylanDylann reviewed Aug 14, 2024

View reviewed changes

src/CONST.ts Show resolved Hide resolved

mountiny unassigned MariaHCD Aug 15, 2024

This comment was marked as outdated.

Sign in to view

DylanDylann reviewed Aug 16, 2024

View reviewed changes

VickyStash added 2 commits August 16, 2024 10:49

Merge branch 'refs/heads/main' into feat/44315-ToggleCardContinuousRe…

cff4a2a

…conciliation-be-integration # Conflicts: # src/libs/API/parameters/index.ts # src/libs/actions/Card.ts

Remove extra eslint disable

8ae3f7f

DylanDylann approved these changes Aug 16, 2024

View reviewed changes

MariaHCD self-requested a review August 16, 2024 12:54

MariaHCD previously approved these changes Aug 16, 2024

View reviewed changes

mountiny requested changes Aug 19, 2024

View reviewed changes

Update failureData

007b76e

VickyStash dismissed MariaHCD’s stale review via 007b76e August 19, 2024 12:01

mountiny approved these changes Aug 19, 2024

View reviewed changes

mountiny merged commit 273273a into Expensify:main Aug 19, 2024
17 checks passed

github-actions bot mentioned this pull request Aug 19, 2024

Deploy Checklist: New Expensify 2024-08-19 #47639

Closed

77 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/44315 toggle card continuous reconciliation be integration #47406

Feat/44315 toggle card continuous reconciliation be integration #47406

koko57 commented Aug 14, 2024 •

edited by github-actions bot

Loading

melvin-bot bot commented Aug 14, 2024

koko57 commented Aug 14, 2024

mountiny commented Aug 14, 2024

mountiny commented Aug 14, 2024

allgandalf commented Aug 16, 2024 •

edited

Loading

This comment was marked as outdated.

DylanDylann Aug 16, 2024

DylanDylann commented Aug 16, 2024 •

edited

Loading

mountiny left a comment

mountiny Aug 19, 2024

VickyStash Aug 19, 2024

mountiny left a comment

OSBotify commented Aug 19, 2024

OSBotify commented Aug 19, 2024

OSBotify commented Aug 19, 2024

OSBotify commented Aug 20, 2024

Feat/44315 toggle card continuous reconciliation be integration #47406

Feat/44315 toggle card continuous reconciliation be integration #47406

Conversation

koko57 commented Aug 14, 2024 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 14, 2024

koko57 commented Aug 14, 2024

mountiny commented Aug 14, 2024

mountiny commented Aug 14, 2024

allgandalf commented Aug 16, 2024 • edited Loading

This comment was marked as outdated.

DylanDylann Aug 16, 2024

Choose a reason for hiding this comment

DylanDylann commented Aug 16, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

mountiny Aug 19, 2024

Choose a reason for hiding this comment

VickyStash Aug 19, 2024

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 19, 2024

OSBotify commented Aug 19, 2024

OSBotify commented Aug 19, 2024

OSBotify commented Aug 20, 2024

koko57 commented Aug 14, 2024 •

edited by github-actions bot

Loading

allgandalf commented Aug 16, 2024 •

edited

Loading

DylanDylann commented Aug 16, 2024 •

edited

Loading