-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cannot read property routes of undefined #47689
Conversation
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@hurali97 Can you please add test steps for the same? |
@mananjadhav As I couldn't reproduce this issue, so unfortunately there are no steps that I can add. We fix this issue by isolating the underlying function and testing it against some values, which can break this function, as explained in the proposal here |
Got it. I'll then set |
@mananjadhav Oh. Since this is Metro connectivity issue, I will say this is irrelative of this PR because if you look at the changes they don't tweak anything in the tooling. However, this issue could happen out of the blue, can you try the following and see if it helps?
I built this branch today and it was all fine for me. Apart from this if you still can't run this PR locally, can we trigger the builds for android and test there? |
Yeah it was an issue with my emulator. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-root-state.movAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
I tested by putting |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #46118 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@mananjadhav can you update your reviewer comment, appears you're missing some checkmarks https://github.com/Expensify/App/actions/runs/10556135051/job/29262313283?pr=47689
Ohh I had a previous incomplete checklist. Deleted that comment. Can you rerun now? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.25-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.25-0 🚀
|
Details
We use optional chaining to access the optional object.
Fixed Issues
$ #46118
PROPOSAL: #46118 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-08-20.at.4.39.45.PM.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop