-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autolink isn't recognized when put before img markdown #47762
Fix autolink isn't recognized when put before img markdown #47762
Conversation
Additional video showing the alt is added to the img tag. web.alt.mp4 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-23.at.3.26.06.in.the.afternoon.movAndroid: mWeb ChromeScreen.Recording.2024-08-23.at.2.43.51.in.the.afternoon.moviOS: NativeScreen.Recording.2024-08-23.at.2.48.22.in.the.afternoon.moviOS: mWeb SafariScreen.Recording.2024-08-23.at.2.41.31.in.the.afternoon.movMacOS: Chrome / SafariScreen.Recording.2024-08-23.at.2.21.56.in.the.afternoon.movMacOS: DesktopScreen.Recording.2024-08-23.at.2.52.26.in.the.afternoon.mov |
@bernhardoj we have a conflict |
Fixed. |
@bernhardoj the alt is still without value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! NAB - although the image does successfully have the alt text now, we don't actually display that anywhere... We probably should at some point (e.g. hover with mouse like a lot of the web, or something else). But this works for now!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.25-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.25-0 🚀
|
Details
Autolink markdown isn't recognized when we put it before the img markdown. This PR fix it.
Fixed Issues
$ #46491
PROPOSAL: #46491 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4