Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Enable hot-reload for react-native-live-markdown #47794

Merged
merged 4 commits into from
Aug 23, 2024
Merged

[No QA] Enable hot-reload for react-native-live-markdown #47794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a8602c
Ignore docs/.bundle
roryabraham Aug 21, 2024
9305506
Add link dev dependency
roryabraham Aug 21, 2024
9783663
Merge branch 'main' into Rory-HotReloadRNLMD
roryabraham Aug 21, 2024
e05e845
Add react-native-live-markdown as a webpack managed path
roryabraham Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,6 @@ web-build/

# Storage location for downloaded app source maps (see scripts/symbolicate-profile.ts)
.sourcemaps/

# Jeykll
docs/.bundle
4 changes: 2 additions & 2 deletions config/webpack/webpack.dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ const getConfiguration = (environment: Environment): Promise<Configuration> =>
snapshot: {
// A list of paths webpack trusts would not be modified while webpack is running
managedPaths: [
// Onyx can be modified on the fly, changes to other node_modules would not be reflected live
/([\\/]node_modules[\\/](?!react-native-onyx))/,
// Onyx and react-native-live-markdown can be modified on the fly, changes to other node_modules would not be reflected live
/([\\/]node_modules[\\/](?!react-native-onyx|@expensify\/react-native-live-markdown))/,
],
},
});
Expand Down
13 changes: 13 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@
"jest-cli": "29.4.1",
"jest-environment-jsdom": "^29.4.1",
"jest-transformer-svg": "^2.0.1",
"link": "^2.1.1",
"memfs": "^4.6.0",
"onchange": "^7.1.0",
"openai": "^4.47.2",
Expand Down
4,513 changes: 4,513 additions & 0 deletions patches/link+2.1.1.patch
View file
Open in desktop

Large diffs are not rendered by default.

Loading