-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSV import flow to Categories page #47827
Merged
mountiny
merged 44 commits into
Expensify:main
from
software-mansion-labs:filip-solecki/import-categories-csv
Sep 3, 2024
Merged
Changes from 15 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
e407d21
Add CSV import flow to Categories page
filip-solecki e8a6e49
Fix filePicker for native apps
filip-solecki e68b88c
Add acceptable types to fix mWeb file selecting
filip-solecki 2773a18
Fix scrolling and import button position
filip-solecki d5714f7
Fix footer styles
filip-solecki da416c7
Fix duplicate column condition
filip-solecki 4da476d
CR fixes
filip-solecki 41d1906
Remove unnecessary succesData update
filip-solecki 0b50987
UI fixes
filip-solecki 4c7bc05
Add GL Code field for control policies
filip-solecki def44cd
Merge branch 'main' into filip-solecki/import-categories-csv
filip-solecki 6184709
Remove unnecessary categories update on failure
filip-solecki 9ae48f6
Rename Onyx update method
filip-solecki 861c7b6
Prepare translations for other imports
filip-solecki f69f393
Revert additional translations
filip-solecki f5904e2
Create utils file
filip-solecki 3d82cc4
rename hide modal function
filip-solecki d12397a
Make sure GL Code is a string
filip-solecki 2755ef9
Make GL Code optional
filip-solecki 88533d0
Apply approved translations
filip-solecki a1dcb10
Merge branch 'main' into filip-solecki/import-categories-csv
filip-solecki 8bfe96f
Fix package lock
filip-solecki 41a9430
Use large button for import
filip-solecki d2eb345
Add types comments for ImportSpreadsheetColumns file
filip-solecki 6a3971f
Add types comments to ImportSpreadsheet file
filip-solecki 0970694
Merge branch 'main' into filip-solecki/import-categories-csv
filip-solecki cd5d6c5
Remove scrollview margin
filip-solecki 3524d45
Remove footer margin
filip-solecki a157217
Remove button margin
filip-solecki b6e0090
Add margin from scrollbar to view
filip-solecki 09223e9
Merge main
filip-solecki 0f7b3f8
Merge branch 'main' into filip-solecki/import-categories-csv
filip-solecki 2d9c4e9
Add small button styling
filip-solecki ef6f76a
Use vendoring for xlsx library
filip-solecki a637a8a
Fix containsHeader logic and styling
filip-solecki 564b002
Merge branch 'main' into filip-solecki/import-categories-csv
filip-solecki 31a969b
Change errors logic and fix text ellipsis
filip-solecki 383fc30
Slice header if containsHeader is true
filip-solecki e734d9e
Fix validation
filip-solecki f88212c
Merge branch 'main' into filip-solecki/import-categories-csv
filip-solecki f595652
Clear containsHeader logic
filip-solecki 33dff0d
Remove brackets from Learn More Link
filip-solecki c68b384
Fix selected bg and add docs
filip-solecki 77bbb95
Update src/libs/importSpreadsheetUtils.ts
filip-solecki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was the idea in the doc to split into constants for each file, should we update to match that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the idea, but it is not needed IMO and in the function
findColumnName
we don't know it e.g. fieldGL Code
is fromcategories
ortags
, so what should be set there as an attribute? (there is no difference, because they are the same) Example below: