Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - Distance tab flickering to manual & back to distance every time when add destination #47885

Merged
merged 3 commits into from
Aug 29, 2024
Merged

IOU - Distance tab flickering to manual & back to distance every time when add destination #47885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34cf901
add tab-view patch to fix zero layout size flicker
cdOut Aug 22, 2024
9ddbfae
fix patch name
cdOut Aug 22, 2024
c90765d
Merge branch 'main' into @cdOut/tab-view-flicker
cdOut Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 patches/react-native-tab-view+3.5.2.patch → ...t-native-tab-view+3.5.2+001+initial.patch
View file
Open in desktop
File renamed without changes.
29 changes: 29 additions & 0 deletions patches/react-native-tab-view+3.5.2+002+fixZeroWidthHeightPositionFlicker.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
diff --git a/node_modules/react-native-tab-view/lib/module/TabView.js b/node_modules/react-native-tab-view/lib/module/TabView.js
index ba28170..4c607a2 100644
--- a/node_modules/react-native-tab-view/lib/module/TabView.js
+++ b/node_modules/react-native-tab-view/lib/module/TabView.js
@@ -40,6 +40,9 @@ export function TabView(_ref) {
height,
width
} = e.nativeEvent.layout;
+ if(!!width || !!height) {
+ return;
+ }
setLayout(prevLayout => {
if (prevLayout.width === width && prevLayout.height === height) {
return prevLayout;
diff --git a/node_modules/react-native-tab-view/src/TabView.tsx b/node_modules/react-native-tab-view/src/TabView.tsx
index bb1f531..d70f9ba 100644
--- a/node_modules/react-native-tab-view/src/TabView.tsx
+++ b/node_modules/react-native-tab-view/src/TabView.tsx
@@ -70,6 +70,10 @@ export function TabView<T extends Route>({
const handleLayout = (e: LayoutChangeEvent) => {
const { height, width } = e.nativeEvent.layout;

+ if(!!width || !!height) {
+ return;
+ }
+
setLayout((prevLayout) => {
if (prevLayout.width === width && prevLayout.height === height) {
return prevLayout;
Loading