You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opens up manual CP privileges to the @Expensify/mobile-deployers group
Restricts production deploy abilities to the @Expensify/mobile-deployers group
Allows @Expensify/mobile-deployers to run the platformDeploy.yml workflow. This means we can now retry failed deploy workflows. But be warned! With great power comes great responsibility. You must understand that if you push a tag or create a GH release, you will trigger a staging/production deploy.
This must be live-tested. Testing steps can happen out-of-order, but the complete list of things we need to verify is:
Merge a PR when the deploy checklist is unlocked. Verify that a staging deploy occurs as expected.
Have a mobile-deployer restart an active platformDeploy.yml workflow. Verify that it restarts and works as expected.
Have a non-mobile deployer restart a platformDeploy.yml workflow. Verify that it does not restart.
With the deploy checklist locked, merge a PR with the CP Staging label. It should be CP'd to staging.
Have a mobile-deployer (not a member of the deprecated expensify-cash-deployers team) attempt to manually trigger a CP. It should work as expected.
Have a non-mobile-deployer attempt to manually trigger a CP. It should not work.
Have a non-mobile deployer attempt to close out a StagingDeployCash where there are unchecked boxes in the description. It should not work.
Have a mobile-deployer attempt to close out a StagingDeployCash where there are unchecked boxes in the description. It should not work.
Have a non-mobile-deployer attempt to close out a StagingDeployCash with all the boxes checked and with the comment. It should not work.
Have a mobile-deployer attempt to close out a StagingDeployCash with all the boxes checked and with the comment. It should work and trigger the prod deploy.
Okay, there is more than one way this did not work. Isabella was just able to run a prod deploy w/o the comment, then the deploy checklist was reopened but no comment was left. This is basically a 🔥 now
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roryabraham
dismissed stale reviews from Julesssss and MonilBhavsar
via
comment, then the deploy checklist was reopened but no comment was left. This is basically a 🔥 now
Details
platformDeploy.ymlworkflow. This means we can now retry failed deploy workflows. But be warned! With great power comes great responsibility. You must understand that if you push a tag or create a GH release, you will trigger a staging/production deploy.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/171977
$ https://github.com/Expensify/Expensify/issues/173687
Tests
This must be live-tested. Testing steps can happen out-of-order, but the complete list of things we need to verify is:
platformDeploy.ymlworkflow. Verify that it restarts and works as expected.platformDeploy.ymlworkflow. Verify that it does not restart.CP Staginglabel. It should be CP'd to staging.StagingDeployCashwhere there are unchecked boxes in the description. It should not work.StagingDeployCashwhere there are unchecked boxes in the description. It should not work.StagingDeployCashwith all the boxes checked and with theStagingDeployCashwith all the boxes checked and with the