Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 47418 #47998

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Revert PR 47418 #47998

merged 1 commit into from
Aug 26, 2024

Conversation

cristipaval
Copy link
Contributor

Reverts #47418

Fixes
$ #47897

@cristipaval cristipaval self-assigned this Aug 26, 2024
@cristipaval cristipaval requested a review from a team as a code owner August 26, 2024 12:52
@melvin-bot melvin-bot bot requested review from tgolen and removed request for a team August 26, 2024 12:53
Copy link

melvin-bot bot commented Aug 26, 2024

@tgolen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@tgolen
Copy link
Contributor

tgolen commented Aug 26, 2024

This is a straight revert so tests and checklist is not necessary.

@tgolen tgolen merged commit f89cb0f into main Aug 26, 2024
14 of 17 checks passed
@tgolen tgolen deleted the cristi_revert-PR47418 branch August 26, 2024 15:04
Copy link

melvin-bot bot commented Aug 26, 2024

@tgolen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@tgolen
Copy link
Contributor

tgolen commented Aug 26, 2024

@cristipaval I assume you want to CP this?

@cristipaval
Copy link
Contributor Author

@cristipaval I assume you want to CP this?

yes, I'll do it

OSBotify pushed a commit that referenced this pull request Aug 26, 2024
Revert PR 47418

(cherry picked from commit f89cb0f)

(CP triggered by puneetlath)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Aug 26, 2024
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

puneetlath added a commit that referenced this pull request Aug 26, 2024
…ng-47998-1

🍒 Cherry pick PR #47998 to staging 🍒
OSBotify pushed a commit that referenced this pull request Aug 26, 2024
…ng-47998-1

🍒 Cherry pick PR #47998 to staging 🍒

(cherry picked from commit f54f9f1)

(CP triggered by puneetlath)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.24-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.24-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants