fix: Web - IOU - Swiping with the mouse causes text to be selected and tabs quickly switching. #48004

Krishna2323 · 2024-08-26T14:19:05Z

Details

Fixed Issues

$ #47651
PROPOSAL: #47651 (comment)

Tests

Navigate to FAB - Submit expense
Switch between Manual, Scan and Distance tabs with the click, hold and swipe method
Verify you can switch between tabs with the mouse smootly and text isn't selected and quick switching isn't happening.

Verify that no errors appear in the JS console

Offline tests

Navigate to FAB - Submit expense
Switch between Manual, Scan and Distance tabs with the click, hold and swipe method
Verify you can switch between tabs with the mouse smootly and text isn't selected and quick switching isn't happening.

QA Steps

Navigate to FAB - Submit expense
Switch between Manual, Scan and Distance tabs with the click, hold and swipe method
Verify you can switch between tabs with the mouse smootly and text isn't selected and quick switching isn't happening.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…d tabs quickly switching. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2024-08-26T14:19:11Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2024-08-27T18:50:13Z

Sorry for delay, I need a bit more time as I see the header button text still gets selected when dragging. I'm trying to find a solution for that and will update very soon.

ZhenjaHorbach · 2024-08-29T18:24:44Z

What is the status PR?

Krishna2323 · 2024-08-29T19:39:32Z

Will be completed today.

Krishna2323 · 2024-08-30T03:25:26Z

@ZhenjaHorbach, the drag isn't working correctly for some reason, can you please check as your end?

Monosnap.screencast.2024-08-30.08-53-23.mp4

ZhenjaHorbach · 2024-08-30T07:20:33Z

Oh yeah
Last main is broken

ZhenjaHorbach · 2024-08-30T07:33:19Z

Looks like problem with this changes
#47885

ZhenjaHorbach · 2024-08-30T20:00:34Z

@Krishna2323
This PR fixed the issue
So you can continue !

Krishna2323 · 2024-08-30T22:40:31Z

Thanks @ZhenjaHorbach, I will start working on this today.

Krishna2323 · 2024-08-31T02:08:23Z

@ZhenjaHorbach I couldn't find any solution for the header text selection but I think it's an edge case so we can ignore that as it only happens if drag all the way to the backdrop. Could you please test and let me know what do you think? I will add the recordings after that. Thanks 🙏🏻

ZhenjaHorbach · 2024-08-31T05:30:14Z

Could you provide a video ?

Krishna2323 · 2024-09-01T05:32:22Z

@ZhenjaHorbach

Monosnap.screencast.2024-09-01.10-59-38.mp4

ZhenjaHorbach · 2024-09-02T08:04:54Z

Yeah
It looks like a specific case
But it is quite easy to reproduce
So let's try again today to try to fix it
And tomorrow we'll decide what to do with it

ZhenjaHorbach · 2024-09-03T11:19:45Z

@Krishna2323

Actually I noticed that this problem is relevant for all modal windows

2024-09-03.12.55.48.mov

So let's fix in this PR only our issue

Krishna2323 · 2024-09-03T11:31:02Z

@ZhenjaHorbach, haha thanks😅, can you please test this out once when you have a chance? I want to make sure everything works fine before I add the videos. I have already tested it at my end. If you think I should add the videos first then let me know.

ZhenjaHorbach · 2024-09-03T11:43:31Z

Just checked
Looks good !
You can start filling out the checklist

Krishna2323 · 2024-09-04T05:27:55Z

@ZhenjaHorbach, checklist completed.

ZhenjaHorbach · 2024-09-04T06:01:07Z

@Krishna2323
Could you please check React Compiler issue ?

https://github.com/Expensify/App/actions/runs/10695658792/job/29649445346?pr=48004

ZhenjaHorbach · 2024-09-05T06:49:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

Krishna2323 · 2024-09-05T06:54:23Z

I was unable to understand the React Compiler issue yesterday, will check again today...

ZhenjaHorbach · 2024-09-05T07:00:18Z

Although everything is fine

Failed to compile src/components/TabSelector/TabSelectorItem.tsx:48:23. Reason: (BuildHIR::lowerExpression) Expected Identifier, got MemberExpression key in ObjectExpression

We can ignore got MemberExpression key in ObjectExpression issue following this comment

ZhenjaHorbach · 2024-09-05T07:28:39Z

LGTM

Krishna2323 · 2024-09-05T10:14:34Z

We can ignore got MemberExpression key in ObjectExpression issue following this comment

@ZhenjaHorbach, do we need to do something? I'm not in the channel so I couldn't open the link.

ZhenjaHorbach · 2024-09-05T10:28:43Z

It's from open-source channel

Krishna2323 · 2024-09-05T10:30:35Z

Thanks for sharing, I don't have access to any channel 😅

stitesExpensify · 2024-09-05T14:27:52Z

This PR looks good to me but is failing the react compiler test for some reason. The error message seems unclear. @kirillzyusko am I missing a more detailed description? All I see is "Some files could be compiled with react-compiler before successfully, but now they can not be compiled."

ZhenjaHorbach · 2024-09-05T14:33:14Z

Currently, the only way to get more details is by running the following command locally

npm run react-compiler-healthcheck-test

And then find the files with changes in react-compiler-output.txt

kirillzyusko · 2024-09-09T10:38:58Z

@stitesExpensify yeah, the error message is not very informative, but it gives enough information for developer who opened a PR (it just contains a filename which file can not be compiled anymore).

We may consider an option to add a specific errors that prevents successful compilation of a particular file. Let me know if you would like to add it!

Regarding this PR - this error can not be fixed due to unsupported syntax, I think it'll be fixed in future versions of react-compiler so we can ignore this error for now. @ZhenjaHorbach correct me if I'm wrong!

ZhenjaHorbach · 2024-09-09T10:40:39Z

@stitesExpensify yeah, the error message is not very informative, but it gives enough information for developer who opened a PR (it just contains a filename which file can not be compiled anymore).

We may consider an option to add a specific errors that prevents successful compilation of a particular file. Let me know if you would like to add it!

Regarding this PR - this error can not be fixed due to unsupported syntax, I think it'll be fixed in future versions of react-compiler so we can ignore this error for now. @ZhenjaHorbach correct me if I'm wrong!

I agree that we can ignore this error for now !

melvin-bot · 2024-09-09T19:44:55Z

@stitesExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

stitesExpensify · 2024-09-09T19:45:21Z

Not an emergency, this test could not pass due to unsupported syntax #48004 (comment)

OSBotify · 2024-09-09T19:56:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru · 2024-09-11T11:20:44Z

#48004 - Fail on Web and Desktop with original KI #47651
https://platform.applause.com/services/links/v1/external/34a3697c9ccc28451fc889c06cb1702fbaef967d838271984edebc7e994ac049
https://platform.applause.com/services/links/v1/external/427704deece3e1c42d19aeb2c7a2066adf27c07d211a5bdc8aa9632a4ec83db3

ZhenjaHorbach · 2024-09-11T15:24:14Z

#48004 - Fail on Web and Desktop with original KI #47651 https://platform.applause.com/services/links/v1/external/34a3697c9ccc28451fc889c06cb1702fbaef967d838271984edebc7e994ac049 https://platform.applause.com/services/links/v1/external/427704deece3e1c42d19aeb2c7a2066adf27c07d211a5bdc8aa9632a4ec83db3

About this
The main goal of this PR was to fix the bug when we drag the headers our header tabs become selected and we quickly switch tabs

In the video we just drag a tab content and tab switches periodically
It's looks like this issue which we closed

#26407
Reason for closing: #26407 (comment)

And also in video when we switched tabs, all the text on the modal was selected
But I'm nor sure that this issue is related to our issue since this issue is typical for all modal windows

#48004 (comment)

But I may be wrong 😅

ZhenjaHorbach · 2024-09-17T19:52:55Z

#48004 - Fail on Web and Desktop with original KI #47651 https://platform.applause.com/services/links/v1/external/34a3697c9ccc28451fc889c06cb1702fbaef967d838271984edebc7e994ac049 https://platform.applause.com/services/links/v1/external/427704deece3e1c42d19aeb2c7a2066adf27c07d211a5bdc8aa9632a4ec83db3

About this The main goal of this PR was to fix the bug when we drag the headers our header tabs become selected and we quickly switch tabs

In the video we just drag a tab content and tab switches periodically It's looks like this issue which we closed

#26407 Reason for closing: #26407 (comment)

And also in video when we switched tabs, all the text on the modal was selected But I'm nor sure that this issue is related to our issue since this issue is typical for all modal windows

#48004 (comment)

But I may be wrong 😅

@stitesExpensify
Could you please share your opinion on this?

stitesExpensify · 2024-09-25T21:34:33Z

I think that you are correct here @ZhenjaHorbach. No further action necessary

fix: Web - IOU - Swiping with the mouse causes text to be selected an…

c116108

…d tabs quickly switching. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner August 26, 2024 14:19

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team August 26, 2024 14:19

Krishna2323 marked this pull request as draft August 26, 2024 14:19

Merge branch 'Expensify:main' into krishna2323/issue/47651

3d8ee4e

Merge branch 'Expensify:main' into krishna2323/issue/47651

9b69e1d

Merge branch 'Expensify:main' into krishna2323/issue/47651

09fa801

Krishna2323 marked this pull request as ready for review September 4, 2024 05:26

Merge branch 'Expensify:main' into krishna2323/issue/47651

f4e2465

ZhenjaHorbach approved these changes Sep 5, 2024

View reviewed changes

melvin-bot bot requested a review from stitesExpensify September 5, 2024 07:28

stitesExpensify approved these changes Sep 5, 2024

View reviewed changes

ZhenjaHorbach mentioned this pull request Sep 9, 2024

[$250] Web - IOU - Swiping with the mouse causes text to be selected and tabs quickly switching #47651

Closed

6 tasks

stitesExpensify merged commit be4b0bc into Expensify:main Sep 9, 2024
15 of 16 checks passed

melvin-bot bot added the Emergency label Sep 9, 2024

stitesExpensify removed the Emergency label Sep 9, 2024

This was referenced Sep 9, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #48845

Closed

Deploy Checklist: New Expensify 2024-09-11 #48954

Closed

izarutskaya mentioned this pull request Sep 11, 2024

Submit expense - Scan tab briefly highlighted when switching to Distance #48992

Closed

6 tasks

fix: Web - IOU - Swiping with the mouse causes text to be selected and tabs quickly switching. #48004

fix: Web - IOU - Swiping with the mouse causes text to be selected and tabs quickly switching. #48004

Conversation

Krishna2323 commented Aug 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 26, 2024

Krishna2323 commented Aug 27, 2024

ZhenjaHorbach commented Aug 29, 2024

Krishna2323 commented Aug 29, 2024

Krishna2323 commented Aug 30, 2024 • edited Loading

ZhenjaHorbach commented Aug 30, 2024 • edited Loading

ZhenjaHorbach commented Aug 30, 2024 • edited Loading

ZhenjaHorbach commented Aug 30, 2024

Krishna2323 commented Aug 30, 2024

Krishna2323 commented Aug 31, 2024 • edited Loading

ZhenjaHorbach commented Aug 31, 2024

Krishna2323 commented Sep 1, 2024

ZhenjaHorbach commented Sep 2, 2024

ZhenjaHorbach commented Sep 3, 2024 • edited Loading

Krishna2323 commented Sep 3, 2024 • edited Loading

ZhenjaHorbach commented Sep 3, 2024 • edited Loading

Krishna2323 commented Sep 4, 2024

ZhenjaHorbach commented Sep 4, 2024 • edited Loading

ZhenjaHorbach commented Sep 5, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Krishna2323 commented Sep 5, 2024

ZhenjaHorbach commented Sep 5, 2024 • edited Loading

ZhenjaHorbach commented Sep 5, 2024

Krishna2323 commented Sep 5, 2024 • edited Loading

ZhenjaHorbach commented Sep 5, 2024

Krishna2323 commented Sep 5, 2024

stitesExpensify commented Sep 5, 2024

ZhenjaHorbach commented Sep 5, 2024 • edited Loading

kirillzyusko commented Sep 9, 2024

ZhenjaHorbach commented Sep 9, 2024

melvin-bot bot commented Sep 9, 2024

stitesExpensify commented Sep 9, 2024

OSBotify commented Sep 9, 2024

kavimuru commented Sep 11, 2024

ZhenjaHorbach commented Sep 11, 2024

ZhenjaHorbach commented Sep 17, 2024

stitesExpensify commented Sep 25, 2024

Krishna2323 commented Aug 26, 2024 •

edited

Loading

Krishna2323 commented Aug 30, 2024 •

edited

Loading

ZhenjaHorbach commented Aug 30, 2024 •

edited

Loading

ZhenjaHorbach commented Aug 30, 2024 •

edited

Loading

Krishna2323 commented Aug 31, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 3, 2024 •

edited

Loading

Krishna2323 commented Sep 3, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 3, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 4, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 5, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 5, 2024 •

edited

Loading

Krishna2323 commented Sep 5, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 5, 2024 •

edited

Loading