Bank account load animation issue #4696 #4805

Santhosh-Sellavel · 2021-08-24T18:28:33Z

Details

Update position of the animated gif added a new header to close the view.
Android Gif Animation was broken, update fresco version to fix it.

Fixed Issues

$ #4696

Tests &QA Steps

Open New Expensify
Click "+"
Click "Create Workspace"
Click "Get Started"
Bank loading animation view will open

Fixes added to Bank loading animation view :

Added a new header with the title One Momentwith the close button.
Animated image position will be moved to top-docked
One moment... under animated image was remove to avoid redundancy

Tested On

Screenshots

Web

Web.mov

Mobile Web

iOS.mov

Desktop

Desktop.mov

iOS

MWeb.mp4

Android

Android.mov

Santhosh-Sellavel · 2021-08-24T19:49:41Z

@Jag96 this is ready for review!

Jag96

This is looking good, I'm just having trouble getting this to run on Android. I'm seeing this error when booting the app:

LOG  Running "NewExpensify" with {"rootTag":1}
WARN  Possible Unhandled Promise Rejection (id: 0):
TypeError: undefined is not a function
TypeError: undefined is not a function
    at sendDataToConnection (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:131284:46)
    at anonymous (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:131333:40)
    at tryCallOne (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:31831:16)
    at anonymous (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:31932:27)
    at apply (native)
    at anonymous (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:32372:26)
    at _callTimer (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:32260:17)
    at _callImmediatesPass (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:32299:17)
    at callImmediates (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:32516:33)
    at __callImmediates (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:6152:35)
    at anonymous (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:5931:34)
    at __guard (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:6135:15)
    at flushedQueue (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:5930:21)
    at invokeCallbackAndReturnFlushedQueue (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:5923:33)

It seems to be working fine in the PR description gif, @Santhosh-Sellavel are you seeing the same thing? I have no issue running it on main, if you aren't seeing the issue I can ask in slack to see if anybody else can reproduce.

Jag96 · 2021-08-25T20:44:04Z

android/app/build.gradle

-    implementation 'com.facebook.fresco:animated-gif:2.3.0'
+    implementation 'com.facebook.fresco:fresco:2.5.0'
+    implementation 'com.facebook.fresco:animated-gif:2.5.0'
+


Remove extra line

Will remove it.

Santhosh-Sellavel · 2021-08-26T03:17:25Z

It seems to be working fine in the PR description gif, @Santhosh-Sellavel are you seeing the same thing?
I have no issue running it on main, if you aren't seeing the issue I can ask in slack to see if anybody else can reproduce?

What are you asking about here about gif issues or error reproduction?. @Jag96

Gif issue?

Before the fix,
I was able to reproduce consistently in my personal device running android 11 S20 Plus
In simulator running Android 12.0 beta

After the fix,
I verified in both devices it's working fine for me.

Booting up issue - this one?

I facing this issue for few days because the simulator time is not updating properly when I manually update time in settings it works fine.

I can reproduce the error across all branches.

Jag96

I facing this issue for few days because the simulator time is not updating properly when I manually update time in settings it works fine. I can reproduce the error across all branches.

@Santhosh-Sellavel can you merge main into your branch and update? I did an npx react-native-clean-project and that fixed the issue I encountered yesterday. I am now seeing the following issue on the CompanyStep, however, which seems to be fixed on main:

Once it's updated I'll fully test the VBA flow to confirm all the screens look good, thanks for bearing with me on this one!

Santhosh-Sellavel · 2021-08-26T20:12:17Z

@Jag96 No issues 👍

Jag96 · 2021-08-26T20:27:58Z

@Santhosh-Sellavel can you do a git merge main on your branch and push up the changes? Just so I can run through the tests on android for the entire flow, including the Company Step (where I'm getting the autoCompleteType error), not just the first step.

Santhosh-Sellavel · 2021-08-27T03:51:26Z

Pushed now. @Jag96

Jag96

LGTM!

OSBotify · 2021-08-27T16:14:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2021-08-30T17:32:27Z

🚀 Deployed to staging by @Jag96 in version: 1.0.88-3 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2021-09-01T01:43:11Z

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Santhosh-Sellavel added 2 commits August 17, 2021 23:28

Animation position changed to top

88d4cf9

VBA Loading page updated with header & title

2e30fab

Santhosh-Sellavel requested a review from a team as a code owner August 24, 2021 18:28

MelvinBot requested review from Jag96 and removed request for a team August 24, 2021 18:28

Jag96 mentioned this pull request Aug 24, 2021

[HOLD for payment + bonus] Make bank account loading animations consistently top docked in the right hand pane #4696

Closed

Fresco version updated to 2.5.0

60afb75

Jag96 reviewed Aug 25, 2021

View reviewed changes

Unwanted line removed

492dfe5

Santhosh-Sellavel requested a review from Jag96 August 26, 2021 03:34

Jag96 suggested changes Aug 26, 2021

View reviewed changes

Merge branch 'main' into BankAccount_Animation_Issue

66c2262

Santhosh-Sellavel requested a review from Jag96 August 27, 2021 15:59

Jag96 approved these changes Aug 27, 2021

View reviewed changes

Jag96 merged commit ea65ccf into Expensify:main Aug 27, 2021

OSBotify mentioned this pull request Aug 27, 2021

Deploy Checklist: New Expensify 2021-08-25 #4828

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bank account load animation issue #4696 #4805

Bank account load animation issue #4696 #4805

Santhosh-Sellavel commented Aug 24, 2021 •

edited

Loading

Santhosh-Sellavel commented Aug 24, 2021

Jag96 left a comment •

edited

Loading

Jag96 Aug 25, 2021

Santhosh-Sellavel Aug 26, 2021

Santhosh-Sellavel Aug 26, 2021

Santhosh-Sellavel commented Aug 26, 2021

Jag96 left a comment •

edited

Loading

Santhosh-Sellavel commented Aug 26, 2021

Jag96 commented Aug 26, 2021

Santhosh-Sellavel commented Aug 27, 2021

Jag96 left a comment

OSBotify commented Aug 27, 2021

OSBotify commented Aug 30, 2021

OSBotify commented Sep 1, 2021

Bank account load animation issue #4696 #4805

Bank account load animation issue #4696 #4805

Conversation

Santhosh-Sellavel commented Aug 24, 2021 • edited Loading

Details

Fixed Issues

Tests &QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Santhosh-Sellavel commented Aug 24, 2021

Jag96 left a comment • edited Loading

Choose a reason for hiding this comment

Jag96 Aug 25, 2021

Choose a reason for hiding this comment

Santhosh-Sellavel Aug 26, 2021

Choose a reason for hiding this comment

Santhosh-Sellavel Aug 26, 2021

Choose a reason for hiding this comment

Santhosh-Sellavel commented Aug 26, 2021

Gif issue?

Booting up issue - this one?

Jag96 left a comment • edited Loading

Choose a reason for hiding this comment

Santhosh-Sellavel commented Aug 26, 2021

Jag96 commented Aug 26, 2021

Santhosh-Sellavel commented Aug 27, 2021

Jag96 left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 27, 2021

OSBotify commented Aug 30, 2021

OSBotify commented Sep 1, 2021

Santhosh-Sellavel commented Aug 24, 2021 •

edited

Loading

Jag96 left a comment •

edited

Loading

Jag96 left a comment •

edited

Loading