Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258

SzymczakJ · 2024-08-29T12:06:44Z

Details

This PR adds an animation that hides mobile Search nav bar on scroll down and reveals it on scrollUp. Please note that this feature is only meant to work on mobile screens. Also when user doesn't have enough expenses, the bar won't hide.

Fixed Issues

$ #48019
PROPOSAL:

Tests

Go to Search tab that has a lot of expenses.
Try scrolling and make sure expense type and status bar hides and shows properly.
Go to Search tab that has little or no expenses.
Make sure and make sure expense type and status bar is locked in place.

Offline tests

QA Steps

Same as test steps

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

animAndroid.mov

Android: mWeb Chrome

animAndroidweb.mov

iOS: Native

animIos.mov

iOS: mWeb Safari

iosweb.mov

MacOS: Chrome / Safari

MacOS: Desktop

Guccio163

generally LGTM, works great! 👀

Kicu

Hey very nice work both on animation and refactoring. SearchPageHeader feels much simpler, and also Search component also looks simpler.

My only real problem is with SearchPageBottom because it became harder to read.
Most of my comments are minor naming issues, LGTM otherwise 👍

src/pages/Search/SearchPageBottomTab.tsx

src/components/Search/index.tsx

src/components/Search/SearchStatusBar.tsx

Kicu · 2024-09-03T15:10:48Z

src/components/Search/SearchPageHeader.tsx

    isCustomQuery: boolean;
-    setOfflineModalOpen?: () => void;
-    setDownloadErrorModalOpen?: () => void;
-    data?: TransactionListItemType[] | ReportListItemType[];


great job removing so many props! 👏

src/components/Search/index.tsx

src/components/SelectionList/index.tsx

src/libs/SearchUtils.ts

Kicu · 2024-09-03T15:24:01Z

src/pages/Search/SearchPageBottomTab.tsx

+                                hash={queryJSON.hash}
+                                isCustomQuery={isCustomQuery}
+                            />
+                        )}


Do you think its possible to somehow simplify this and reduce the amount of conditional rendering inside this return?
We have conditional rendering for TopBar + SearchTypeMenu, then extra condition for SearchStatusBar and all that is exclusive with SearchPageHeader rendering.
It's very hard to understand which parts of the UI will be rendered.

Some ideas:

early returns?

saving parts of JSX to variables?

small helper components declared within this file?

I think you could try to go over this code again and see if anything can be improved.

melvin-bot · 2024-09-04T09:06:02Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-09-04T10:23:30Z

Running a test build for easier testing...

shawnborton · 2024-09-04T10:42:27Z

Any idea how to fix the iOS build above so we can test?

SzymczakJ · 2024-09-04T12:10:11Z

I merged main and the error should be solved(ruby-version file was missing, but it was reintroduced after merge). Can you try again?

shawnborton · 2024-09-04T12:12:00Z

Will do!

github-actions · 2024-09-04T12:51:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48258/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48258/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48258/NewExpensify.dmg	https://48258.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dannymcclain · 2024-09-04T13:58:24Z

I think this is feeling pretty darn good!

luacmartins · 2024-09-24T23:38:48Z

Cool, so it seems like the current behavior is expected. @rayane-djouah let's continue with the review.

rayane-djouah · 2024-09-25T05:51:06Z

@SzymczakJ Let's address my requested changes above

rayane-djouah · 2024-09-26T00:27:07Z

We have conflicts also

luacmartins · 2024-09-26T00:56:23Z

Waiting on @SzymczakJ to address the comments above

SzymczakJ · 2024-09-26T13:30:59Z

I'll work on it today, I'm just prioritising #49457

luacmartins · 2024-09-26T14:55:55Z

@SzymczakJ yes, let's prioritize #49457

SzymczakJ · 2024-09-26T16:50:15Z

Bumped into bug on #49457, so no update for today

SzymczakJ · 2024-09-27T11:20:04Z

fixed comments and conflicts @rayane-djouah

SzymczakJ · 2024-09-30T09:14:31Z

kind bump @rayane-djouah 🙇

rayane-djouah

Looks good! One last comment

rayane-djouah · 2024-09-30T10:12:24Z

src/pages/Search/SearchSelectedNarrow.tsx

@@ -45,7 +45,7 @@ function SearchSelectedNarrow({options, itemsLength}: SearchSelectedNarrowProps)
    };

    return (
-        <View style={[styles.pb4]}>
+        <View>


Last comment 😄 : To make this view consistent with the room members view, let's reduce the padding to 12px instead of removing it entirely. This way, we will have a total of 24px between the drop-down button and the 'Select All' checkbox.

Suggested change

<View>

<View style={[styles.pb3]} >

Room members Search

SzymczakJ · 2024-09-30T11:12:55Z

Done!

rayane-djouah

Looks good to me and tests well. Thanks for the great work!

luacmartins

LGTM great work!

OSBotify · 2024-09-30T14:03:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Kicu · 2024-09-30T14:24:28Z

👏

github-actions · 2024-09-30T22:57:05Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-02T00:19:56Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.42-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ikevin127 · 2024-10-15T21:11:05Z

This PR caused the following issue:

[$250] [HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list #50227

which was caused by wrapping SearchTypeMenu in Animated.View which caused the scroll to stop working. It was fixed in a follow-up PR by this PRs reviewer.

mkhutornyi · 2024-10-28T18:35:08Z

src/styles/index.ts

+        },
+
+        searchListContentContainerStyles: {
+            marginTop: variables.searchListContentMarginTop,


We should use padding instead of margin for contentContainerStyle of ScrollView.
Related bug: #50649
Root cause: #50649 (comment)

SzymczakJ added 3 commits August 29, 2024 13:51

add animation logic

0cdffe1

Merge branch 'main' into @szymczak/search-bar-hiding

ce6f1cc

prettify code

6ea15d8

Guccio163 approved these changes Aug 30, 2024

View reviewed changes

SzymczakJ added 7 commits September 2, 2024 10:46

adjust padding

ec1402b

Merge branch 'main' into @szymczak/search-bar-hiding

c2cb62e

make SearchPageHeader use SearchContext instead of accepting data param

e93ceca

move modals from Search/index to SearchPageHeader

1e5ff51

fix paddings

cd01f44

fix EmptyState and Loading screen paddings

ce7d213

fix loading state bug

709e93d

Kicu suggested changes Sep 3, 2024

View reviewed changes

SzymczakJ added 3 commits September 3, 2024 18:26

fix PR comments

317cc9e

Merge branch 'main' into @szymczak/search-bar-hiding

8fd252b

fix typo in comment

8794f8c

SzymczakJ marked this pull request as ready for review September 4, 2024 09:05

SzymczakJ requested review from a team as code owners September 4, 2024 09:05

melvin-bot bot requested review from rayane-djouah and removed request for a team September 4, 2024 09:06

shawnborton added the Ready To Build label Sep 4, 2024

This comment has been minimized.

Sign in to view

Merge branch 'main' into @szymczak/search-bar-hiding

261df38

SzymczakJ added 3 commits September 27, 2024 11:36

Merge branch 'main' into @szymczak/search-bar-hiding

557625b

fix PR comments

89f95be

fix styles

c507ca1

Merge branch 'main' into @szymczak/search-bar-hiding

ca27414

rayane-djouah suggested changes Sep 30, 2024

View reviewed changes

fix styles

029f277

rayane-djouah approved these changes Sep 30, 2024

View reviewed changes

luacmartins approved these changes Sep 30, 2024

View reviewed changes

luacmartins merged commit decf515 into Expensify:main Sep 30, 2024
17 checks passed

github-actions bot mentioned this pull request Sep 30, 2024

Deploy Checklist: New Expensify 2024-09-30 #49960

Closed

49 tasks

luacmartins mentioned this pull request Oct 1, 2024

[HOLD for payment 2024-10-10] [Search v1.2] "this expense" in Delete modal changes to "these expenses" after deleting an expense #49980

Closed

6 tasks

rayane-djouah mentioned this pull request Oct 2, 2024

[HOLD for Payment 2024-10-07][$250] [Search v2.2] Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48019

Closed

jayeshmangwani mentioned this pull request Oct 4, 2024

[$250] [HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list #50227

Closed

6 tasks

bernhardoj mentioned this pull request Oct 11, 2024

[HOLD for payment 2024-10-29] [$62.50] Android - Chat search - Unable to reach the bottom of chat list when scrolling down #50649

Closed

6 tasks

mkhutornyi reviewed Oct 28, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258

Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258

SzymczakJ commented Aug 29, 2024 •

edited

Loading

Guccio163 left a comment

Kicu left a comment

Kicu Sep 3, 2024

Kicu Sep 3, 2024

melvin-bot bot commented Sep 4, 2024

shawnborton commented Sep 4, 2024

This comment has been minimized.

shawnborton commented Sep 4, 2024

SzymczakJ commented Sep 4, 2024

shawnborton commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

dannymcclain commented Sep 4, 2024

luacmartins commented Sep 24, 2024

rayane-djouah commented Sep 25, 2024

rayane-djouah commented Sep 26, 2024

luacmartins commented Sep 26, 2024

SzymczakJ commented Sep 26, 2024

luacmartins commented Sep 26, 2024

SzymczakJ commented Sep 26, 2024

SzymczakJ commented Sep 27, 2024

SzymczakJ commented Sep 30, 2024

rayane-djouah left a comment

rayane-djouah Sep 30, 2024

SzymczakJ commented Sep 30, 2024

rayane-djouah left a comment

luacmartins left a comment

OSBotify commented Sep 30, 2024

Kicu commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Oct 2, 2024

ikevin127 commented Oct 15, 2024

mkhutornyi Oct 28, 2024

Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258

Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258

Conversation

SzymczakJ commented Aug 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Guccio163 left a comment

Choose a reason for hiding this comment

Kicu left a comment

Choose a reason for hiding this comment

Kicu Sep 3, 2024

Choose a reason for hiding this comment

Kicu Sep 3, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Sep 4, 2024

shawnborton commented Sep 4, 2024

This comment has been minimized.

shawnborton commented Sep 4, 2024

SzymczakJ commented Sep 4, 2024

shawnborton commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

dannymcclain commented Sep 4, 2024

luacmartins commented Sep 24, 2024

rayane-djouah commented Sep 25, 2024

rayane-djouah commented Sep 26, 2024

luacmartins commented Sep 26, 2024

SzymczakJ commented Sep 26, 2024

luacmartins commented Sep 26, 2024

SzymczakJ commented Sep 26, 2024

SzymczakJ commented Sep 27, 2024

SzymczakJ commented Sep 30, 2024

rayane-djouah left a comment

Choose a reason for hiding this comment

rayane-djouah Sep 30, 2024

Choose a reason for hiding this comment

SzymczakJ commented Sep 30, 2024

rayane-djouah left a comment

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 30, 2024

Kicu commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Oct 2, 2024

ikevin127 commented Oct 15, 2024

mkhutornyi Oct 28, 2024

Choose a reason for hiding this comment

SzymczakJ commented Aug 29, 2024 •

edited

Loading