fix: concurrent unmount when app is offline #48474

kirillzyusko · 2024-09-03T13:47:33Z

Details

Fixes concurrent unmount (when deleting an expense report from self dm in offline mode).

Initially I thought that we are trying to update and unmount a view simultaneously, and the first idea was to postpone updates of some props and I added hook like:

const useScheduledUpdate = (v) => {
  const [value, setValue] = useState(v);

  useEffect(() => {
    setTimeout(() => setValue(v), 5000);
  }, [v]);

  return value;
}

But I just discovered that I'm postponing a crash for 5 seconds 😅

The second thing that I wanted to try is to cancel unmount operation if view is already unmounted - I added necessary code and discovered, that it breaks the app in some cases (for example when you open a "track expense" screen, then the spinner never disappears).

So I started to look closer and I discovered, that as soon as we adding { opacity: 0.5 } style - the app crashes immediately. So I tried to add { opacity: 0.99 } as initial value and the crash disappears (when I add { opacity: 1 } then crash appear again).

So I think as a temporary workaround it can be added to the codebase. And in a meantime I'll discover what's exactly causing the problem and provide a proper solution later.

Fixed Issues

$ #48197
PROPOSAL: N/A

Tests

Open the app and log in
Navigate to self-DM
Tap + > Track expense > Manual
Create an expense
Disable the internet connection
Long tap the expense > Delete expense
Be sure that app is not crashing

Offline tests

Open the app and log in
Navigate to self-DM
Tap + > Track expense > Manual
Create an expense
Disable the internet connection
Long tap the expense > Delete expense
Be sure that app is not crashing

QA Steps

Open the app and log in
Navigate to self-DM
Tap + > Track expense > Manual
Create an expense
Disable the internet connection
Long tap the expense > Delete expense
Be sure that app is not crashing

PR Author Checklist

Screenshots/Videos

Android: Native

telegram-cloud-document-2-5384529808128497894.mp4

Android: mWeb Chrome

telegram-cloud-document-2-5384529808128497850.mp4

iOS: Native

RPReplay_Final1725370433.MP4

iOS: mWeb Safari

RPReplay_Final1725373845.MP4

MacOS: Chrome / Safari

Screen.Recording.2024-09-03.at.16.03.06.mov

MacOS: Desktop

Screen.Recording.2024-09-03.at.16.10.18.mov

melvin-bot · 2024-09-03T15:12:32Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2024-09-04T07:35:44Z

@suneox Do you want to do the review here?

suneox · 2024-09-04T09:15:05Z

@suneox Do you want to do the review here?

I’ve unassigned myself from the issue, so you can review this PR. Thank you!

jjcoffee · 2024-09-09T08:55:32Z

@kirillzyusko Any thoughts on this?

kirillzyusko · 2024-09-09T11:53:04Z

@jjcoffee checking it now 👀

kirillzyusko · 2024-09-09T14:57:30Z

I can not reproduce the problem locally that @jjcoffee discovered

We will try to co-operate tomorrow to fix it!

jjcoffee · 2024-09-10T11:07:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-09-10_13.33.42.mp4

Android: mWeb Chrome

android-chrome-2024-09-10_13.37.04.mp4

iOS: Native

ios-app-2024-09-10_13.54.18.mp4

iOS: mWeb Safari

ios-safari-2024-09-10_13.57.59.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-09-10_13.09.33.mp4

MacOS: Desktop

desktop-app-2024-09-10_13.29.23.mp4

jjcoffee

Applying the fix to iOS-only works as a temp workaround for me!

chiragsalian

LGTM. Proceeding to merge because i think design review is not really required here as it's fixing a crash.

OSBotify · 2024-09-11T00:45:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-12T21:18:59Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.33-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kirillzyusko marked this pull request as ready for review September 3, 2024 15:12

kirillzyusko requested review from a team as code owners September 3, 2024 15:12

melvin-bot bot requested review from jjcoffee and removed request for a team September 3, 2024 15:12

kirillzyusko mentioned this pull request Sep 3, 2024

[$250] iOS - Track expense - App crashes after deleting expense offline #48197

Closed

6 tasks

This comment was marked as resolved.

Sign in to view

fix: concurrent unmount when app is offline

be6acac

kirillzyusko force-pushed the fix/48197-offline-crash branch from d0c1bb9 to be6acac Compare September 9, 2024 14:29

This comment was marked as resolved.

Sign in to view

fix: apply workaround only to iOS and add meaningful comment

e42ab85

jjcoffee approved these changes Sep 10, 2024

View reviewed changes

melvin-bot bot requested a review from chiragsalian September 10, 2024 15:04

chiragsalian approved these changes Sep 11, 2024

View reviewed changes

chiragsalian merged commit 1e8d80e into Expensify:main Sep 11, 2024
16 checks passed

github-actions bot mentioned this pull request Sep 11, 2024

Deploy Checklist: New Expensify 2024-09-11 #49025

Closed

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: concurrent unmount when app is offline #48474

fix: concurrent unmount when app is offline #48474

kirillzyusko commented Sep 3, 2024 •

edited

Loading

melvin-bot bot commented Sep 3, 2024

jjcoffee commented Sep 4, 2024

suneox commented Sep 4, 2024

This comment was marked as resolved.

jjcoffee commented Sep 9, 2024

kirillzyusko commented Sep 9, 2024

kirillzyusko commented Sep 9, 2024

jjcoffee commented Sep 10, 2024 •

edited

Loading

This comment was marked as resolved.

jjcoffee left a comment

chiragsalian left a comment

OSBotify commented Sep 11, 2024

OSBotify commented Sep 12, 2024

fix: concurrent unmount when app is offline #48474

fix: concurrent unmount when app is offline #48474

Conversation

kirillzyusko commented Sep 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 3, 2024

jjcoffee commented Sep 4, 2024

suneox commented Sep 4, 2024

This comment was marked as resolved.

jjcoffee commented Sep 9, 2024

kirillzyusko commented Sep 9, 2024

kirillzyusko commented Sep 9, 2024

jjcoffee commented Sep 10, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

This comment was marked as resolved.

jjcoffee left a comment

Choose a reason for hiding this comment

chiragsalian left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 11, 2024

OSBotify commented Sep 12, 2024

kirillzyusko commented Sep 3, 2024 •

edited

Loading

jjcoffee commented Sep 10, 2024 •

edited

Loading