[NO QA]: Company card details #48491

narefyev91 · 2024-09-03T16:29:47Z

Details

Company Card details page

Fixed Issues

Preconditions:
We need to add mock information for card in Onyx - i added them inside src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx - just uncomment useEffect
We adding as well some mock data to test export cards account - i used quickbooks online for mock data

Tests

Be sure that Company cards enabled for workspace
In the list of company cards - select the first one (should probably connected with mock data)
Verify that company card details page is opened and data is displaying in the fields
Click on Card name change -> verify that new page is opened -> changed name -> click save -> verify that name is changed on details screen page
Click on Export account -> verify that new page with list of available cards is opened -> click on link inside text above the list -> verify that link will redirects you to 'accounting/quickbooks-online/export'
Go back to Export account list selection -> choose any other card -> verify that new export account will be shown on card details page
Click on update card button -> verify that text is changed to "Updating..." and loading spinner is shown to the right
Click in Unassign Card button -> verify that confirmation modal is shown -> click Unassign -> verify that app redirects you to all cards list screen ->verify in Onyx store that card was deleted from that user
Refresh the page to put mock data again in store
Go to Members page -> find mock member by account id -> click on the row -> verify that user has assigned card
Click on assigned card -> verify that card details is opened. All interaction with details should be the same as points above

Verify that no errors appear in the JS console

Offline tests

Be sure that Company cards enabled for workspace
In the list of company cards - select the first one (should probably connected with mock data)
Verify that company card details page is opened and data is displaying in the fields
Click on Card name change -> verify that new page is opened -> changed name -> click save -> verify that name is changed on details screen page
Click on Export account -> verify that new page with list of available cards is opened -> click on link inside text above the list -> verify that link will redirects you to 'accounting/quickbooks-online/export'
Go back to Export account list selection -> choose any other card -> verify that new export account will be shown on card details page
Click on update card button -> verify that text is changed to "Updating..." and loading spinner is shown to the right
Click in Unassign Card button -> verify that confirmation modal is shown -> click Unassign -> verify that app redirects you to all cards list screen ->verify in Onyx store that card was deleted from that user
Refresh the page to put mock data again in store
Go to Members page -> find mock member by account id -> click on the row -> verify that user has assigned card
Click on assigned card -> verify that card details is opened. All interaction with details should be the same as points above

QA Steps

Be sure that Company cards enabled for workspace
In the list of company cards - select the first one (should probably connected with mock data)
Verify that company card details page is opened and data is displaying in the fields
Click on Card name change -> verify that new page is opened -> changed name -> click save -> verify that name is changed on details screen page
Click on Export account -> verify that new page with list of available cards is opened -> click on link inside text above the list -> verify that link will redirects you to 'accounting/quickbooks-online/export'
Go back to Export account list selection -> choose any other card -> verify that new export account will be shown on card details page
Click on update card button -> verify that text is changed to "Updating..." and loading spinner is shown to the right
Click in Unassign Card button -> verify that confirmation modal is shown -> click Unassign -> verify that app redirects you to all cards list screen ->verify in Onyx store that card was deleted from that user
Refresh the page to put mock data again in store
Go to Members page -> find mock member by account id -> click on the row -> verify that user has assigned card
Click on assigned card -> verify that card details is opened. All interaction with details should be the same as points above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mov

android2.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

Screen.Recording.2024-09-10.at.16.04.33.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web1.mov

web2.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-09-03T16:29:52Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

# Conflicts: # src/components/Icon/Illustrations.ts

dubielzyk-expensify · 2024-09-04T03:38:22Z

Let us know when you got some screenshots and we'll do a design review 😄

narefyev91 · 2024-09-04T07:08:50Z

@dubielzyk-expensify here we go:

Seems like we do not have correct icon for Unassign user - could you please provide it. Thanks!

dannymcclain · 2024-09-04T14:19:06Z

These option rows should just use the default color for their icons, which should be success:

They should essentially look the same as these:

cc @Expensify/design

shawnborton · 2024-09-04T17:19:45Z

Yup, agree with Danny here!

dubielzyk-expensify · 2024-09-05T04:54:47Z

What Danny said and otherwise this is looking good to me 👍

allroundexperts · 2024-09-08T20:01:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-09.at.11.08.44.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-09-09.at.11.07.00.PM.mov

iOS: Native

Screen.Recording.2024-09-09.at.11.03.02.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-09-09.at.11.04.49.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-09.at.10.53.55.PM.mov

MacOS: Desktop

Screen.Recording.2024-09-09.at.11.00.49.PM.mov

allroundexperts · 2024-09-08T20:02:16Z

@narefyev91 Can you please finish the checklist and make sure that the lint errors are resolved?

# Conflicts: # src/ROUTES.ts # src/libs/Navigation/linkingConfig/FULL_SCREEN_TO_RHP_MAPPING.ts # src/libs/actions/Policy/Policy.ts

allroundexperts · 2024-09-09T17:45:14Z

@narefyev91 Can I please have testing steps?

allroundexperts · 2024-09-09T18:16:28Z

@narefyev91 On the following screen size, the buttons are stacked too close to each other. The settings button also seems to be clipped.

allroundexperts · 2024-09-09T18:16:55Z

Getting the following console warnings on the card name edit page:

narefyev91 · 2024-09-10T13:07:57Z

Getting the following console warnings on the card name edit page:

Probably it's global problem with TextInput. Also spotted that on Create new task page

# Conflicts: # src/CONST.ts # src/components/Icon/Illustrations.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

allroundexperts · 2024-09-11T13:25:40Z

@narefyev91 Is this ready for review again?

narefyev91 · 2024-09-11T13:30:02Z

@narefyev91 Is this ready for review again?

Yeah - just pushing latest changes for offline support - which was approved yesterday

# Conflicts: # src/libs/API/parameters/index.ts # src/libs/API/types.ts # src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx # src/types/form/index.ts

narefyev91 · 2024-09-12T10:14:31Z

@allroundexperts Hey! Can you please review again? Thanks!

allroundexperts · 2024-09-12T15:47:11Z

Sure. Will review again today!

allroundexperts

Looks good!

narefyev91 · 2024-09-13T11:37:26Z

Friendly bump on this one @yuwenmemon, Thanks!

yuwenmemon · 2024-09-13T18:00:40Z

Thanks!

OSBotify · 2024-09-13T18:12:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-13T23:05:36Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.35-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-16T18:21:33Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.35-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

nkuoch · 2024-11-01T13:56:27Z

Just saw a log error making the call to SetCardExportAccount fail:

Malformed REQUEST: 'exportAccountDetails', ignoring (should match '{(?:"\w+":.+?)(?:,"\w+":.+?)*}') ~~ value: '[object Object]'

How are we sending exportAccountDetails? JSON string? Example of what we'd expect: '{"quickbooks_online_export_account_debit_policy_id":"5CF1E5435E6EE1BA","quickbooks_online_export_account_debit":"163"}'

allgandalf · 2024-11-17T14:57:07Z

src/libs/API/parameters/UpdateCompanyCard.ts

@@ -0,0 +1,6 @@
+type UpdateCompanyCard = {
+    authToken?: string | null;
+    cardID: string;


cardID was supposed to be of type number, this caused #51895

allgandalf · 2024-11-17T15:06:28Z

src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx

+    );
+
+    return (
+        <SelectionScreen


We didn't not include a search option like we do in other places in the app when the number of options is more than 8, this caused #51884

DylanDylann · 2024-11-19T02:39:22Z

src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx

+                            />
+                            <MenuItemWithTopDescription
+                                description={translate('workspace.moreFeatures.companyCards.transactionStartDate')}
+                                title={card?.startDate ? format(card.startDate, CONST.DATE.FNS_FORMAT_STRING) : ''}


It was causing this issue. More explained here

DylanDylann · 2024-11-19T02:49:55Z

src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx

+                            />
+                            <MenuItemWithTopDescription
+                                description={translate('workspace.moreFeatures.companyCards.cardNumber')}
+                                title={CardUtils.maskCard(card?.lastFourPAN)}


It caused this issue, we need to mask the card name to display 6 first numbers and 4 last numbers

DylanDylann · 2024-11-19T02:57:51Z

src/libs/actions/Policy/Policy.ts

@@ -4610,6 +4612,242 @@ function deleteWorkspaceCompanyCardFeed(policyID: string, workspaceAccountID: nu
    API.write(WRITE_COMMANDS.DELETE_COMPANY_CARD_FEED, parameters, onyxData);
 }

+function unassignWorkspaceCompanyCard(workspaceAccountID: number, cardID: string, bankName: string) {


We missed to update the optimistic data to apply online pattern B on this action

Company card details

bc7e802

narefyev91 requested review from a team as code owners September 3, 2024 16:29

melvin-bot bot requested review from allroundexperts and removed request for a team September 3, 2024 16:29

narefyev91 added 2 commits September 3, 2024 19:31

Merge branch 'refs/heads/main' into company-card-details

42a39e4

# Conflicts: # src/components/Icon/Illustrations.ts

rollback permissions

d4856ea

mkhutornyi mentioned this pull request Sep 4, 2024

[$250] Upgrading for Company Cards doesn't enable Company Cards #48425

Closed

6 tasks

Merge branch 'refs/heads/main' into company-card-details

55d1503

Add member workspace changes

ec7e333

narefyev91 added 2 commits September 9, 2024 12:03

Merge branch 'refs/heads/main' into company-card-details

7a62f8b

# Conflicts: # src/ROUTES.ts # src/libs/Navigation/linkingConfig/FULL_SCREEN_TO_RHP_MAPPING.ts # src/libs/actions/Policy/Policy.ts

fixes after merge

276f645

narefyev91 changed the title ~~Company card details~~ [NO QA]: Company card details Sep 9, 2024

koko57 mentioned this pull request Sep 9, 2024

[$250] [3rd Party Feeds] Viewing cards on workspace member profile #47379

Closed

1 task

narefyev91 added 2 commits September 9, 2024 17:25

Add logic for change export account, rework on card info object

5354c4d

fix lint

5126ff1

Merge branch 'refs/heads/main' into company-card-details

e13fd31

latest updates

d533e95

narefyev91 added 2 commits September 11, 2024 10:35

Merge branch 'refs/heads/main' into company-card-details

1b79469

# Conflicts: # src/CONST.ts # src/components/Icon/Illustrations.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

fix ts

98efbce

add pattern b for api calls in card details

2e864da

Merge branch 'refs/heads/main' into company-card-details

6926dd0

# Conflicts: # src/libs/API/parameters/index.ts # src/libs/API/types.ts # src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx # src/types/form/index.ts

allroundexperts approved these changes Sep 12, 2024

View reviewed changes

melvin-bot bot requested a review from yuwenmemon September 12, 2024 19:22

yuwenmemon approved these changes Sep 13, 2024

View reviewed changes

yuwenmemon merged commit 50cc548 into Expensify:main Sep 13, 2024
16 checks passed

github-actions bot mentioned this pull request Sep 13, 2024

Deploy Checklist: New Expensify 2024-09-13 #49195

Closed

55 tasks

allgandalf reviewed Nov 17, 2024

View reviewed changes

DylanDylann reviewed Nov 19, 2024

View reviewed changes

DylanDylann mentioned this pull request Nov 19, 2024

[HOLD for payment 2024-11-20] [Workspace Feeds] Transaction start date in card details page is one day prior to the selected date when assigning a card #51915

Closed

8 tasks

DylanDylann reviewed Nov 19, 2024

View reviewed changes

DylanDylann mentioned this pull request Nov 19, 2024

[HOLD for payment 2024-11-20] [Workspace Feeds] Only showing last 4 digits of card on card details page #51912

Closed

8 tasks

DylanDylann reviewed Nov 19, 2024

View reviewed changes

DylanDylann mentioned this pull request Nov 19, 2024

[HOLD for payment 2024-11-26] [HOLD for payment 2024-11-21] [HOLD for payment 2024-11-20] [Workspace feeds] Unassigning a card offline seems to use pattern A, when the doc says it should be pattern B. #51876

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA]: Company card details #48491

[NO QA]: Company card details #48491

narefyev91 commented Sep 3, 2024 •

edited

Loading

melvin-bot bot commented Sep 3, 2024

dubielzyk-expensify commented Sep 4, 2024

narefyev91 commented Sep 4, 2024 •

edited

Loading

dannymcclain commented Sep 4, 2024

shawnborton commented Sep 4, 2024

dubielzyk-expensify commented Sep 5, 2024

allroundexperts commented Sep 8, 2024 •

edited

Loading

allroundexperts commented Sep 8, 2024

allroundexperts commented Sep 9, 2024

allroundexperts commented Sep 9, 2024

allroundexperts commented Sep 9, 2024

narefyev91 commented Sep 10, 2024

allroundexperts commented Sep 11, 2024

narefyev91 commented Sep 11, 2024 •

edited

Loading

narefyev91 commented Sep 12, 2024

allroundexperts commented Sep 12, 2024

allroundexperts left a comment

narefyev91 commented Sep 13, 2024

yuwenmemon commented Sep 13, 2024

OSBotify commented Sep 13, 2024

OSBotify commented Sep 13, 2024

OSBotify commented Sep 16, 2024

nkuoch commented Nov 1, 2024

allgandalf Nov 17, 2024

allgandalf Nov 17, 2024

DylanDylann Nov 19, 2024

DylanDylann Nov 19, 2024

DylanDylann Nov 19, 2024

[NO QA]: Company card details #48491

[NO QA]: Company card details #48491

Conversation

narefyev91 commented Sep 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 3, 2024

dubielzyk-expensify commented Sep 4, 2024

narefyev91 commented Sep 4, 2024 • edited Loading

dannymcclain commented Sep 4, 2024

shawnborton commented Sep 4, 2024

dubielzyk-expensify commented Sep 5, 2024

allroundexperts commented Sep 8, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Sep 8, 2024

allroundexperts commented Sep 9, 2024

allroundexperts commented Sep 9, 2024

allroundexperts commented Sep 9, 2024

narefyev91 commented Sep 10, 2024

allroundexperts commented Sep 11, 2024

narefyev91 commented Sep 11, 2024 • edited Loading

narefyev91 commented Sep 12, 2024

allroundexperts commented Sep 12, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

narefyev91 commented Sep 13, 2024

yuwenmemon commented Sep 13, 2024

OSBotify commented Sep 13, 2024

OSBotify commented Sep 13, 2024

OSBotify commented Sep 16, 2024

nkuoch commented Nov 1, 2024

allgandalf Nov 17, 2024

Choose a reason for hiding this comment

allgandalf Nov 17, 2024

Choose a reason for hiding this comment

DylanDylann Nov 19, 2024

Choose a reason for hiding this comment

DylanDylann Nov 19, 2024

Choose a reason for hiding this comment

DylanDylann Nov 19, 2024

Choose a reason for hiding this comment

narefyev91 commented Sep 3, 2024 •

edited

Loading

narefyev91 commented Sep 4, 2024 •

edited

Loading

allroundexperts commented Sep 8, 2024 •

edited

Loading

narefyev91 commented Sep 11, 2024 •

edited

Loading