Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed icon alignment on ReportComposeAction #4851

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

mananjadhav
Copy link
Collaborator

@mananjadhav mananjadhav commented Aug 26, 2021

@iwiznia Can you please review this for regression in #4499 (comment)

Details

  • Fixed flexEnd alignment issue due to Tooltip.

Fixed Issues

$ #4499

Tests

  1. Tested the Web View ReportActionCompose button alignments with multiline input.

QA Steps

  1. Go to chat
  2. Enter multiline content
  3. Icon buttons should be retained at the bottom.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-08-26 at 3 48 12 PM

Screenshot 2021-08-26 at 4 02 01 PM

Mobile Web

Desktop

Screenshot 2021-08-26 at 3 58 30 PM

iOS

Android

@mananjadhav mananjadhav requested a review from a team as a code owner August 26, 2021 10:31
@MelvinBot MelvinBot requested review from iwiznia and removed request for a team August 26, 2021 10:31
underlayColor={themeColors.componentBG}
disabled={isBlockedFromConcierge || isArchivedChatRoom}
>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove all these extra blank lines? (lines 661,663,667,668)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mananjadhav
Copy link
Collaborator Author

PR Updated

@iwiznia iwiznia merged commit d3f5bd3 into Expensify:main Aug 26, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @iwiznia in version: 1.0.88-3 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants