Fix/48736 fix settings header #48829
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Tagging @Expensify/design for design review. |
|
recheck |
@ChavdaSachin I think we're good in terms of design as that was already determined in the issue. Regarding the CLA check failing, you're all good - that's expected. I'm working on the PR Reviewer Checklist as we speak 👍 |
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
android.webm
Android: mWeb Chrome
android-mweb.webm
iOS: Native
ios.mp4
iOS: mWeb Safari
ios-mweb.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov
ChavdaSachin
changed the title
|
This is mostly looking good, but the top header seems to be too big: I think it should follow the same height as all other page headers which is There also seem to be a padded top instead of the whole page header being padded: Other page header for comparison: cc @Expensify/design for gutcheck here |
|
I agree with those points Jon. It might be more difficult to get the height the same size here since the avatar we're using on settings is 52x52 instead of 40x40. That being said, we could probably just make the top area use a fixed height of 80px and vertically center everything? Or reduce the avatar down to 40x40. Thoughts? |
I like that idea |
|
@dubielzyk-expensify check this screenshot with header height 80px with avatar size 52*52 and removed top padding from page wrapper. 
|
|
I think that feels okay to me. Would love to see a quick video of jumping between Inbox, Search, and then Settings to see how that top part feels as you change pages. |
|
Here's the video you asked for. Screen.Recording.2024-09-10.at.3.41.55.PM.mov |
|
Cool, I do think that feels okay, but again that does make me slightly curious about what a 40x40 avatar would look like in the header for Settings. I know I had pitched that idea to @dannymcclain at one point but I think we decided to just stick with 52x52. |
|
Check this 
Screen.Recording.2024-09-10.at.4.00.03.PM.mov |
|
Dang, it does feel kinda nice that the avatar stays in exactly the same spot across the app pages. Let's see what the rest of the @Expensify/design gang thinks though! |
|
If we decide to go with Avatar size 40*40, we additionally have to modify skeleton view for the same. before changes
after changes
Code changes
<Rect
x={startPositionX + avatarPlaceholderRadius + styles.gap3.gap}
y="11"
width="45%"
height="8"
/>
<Rect
x={startPositionX + avatarPlaceholderRadius + styles.gap3.gap}
y="31"
width="55%"
height="8"
/>
<Rect
x={startPositionX + avatarPlaceholderRadius + styles.gap3.gap}
y="6"
width="45%"
height="8"
/>
<Rect
x={startPositionX + avatarPlaceholderRadius + styles.gap3.gap}
y="26"
width="55%"
height="8"
/>and changed Avatar size passed for skeleton view, tell me what you think about it. |
Yeah I agree, this does actually feel pretty nice. I think I was originally kind of against the 40x40 avatar there, but seeing it in this video looks pretty good. I think it feels a little small next to the type lockup next to it, but I'm definitely down to give it a go! That would once again simplify the amount of avatar sizes we're using in the app, and I agree that switching between tabs feels nice with the avatar always staying in the exact same spot. 🫣 I'm curious what @Expensify/design thinks of these
Basically I'm:
This might be going too far, so just tell me to go away if that's the case 😂. Just trying to create more of a tight little lockup for the avatar/profile info in that top corner. CleanShot.2024-09-10.at.08.27.22.mp4 |
|
Hmm actually... should the name use our h2 styles to match other pages where we use New Kansas to say Inbox, Search, etc?! Otherwise I feel like I like 17px font size as that's our "page header" font size, and this feels like a page header to me. Super down with 40x40 though! |
|
Interesting Shawn! I kinda like that idea, but I do worry we might be straying from the path of this PR a little bit 😅 Here's a little mock showing that idea with the rest of the headers:
|
|
Hmm yeah, I think I like just the good ol' |
|
Yeah totally. Sounds good to me! So to bring us back from my psychotic tangent: All we want to do is update the avatar size to be |
|
So a quick summary of changes
|
|
That sounds right to me. |
…h new header style
|
Changes are committed according to design team inputs. |
|
I will look into this once again to confirm everything works and looks as expected 👍 |
|
I vastly prefer the avatar at |
|
Checked it out locally and it looks great! Thanks for sweating the details with us here @ChavdaSachin 😄 |
|
Pleasure is all mine. |
ideaIn order to keep app layout more consistent I propose to hide scrollbar from remaining 2 LHN pages as well
Screenshots
if @expensify/design think this idea appropriate, feel free to raise an issue and assign me. |
I think we've already gone out of the scope enough with this PR, let's keep it contained for now and revisit if needed. @marcochavezf 🟢 I just double checked the PR after the latest design adjustments and everything works and looks as expected - we're good to merge here from my side! |
Love that you're coming to the table with ideas! 😄 I think for this one, there's quite a few considerations into accessibility as each platform does different things to the scroll bar. MacOS hides them by default, while some browsers override this etc. So I think we'll take this back and have a think, but not implement this for now cause we need to look at the ripple effects here. Again, love the idea and if we do it, we'll reach out 👍 For now let's move on without this |
|
Agree that we can discuss the scrolling issues as a separate issue/follow up. Glad we resolved the avatar size and fixed header area though, LGTM. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.33-4 🚀
|
Details
Fixed Issues
$ #48736
PROPOSAL: #48736 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-09-10.at.1.45.19.AM.mov
Android: mWeb Chrome
Screen.Recording.2024-09-10.at.1.52.21.AM.mov
iOS: Native
Screen.Recording.2024-09-10.at.1.11.13.AM.mov
iOS: mWeb Safari
Screen.Recording.2024-09-10.at.1.13.08.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-09-10.at.12.55.05.AM.mov
MacOS: Desktop
Screen.Recording.2024-09-10.at.12.58.11.AM.mov