Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Improve cache hit rate of setup-node by ignoring E/App version #48860

Merged
merged 2 commits into from
Sep 10, 2024
Merged

[No QA] Improve cache hit rate of setup-node by ignoring E/App version #48860

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba1e6b2
Improve cache hit rate of setup-node by ignoring version
roryabraham Sep 10, 2024
f8b589a
Remove second instance of package version
roryabraham Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/actions/composite/setupNode/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,16 @@ outputs:
runs:
using: composite
steps:
- name: Remove E/App version from package-lock.json
shell: bash
run: jq 'del(.version, .packages[""].version)' package-lock.json > normalized-package-lock.json

- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: npm
cache-dependency-path: |
package-lock.json
normalized-package-lock.json
desktop/package-lock.json

- id: cache-node-modules
Expand Down
Loading