Category settings: Default categories follow-up #49030

BartoszGrajdek · 2024-09-11T22:24:49Z

Details

This PR removes the rendered list and uses SectionList as described in the design doc. We were forced to use the rendered list to avoid problems related to scrolling, but after this refactor we don't need it anymore.

Fixed Issues

$ #47018

Tests

Firstly we need to ensure two things:

Create a fresh workspace
Go to Workspace Settings -> More features -> Organize
Enable Categories setting

Now going into proper testing:

Go to Workspace Settings -> Categories -> Settings (You should see a list of default spend categories)
Click on one of the spend categories
Select a category you want to assign to a given spend category
Ensure canUseWorkspaceRules beta is enabled

Verify that it worked and is shown in spend categories list now.

Offline tests

Same as above

QA Steps

Same as above

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

BartoszGrajdek · 2024-09-11T22:40:17Z

src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

+                        />
+                    )}
+                    {canUseWorkspaceRules && categoryID && groupID && (
+                        <CategorySelectorModal


I moved the modal here to avoid SectionList nesting, which was causing a lot of problems, especially scrolling issues.

BartoszGrajdek · 2024-09-11T22:41:01Z

src/components/SelectionList/BaseSelectionList.tsx

@@ -426,9 +424,6 @@ function BaseSelectionList<TItem extends ListItem>(
        </>
    );

-    // eslint-disable-next-line react/jsx-props-no-spreading
-    const scrollComponent = shouldUseCustomScrollView ? (props: ScrollViewProps) => <ScrollView {...props} /> : undefined;


Removing the workaround I've added previously

melvin-bot · 2024-09-16T19:43:44Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcaaron · 2024-09-16T19:44:42Z

@dukenv0307 please give this a first pass. LMK if you need access to the Design Doc. But I believe the changes here should be straightforward enough.

dukenv0307 · 2024-09-17T04:08:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-17.at.11.04.49.mov

Android: mWeb Chrome

Screen.Recording.2024-09-17.at.11.02.25.mov

iOS: Native

Screen.Recording.2024-09-17.at.11.03.38.mov

iOS: mWeb Safari

Screen.Recording.2024-09-17.at.11.01.19.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-17.at.10.58.57.mov

MacOS: Desktop

Screen.Recording.2024-09-17.at.11.07.48.mov

dukenv0307 · 2024-09-17T04:08:34Z

LGTM and tests well

OSBotify · 2024-09-18T03:10:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-18T22:53:25Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-19T23:34:27Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.38-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

feat: use section list in WorkspaceCategoriesSettingsPage

6c9fcdd

BartoszGrajdek commented Sep 11, 2024

View reviewed changes

marcaaron marked this pull request as ready for review September 16, 2024 19:43

marcaaron requested a review from a team as a code owner September 16, 2024 19:43

melvin-bot bot requested review from dukenv0307 and removed request for a team September 16, 2024 19:43

marcaaron assigned BartoszGrajdek Sep 16, 2024

marcaaron self-requested a review September 16, 2024 20:17

dukenv0307 approved these changes Sep 17, 2024

View reviewed changes

marcaaron approved these changes Sep 18, 2024

View reviewed changes

marcaaron merged commit 74eb6b1 into Expensify:main Sep 18, 2024
17 of 18 checks passed

github-actions bot mentioned this pull request Sep 18, 2024

Deploy Checklist: New Expensify 2024-09-18 #49427

Closed

43 tasks

rayane-djouah mentioned this pull request Sep 23, 2024

[HOLD for payment 2024-10-25] [$250] Android & iOS - Spend category - Unable to select category when keyboard is up #48928

Closed

6 tasks

dukenv0307 mentioned this pull request Nov 1, 2024

[$250] [OldDot Rules Migration] Category settings: Default categories #47018

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Category settings: Default categories follow-up #49030

Category settings: Default categories follow-up #49030

BartoszGrajdek commented Sep 11, 2024 •

edited

Loading

BartoszGrajdek Sep 11, 2024

BartoszGrajdek Sep 11, 2024

melvin-bot bot commented Sep 16, 2024

marcaaron commented Sep 16, 2024

dukenv0307 commented Sep 17, 2024

dukenv0307 commented Sep 17, 2024

OSBotify commented Sep 18, 2024

OSBotify commented Sep 18, 2024

OSBotify commented Sep 19, 2024

Category settings: Default categories follow-up #49030

Category settings: Default categories follow-up #49030

Conversation

BartoszGrajdek commented Sep 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

BartoszGrajdek Sep 11, 2024

Choose a reason for hiding this comment

BartoszGrajdek Sep 11, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Sep 16, 2024

marcaaron commented Sep 16, 2024

dukenv0307 commented Sep 17, 2024

Reviewer Checklist

Screenshots/Videos

dukenv0307 commented Sep 17, 2024

OSBotify commented Sep 18, 2024

OSBotify commented Sep 18, 2024

OSBotify commented Sep 19, 2024

BartoszGrajdek commented Sep 11, 2024 •

edited

Loading