[CP Staging] fix: preserve scroll position and fixed the Saved title #49244

dominictb · 2024-09-16T07:22:37Z

Details

This PR will preserve the scroll position and fixed the Saved title on large screen devices saved filter sections.

Fixed Issues

$ #49218
PROPOSAL: #49218 (comment)

Tests

1. Large screen device:

Precondition:

There is a long list of saved search until the saved search list is scrollable.

Go to app.
Go to Search.
Scroll the saved search list to the bottom.
Verify that the "Saved" title should remain on top when the list is scrolled down.
Select a search from the bottom of the list.
Verify that the list will not scroll up after selecting the search at the bottom of the list.

2. Small screen device:

Precondition:

There is a long list of saved search until the saved search list is scrollable.

Go to app.
Go to Search.
Tap on the Filter dropdown, the Filter modal will be opened.
Scroll the saved search list to the bottom.
Verify that the "Saved" title works as it is before because this change just applies to large devices.
Select a search from the bottom of the list.
Verify the Filter modal is closed properly.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-16.at.17.28.20.mov

Android: mWeb Chrome

Screen.Recording.2024-09-16.at.15.31.51.mov

iOS: Native

Screen.Recording.2024-09-16.at.15.16.10.mov

iOS: mWeb Safari

Screen.Recording.2024-09-16.at.15.20.35.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-16.at.14.20.23.mov

MacOS: Desktop

Screen.Recording.2024-09-16.at.15.13.34.mov

dominictb · 2024-09-16T08:50:52Z

I just encountered an error with android native, but it I think the PR can be reviewed now while I am trying to resolve that problem.

melvin-bot · 2024-09-16T09:45:28Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2024-09-16T10:29:01Z

Added Android video.

dominictb · 2024-09-16T10:43:12Z

src/pages/Search/SearchTypeMenu.tsx

@@ -178,7 +203,7 @@ function SearchTypeMenu({queryJSON}: SearchTypeMenuProps) {
                />
            </View>
        ),
-        [styles, translate],
+        [styles],


This change is to fix the lint issue which is not related to this PR.

rushatgabhane · 2024-09-16T11:52:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-16.at.15.10.43.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-09-16.at.15.06.42.mov

iOS: mWeb Safari

Screen.Recording.2024-09-16.at.15.12.43.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-16.at.15.07.06.mov

Screen.Recording.2024-09-16.at.15.11.45.mov

MacOS: Desktop

Screen.Recording.2024-09-16.at.15.18.26.mov

[CP Staging] fix: preserve scroll position and fixed the Saved title (cherry picked from commit 6147770) (CP triggered by mountiny)

OSBotify · 2024-09-16T12:31:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-16T13:07:07Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.35-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-09-16T18:22:48Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.35-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dominictb added 2 commits September 16, 2024 14:21

fix: preserve scroll position and fixed the Saved title

3f54571

fix lint

8aa15ad

fix: add comment eslint-disable-next-line no-restricted-imports

9b42638

dominictb marked this pull request as ready for review September 16, 2024 09:45

dominictb requested a review from a team as a code owner September 16, 2024 09:45

melvin-bot bot requested review from ntdiary and removed request for a team September 16, 2024 09:45

fix: lint

a0c8b55

dominictb commented Sep 16, 2024

View reviewed changes

dominictb mentioned this pull request Sep 16, 2024

[HOLD for payment 2024-09-23] [Search v2.3] - List scrolls back to the top after selecting saved search at the bottom of list #49218

Closed

6 tasks

lakchote requested review from rushatgabhane and removed request for ntdiary September 16, 2024 11:51

rushatgabhane approved these changes Sep 16, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins September 16, 2024 12:13

lakchote changed the title ~~fix: preserve scroll position and fixed the Saved title~~ [CP Staging] fix: preserve scroll position and fixed the Saved title Sep 16, 2024

lakchote approved these changes Sep 16, 2024

View reviewed changes

lakchote merged commit 6147770 into Expensify:main Sep 16, 2024
17 of 18 checks passed

OSBotify pushed a commit that referenced this pull request Sep 16, 2024

Merge pull request #49244 from dominictb/fix/49218

986d073

[CP Staging] fix: preserve scroll position and fixed the Saved title (cherry picked from commit 6147770) (CP triggered by mountiny)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Sep 16, 2024

github-actions bot mentioned this pull request Sep 16, 2024

Deploy Checklist: New Expensify 2024-09-13 #49195

Closed

55 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] fix: preserve scroll position and fixed the Saved title #49244

[CP Staging] fix: preserve scroll position and fixed the Saved title #49244

dominictb commented Sep 16, 2024 •

edited

Loading

dominictb commented Sep 16, 2024

melvin-bot bot commented Sep 16, 2024

dominictb commented Sep 16, 2024

dominictb Sep 16, 2024

rushatgabhane commented Sep 16, 2024 •

edited

Loading

OSBotify commented Sep 16, 2024

OSBotify commented Sep 16, 2024

OSBotify commented Sep 16, 2024

[CP Staging] fix: preserve scroll position and fixed the Saved title #49244

[CP Staging] fix: preserve scroll position and fixed the Saved title #49244

Conversation

dominictb commented Sep 16, 2024 • edited Loading

Details

Fixed Issues

Tests

1. Large screen device:

Precondition:

2. Small screen device:

Precondition:

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

dominictb commented Sep 16, 2024

melvin-bot bot commented Sep 16, 2024

dominictb commented Sep 16, 2024

dominictb Sep 16, 2024

Choose a reason for hiding this comment

rushatgabhane commented Sep 16, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Sep 16, 2024

OSBotify commented Sep 16, 2024

OSBotify commented Sep 16, 2024

dominictb commented Sep 16, 2024 •

edited

Loading

rushatgabhane commented Sep 16, 2024 •

edited

Loading