-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] fix: app crash when we save the user search value and reset the app #49258
Conversation
@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-09-16.at.18.34.21.movAndroid: mWeb ChromeScreen.Recording.2024-09-16.at.18.35.55.moviOS: NativeScreen.Recording.2024-09-16.at.18.32.44.moviOS: mWeb SafariScreen.Recording.2024-09-16.at.18.31.48.movMacOS: Chrome / SafariScreen.Recording.2024-09-16.at.18.30.32.movMacOS: DesktopScreen.Recording.2024-09-16.at.18.31.00.mov |
Merging it @techievivek as this is a minor change, the bug has been properly tested by a C+, and it fixes a blocker. |
fix: app crash when we save the user search value and reset the app (cherry picked from commit 230cbd6) (CP triggered by mountiny)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Tested on staging the app doesn't crash anymore. Screen.Recording.2024-09-16.at.14.24.56.mov |
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.35-7 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Hi team! Can you check this GH to see if it's a regression @DylanDylann @techievivek @lakchote |
🚀 Deployed to production by https://github.com/grgia in version: 9.0.35-7 🚀
|
It doesn't look like a regression if we're basing ourselves on what was reported by a C+ here |
Details
Fixed Issues
$ #49249
PROPOSAL: #49249 (comment)
Tests
From
field and save the searchOffline tests
None
QA Steps
From
field and save the searchPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-09-16.at.18.14.20.mov
Android: mWeb Chrome
Screen.Recording.2024-09-16.at.18.12.12.mov
iOS: Native
Screen.Recording.2024-09-16.at.18.15.38.mov
iOS: mWeb Safari
Screen.Recording.2024-09-16.at.18.10.28.mov
MacOS: Chrome / Safari
Screen.Recording.2024-09-16.at.17.52.34.mov
MacOS: Desktop
Screen.Recording.2024-09-16.at.18.17.02.mov