Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Use fromJSON in platformDeploy.yml #4940

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Conversation

roryabraham
Copy link
Contributor

Details

Fixes broken platform deploys: https://github.com/Expensify/App/runs/3467734542?check_suite_focus=true

Tests

  1. Merge this PR
  2. Unlock and relock deploy checklist.
  3. Verify that the staging deploy works.

QA Steps

None.

@roryabraham roryabraham requested a review from Jag96 August 31, 2021 01:58
@roryabraham roryabraham self-assigned this Aug 31, 2021
@roryabraham roryabraham requested a review from a team as a code owner August 31, 2021 01:58
@MelvinBot MelvinBot requested review from cead22 and removed request for a team August 31, 2021 01:59
@roryabraham
Copy link
Contributor Author

Reviewer note: this is very similar to this PR

@roryabraham roryabraham merged commit 1bcd00e into main Aug 31, 2021
@roryabraham roryabraham deleted the Rory-FixPlatformDeploy branch August 31, 2021 04:49
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.0.90-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants