[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat #49412

ishpaul777 · 2024-09-18T19:18:59Z

Details

Fixed Issues

$ #49344
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

Test 1

Create a workspace on ND. Go to workspace chat and copy report id in URL.
Open Dev tools and delete report Data from onyx db report_<reportid>.
Open any other report. and Reload the app.
Click on FAB, -> Submit Expense -> Add any amount
Verify you are able to see the deleted workspace chat option
Click on workspace chat option submit expense, verify the expensse is submitted.

Test 2

Create a Control workspace on OD. Sign in on ND with same account.
Click on FAB, -> Submit Expense -> Add any amount
Verify you are able to see the deleted workspace chat option
Click on workspace chat option submit expense, verify the expensse is submitted.

PR Author Checklist

Screenshots/Videos

Android: Native

Record_2024-10-18-03-41-41.mp4

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-10-18.at.3.19.32.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-18.at.2.52.34.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-18.at.2.12.46.AM.mov

Screen.Recording.2024-10-18.at.2.34.01.AM.mov

MacOS: Desktop

Screen.Recording.2024-10-18.at.3.55.50.AM.mov

ishpaul777 · 2024-09-27T10:09:44Z

not overdue

src/libs/OptionsListUtils.ts

puneetlath · 2024-10-14T17:20:02Z

We need to update the RequestMoney API command to pass the policyID. That way if we're using an optimistic policyExpenseChat, we know which policy to create the chat on.

Co-authored-by: Puneet Lath <puneet@expensify.com>

melvin-bot · 2024-10-17T13:07:36Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-10-17T13:09:48Z

@eVoloshchak This is ready for review code wise, but BE is not deployed yet. I'll write test steps. but for now it can be tested only offline for now

ishpaul777 · 2024-10-17T21:24:20Z

FYI BE PR is deployed on staging

puneetlath · 2024-10-17T21:24:39Z

For test 2 it needs to be a Control workspace. Collect workspaces created on OldDot are workspace chat enabled.

ishpaul777 · 2024-10-17T21:25:29Z

Updated!

allroundexperts · 2024-10-17T21:27:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Unable to test on Android native because Flipper doesn't allow me to run herms debugger on my android device.

Android: mWeb Chrome

Screen.Recording.2024-10-21.at.3.46.00.AM.mov

iOS: Native

Screen.Recording.2024-10-21.at.3.41.15.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-21.at.3.35.27.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-21.at.3.25.49.AM.mov

MacOS: Desktop

Screen.Recording.2024-10-21.at.3.31.39.AM.mov

allroundexperts · 2024-10-17T23:07:55Z

BUG

The onboarding model re-appears after refreshing the page.

Screen.Recording.2024-10-18.at.3.54.13.AM.mov

allroundexperts · 2024-10-17T23:08:41Z

BUG

The created expense report switches its position in the LHN thrice.

Screen.Recording.2024-10-18.at.3.55.07.AM.mov

ishpaul777 · 2024-10-18T14:38:37Z

The onboarding model re-appears after refreshing the page. #49412 (comment)

I am not able to reproduce, is this happening consistently?

allroundexperts · 2024-10-18T14:44:28Z

@ishpaul777 I was able to consistently reproduce it with new accounts. Maybe merge main and try?

ishpaul777 · 2024-10-18T15:02:45Z

Still cant reproduce

Screen.Recording.2024-10-18.at.8.29.22.PM.mov

@allroundexperts Have you checked if this is still repro on main?

allroundexperts · 2024-10-20T22:57:46Z

On Android mwb, Not found page is shown for a small instant of time. I think this is related to the this bug that I pointed out earlier.

Screen.Recording.2024-10-21.at.3.46.00.AM.mov

allroundexperts · 2024-10-20T22:58:14Z

Upon clearing my onyx data, I was not able to reproduce #49412 (comment) as well.

allroundexperts

One potential bug report, but I think its related to another bug that we'll be handling from the backend. As such, I am approving it.

OSBotify · 2024-10-21T15:12:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-22T04:47:39Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mjasikowski · 2024-10-22T11:43:27Z

New feature, so not reverting

dangrous · 2024-10-22T15:05:10Z

hi! I'm VERY not confident about this - but is there a chance that this caused #51256 ? I am having trouble reproducing it consistently on my local (it occurred once, and never again) but it does happen on the actual staging site. This PR looks like it modified tags in a way that MIGHT have caused it?

flodnv · 2024-10-22T15:48:14Z

THis PR caused this DeployBlocker: #51249

flodnv · 2024-10-22T15:49:36Z

I'm proposing we revert the PR: https://expensify.slack.com/archives/C01GTK53T8Q/p1729612151981119

blimpich · 2024-10-22T19:30:21Z

Decided to revert this PR to fix this deploy blocker: #51286

github-actions · 2024-10-23T16:25:06Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

adds v1 changes

ddc6d7a

ishpaul777 changed the title ~~adds v1 changes~~ [Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat Sep 18, 2024

ishpaul777 added 3 commits September 19, 2024 01:15

lint fix

db274ef

remove undesired changes

2c3224b

remove option from other lists

eee6250

puneetlath reviewed Oct 14, 2024

View reviewed changes

src/libs/OptionsListUtils.ts Outdated Show resolved Hide resolved

ishpaul777 and others added 5 commits October 14, 2024 23:13

Merge branch 'Expensify:main' into feat/49344

6379a1a

Update src/libs/OptionsListUtils.ts

6d09fcc

Co-authored-by: Puneet Lath <puneet@expensify.com>

add policy id request params

c68ffae

Merge branch 'Expensify:main' into feat/49344

ed67ace

fix tests

7fc0571

ishpaul777 mentioned this pull request Oct 16, 2024

[Workspace Chats for All] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat #49344

Open

ishpaul777 marked this pull request as ready for review October 17, 2024 13:07

ishpaul777 requested a review from a team as a code owner October 17, 2024 13:07

melvin-bot bot requested review from eVoloshchak and removed request for a team October 17, 2024 13:07

ishpaul777 and others added 5 commits October 17, 2024 23:23

Merge branch 'Expensify:main' into feat/49344

901c303

fixes real/draft policy issue

3a1a151

Merge branch 'main' into feat/49344

fb27256

formatting and typo fix

c42adc3

delete actions of report if there is preexisting report

4b84b28

Merge branch 'main' into feat/49344

f37bd23

allroundexperts approved these changes Oct 20, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath October 20, 2024 22:59

puneetlath approved these changes Oct 21, 2024

View reviewed changes

puneetlath merged commit 36a8b13 into Expensify:main Oct 21, 2024
18 of 22 checks passed

github-actions bot mentioned this pull request Oct 22, 2024

Deploy Checklist: New Expensify 2024-10-22 #51219

Closed

74 tasks

IuliiaHerets mentioned this pull request Oct 22, 2024

Expense - Category list loads infinitely when submitting to non-existing workspace chat #51238

Closed

8 tasks

mjasikowski mentioned this pull request Oct 22, 2024

Revert "[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat" #51241

Closed

dangrous mentioned this pull request Oct 22, 2024

Tags - State field is not auto populated #51256

Closed

8 tasks

flodnv mentioned this pull request Oct 22, 2024

[$250] Expense - Expense amount is not added but substracted when submitting from the expense report #51249

Closed

8 tasks

IuliiaHerets mentioned this pull request Oct 22, 2024

Search - Expenses created on a control WS are not showing up on Search page #51270

Closed

8 tasks

blimpich mentioned this pull request Oct 22, 2024

Expense - Error when submitting distance expense to non-existing workspace chat #51286

Closed

8 tasks

ishpaul777 mentioned this pull request Oct 22, 2024

[CP Staging] Revert "[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat" #51289

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat #49412

[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat #49412

ishpaul777 commented Sep 18, 2024 •

edited

Loading

ishpaul777 commented Sep 27, 2024

puneetlath commented Oct 14, 2024

melvin-bot bot commented Oct 17, 2024

ishpaul777 commented Oct 17, 2024

ishpaul777 commented Oct 17, 2024

puneetlath commented Oct 17, 2024

ishpaul777 commented Oct 17, 2024

allroundexperts commented Oct 17, 2024 •

edited

Loading

allroundexperts commented Oct 17, 2024

allroundexperts commented Oct 17, 2024

ishpaul777 commented Oct 18, 2024

allroundexperts commented Oct 18, 2024

ishpaul777 commented Oct 18, 2024 •

edited

Loading

allroundexperts commented Oct 20, 2024

allroundexperts commented Oct 20, 2024

allroundexperts left a comment

OSBotify commented Oct 21, 2024

github-actions bot commented Oct 22, 2024

mjasikowski commented Oct 22, 2024 •

edited

Loading

dangrous commented Oct 22, 2024

flodnv commented Oct 22, 2024

flodnv commented Oct 22, 2024

blimpich commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat #49412

[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat #49412

Conversation

ishpaul777 commented Sep 18, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

ishpaul777 commented Sep 27, 2024

puneetlath commented Oct 14, 2024

melvin-bot bot commented Oct 17, 2024

ishpaul777 commented Oct 17, 2024

ishpaul777 commented Oct 17, 2024

puneetlath commented Oct 17, 2024

ishpaul777 commented Oct 17, 2024

allroundexperts commented Oct 17, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Oct 17, 2024

BUG

allroundexperts commented Oct 17, 2024

BUG

ishpaul777 commented Oct 18, 2024

allroundexperts commented Oct 18, 2024

ishpaul777 commented Oct 18, 2024 • edited Loading

allroundexperts commented Oct 20, 2024

allroundexperts commented Oct 20, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 21, 2024

github-actions bot commented Oct 22, 2024

mjasikowski commented Oct 22, 2024 • edited Loading

dangrous commented Oct 22, 2024

flodnv commented Oct 22, 2024

flodnv commented Oct 22, 2024

blimpich commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

ishpaul777 commented Sep 18, 2024 •

edited

Loading

allroundexperts commented Oct 17, 2024 •

edited

Loading

ishpaul777 commented Oct 18, 2024 •

edited

Loading

mjasikowski commented Oct 22, 2024 •

edited

Loading