fix: search header flickering on selection mode #49510

daledah · 2024-09-20T04:47:04Z

Details

Fixed Issues

$ #49084
PROPOSAL: #49084 (comment)

Tests

Open search page
Turn on selection mode by selecting 1 or 2 expenses
Open another tab and reopen search page
Verify that: The header is not flickering.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open search page
Turn on selection mode by selecting 1 or 2 expenses
Open another tab and reopen search page
Verify that: The header is not flickering.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-20.at.11.42.04.mov

Android: mWeb Chrome

Screen.Recording.2024-09-20.at.11.44.07.mov

iOS: Native

Screen.Recording.2024-09-20.at.11.29.17.mov

iOS: mWeb Safari

Screen.Recording.2024-09-20.at.11.35.15.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-20.at.11.19.22.mov

MacOS: Desktop

Screen.Recording.2024-09-20.at.11.58.55.mov

melvin-bot · 2024-09-20T09:26:53Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2024-09-20T11:24:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-09-26_11.32.31.mp4

Android: mWeb Chrome

android-chrome-2024-09-20_13.39.36.mp4

iOS: Native

ios-native-2024-09-20_13.43.35.mp4

iOS: mWeb Safari

ios-safari-2024-09-20_13.45.34.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-09-20_13.26.15.mp4

MacOS: Desktop

desktop-app-2024-09-20_13.31.31.mp4

daledah · 2024-09-23T14:50:31Z

@jjcoffee I updated, please test again. Thanks!

daledah · 2024-09-25T06:54:47Z

@jjcoffee Just to confirm, when selection mode is enabled and no item is selected, we should turn off selection mode when navigating to another route, and only keep selection mode on if there's at least one item selected, correct?

jjcoffee · 2024-09-25T08:25:35Z

@daledah That's correct as that's the behaviour on current main/staging.

daledah · 2024-09-26T09:13:04Z

@jjcoffee I updated

Screen.Recording.2024-09-26.at.15.56.38.mov

jjcoffee

LGTM!

src/components/SelectionListWithModal/index.tsx

daledah · 2024-10-03T09:34:17Z

@aldo-expensify I updated, please review again, thanks!

aldo-expensify

Thanks, this looks better. I left a suggestion there to avoid casting.

src/components/Search/index.tsx

daledah · 2024-10-07T11:14:17Z

@aldo-expensify I updated.

The merge-base changed after approval.

aldo-expensify · 2024-10-09T01:06:37Z

There seems to be a bug not allowing me to approve:

https://github.com/orgs/community/discussions/58535?sort=top

aldo-expensify

Testing..

The merge-base changed after approval.

aldo-expensify · 2024-10-09T01:12:51Z

Closing and reopening the PR fixed it :)

OSBotify · 2024-10-09T01:22:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-09T20:46:56Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.47-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-10T23:02:07Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.47-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

daledah · 2024-10-17T06:51:21Z

src/components/SelectionListWithModal/index.tsx

        if (selectedItems.length > 0 && !selectionMode?.isEnabled) {
            turnOnMobileSelectionMode();
+        } else if (selectedItems.length === 0 && selectionMode?.isEnabled && !wasSelectionOnRef.current) {
+            turnOffMobileSelectionMode();


In the case when There are actively two SelectionListWithModal on the screen, we didn't have the logic to limit the changes to only the focused list.

In the case of #50555, there are two Lists on the screens: a parent Tag list and a child Tag list. When we select a child tag, turnOnMobileSelectionMode is called as expected, but the parent Tag list has no selected item, which makes turnOffMobileSelectionMode called at the same time, result in selection mode not enabled.

fix: search header flickering on selection mode

3079296

daledah marked this pull request as ready for review September 20, 2024 09:26

daledah requested a review from a team as a code owner September 20, 2024 09:26

melvin-bot bot requested review from jjcoffee and removed request for a team September 20, 2024 09:26

daledah mentioned this pull request Sep 20, 2024

[HOLD for payment 2024-10-17] [$250] Header flickers on the search page when switching tabs while reports are already selected. #49084

Closed

6 tasks

This comment was marked as resolved.

Sign in to view

fix: transactions selection flickering

3830db3

This comment was marked as resolved.

Sign in to view

fix: flickering after deselect items and navigate

2cc1288

jjcoffee approved these changes Sep 26, 2024

View reviewed changes

melvin-bot bot requested a review from aldo-expensify September 26, 2024 09:33

daledah added 2 commits October 1, 2024 10:20

Merge branch 'main' into fix/49084

734ad73

fix: resolve conflict

c7ae781

aldo-expensify requested changes Oct 2, 2024

View reviewed changes

src/components/SelectionListWithModal/index.tsx Outdated Show resolved Hide resolved

src/components/SelectionListWithModal/index.tsx Outdated Show resolved Hide resolved

fix: update logic to preven castings

f687155

aldo-expensify requested changes Oct 5, 2024

View reviewed changes

src/components/Search/index.tsx Outdated Show resolved Hide resolved

fix: avoid typecastings

9e80633

aldo-expensify previously approved these changes Oct 9, 2024

View reviewed changes

aldo-expensify requested changes Oct 9, 2024

View reviewed changes

aldo-expensify previously approved these changes Oct 9, 2024

View reviewed changes

aldo-expensify closed this Oct 9, 2024

aldo-expensify reopened this Oct 9, 2024

aldo-expensify approved these changes Oct 9, 2024

View reviewed changes

aldo-expensify merged commit 6556e9a into Expensify:main Oct 9, 2024
26 checks passed

This was referenced Oct 9, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Build apk from delta ref / Build Android app #50486

Closed

Deploy Checklist: New Expensify 2024-10-09 #50518

Closed

This was referenced Oct 10, 2024

[HOLD for payment 2024-10-24] Tags - Long pressing North+east not showing settings option #50555

Closed

[CP Staging] Revert "fix: search header flickering on selection mode" #50575

Merged

daledah commented Oct 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: search header flickering on selection mode #49510

fix: search header flickering on selection mode #49510

daledah commented Sep 20, 2024 •

edited

Loading

melvin-bot bot commented Sep 20, 2024

jjcoffee commented Sep 20, 2024 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

daledah commented Sep 23, 2024

This comment was marked as resolved.

daledah commented Sep 25, 2024

jjcoffee commented Sep 25, 2024

daledah commented Sep 26, 2024

jjcoffee left a comment

daledah commented Oct 3, 2024

aldo-expensify left a comment

daledah commented Oct 7, 2024

aldo-expensify commented Oct 9, 2024 •

edited

Loading

aldo-expensify left a comment

aldo-expensify commented Oct 9, 2024

OSBotify commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 10, 2024

daledah Oct 17, 2024

fix: search header flickering on selection mode #49510

fix: search header flickering on selection mode #49510

Conversation

daledah commented Sep 20, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 20, 2024

jjcoffee commented Sep 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

This comment was marked as resolved.

This comment was marked as resolved.

daledah commented Sep 23, 2024

This comment was marked as resolved.

daledah commented Sep 25, 2024

jjcoffee commented Sep 25, 2024

daledah commented Sep 26, 2024

jjcoffee left a comment

Choose a reason for hiding this comment

daledah commented Oct 3, 2024

aldo-expensify left a comment

Choose a reason for hiding this comment

daledah commented Oct 7, 2024

aldo-expensify commented Oct 9, 2024 • edited Loading

aldo-expensify left a comment

Choose a reason for hiding this comment

aldo-expensify commented Oct 9, 2024

OSBotify commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 10, 2024

daledah Oct 17, 2024

Choose a reason for hiding this comment

daledah commented Sep 20, 2024 •

edited

Loading

jjcoffee commented Sep 20, 2024 •

edited

Loading

aldo-expensify commented Oct 9, 2024 •

edited

Loading