fix: [Search v2.3] - Default name is not displayed correctly for multiline system message thread. #49518

Krishna2323 · 2024-09-20T09:28:59Z

Details

Fixed Issues

$ #49330
PROPOSAL: #49330 (comment)

Tests

Go to DM.
Submit an expense with a multiline description.
Go to transaction thread.
Click Description.
Edit the description while maintaining the multiline format and save it.
Right click on the system message > Reply in thread.
Send a reply in thread.
Go to Search > Chats.
Click Filters > Select "In".
Select the thread in Step 8 > Save.
Click Save search.
Verify the title of the saved search is only shown in one line.

Verify that no errors appear in the JS console

Offline tests

Go to DM.
Submit an expense with a multiline description.
Go to transaction thread.
Click Description.
Edit the description while maintaining the multiline format and save it.
Right click on the system message > Reply in thread.
Send a reply in thread.
Go to Search > Chats.
Click Filters > Select "In".
Select the thread in Step 8 > Save.
Click Save search.
Verify the title of the saved search is only shown in one line.

QA Steps

Go to DM.
Submit an expense with a multiline description.
Go to transaction thread.
Click Description.
Edit the description while maintaining the multiline format and save it.
Right click on the system message > Reply in thread.
Send a reply in thread.
Go to Search > Chats.
Click Filters > Select "In".
Select the thread in Step 8 > Save.
Click Save search.
Verify the title of the saved search is only shown in one line.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…iline system message thread. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2024-09-20T09:29:04Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

paultsimura · 2024-09-20T10:46:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

2024-09-20.-.18.41.-.Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-20.at.12.33.34.mp4

iOS: mWeb Safari

2024-09-20.-.18.41.-.Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-20.at.12.32.38.mp4

MacOS: Chrome / Safari

MacOS: Desktop

paultsimura · 2024-09-20T10:47:56Z

@shawnborton what is your take on this report name when clicking the "In" tab?
Current prod behavior differs for web & native:

Web, the full report name is shown:

2024-09-20.-.12.45.-.Screen.Recording.2024-09-20.at.12.45.27.mp4

iOS native, the name is truncated to take 1 line:

shawnborton · 2024-09-20T12:46:13Z

The iOS version is correct - this should only be 1 line.

paultsimura · 2024-09-20T12:54:30Z

Thanks.
@Krishna2323 please fix it as well – it's tightly related to the original issue.

Krishna2323 · 2024-09-20T13:33:10Z

please fix it as well – it's tightly related to the original issue.

@paultsimura, I will check that in a few hours or tomorrow, though I believe it is not directly related to the original issue, as the issue seems to be in the SearchFiltersChatsSelector component.

paultsimura · 2024-09-20T19:21:24Z

@Krishna2323 I've dug deeper into this issue. Seems like the topmost root cause is how we build the report name for reports descending from a MODIFIEDEXPENSE action.

My suggestion is to update these lines similar to how we use formatReportLastMessageText for other report types:

App/src/libs/ReportUtils.ts

Lines 3766 to 3768 in 6bef045

    
           if (!isEmptyObject(parentReportAction) && ReportActionsUtils.isModifiedExpenseAction(parentReportAction)) { 
        
               return ModifiedExpenseMessage.getForReportAction(report?.reportID, parentReportAction); 
        
           }

if (!isEmptyObject(parentReportAction) && ReportActionsUtils.isModifiedExpenseAction(parentReportAction)) {
    const formattedName = ModifiedExpenseMessage.getForReportAction(report?.reportID, parentReportAction);
    return formatReportLastMessageText(formattedName);
}

This solves all of our known issues with the multiline report name.
After that, we should probably revert the pre -> noWrap style change to be safe from potential regressions.

Krishna2323 · 2024-09-23T09:40:36Z

will work on this today.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-09-23T19:07:50Z

@paultsimura, thanks a lot for looking into it🙏🏻, I have made the changes and it works great. I'm updating the videos.

Krishna2323 · 2024-09-23T20:07:17Z

@paultsimura all done.

paultsimura · 2024-09-24T07:21:34Z

One final check with @shawnborton now that we've fixed the multiline report name.
The search header should still be only 1 line or two as it's in prod?

Attaching a screenshot of a complex query:

luacmartins · 2024-09-24T13:07:33Z

@shawnborton is ooo, so I'm tagging @Expensify/design for another look. FWIW we're about to merge this PR that replaces the custom query header, so I wouldn't spend too much time fixing edge cases for it.

dannymcclain · 2024-09-24T13:17:28Z

The search header should still be only 1 line or two as it's in prod?

I kinda think it should just be one—two lines isn't the worst thing in the universe, but one line just looks better and is much less distracting.

Otherwise I feel like this is looking pretty good.

paultsimura · 2024-09-24T15:07:34Z

Ok, thanks y'all 👍

paultsimura

LGTM ✔️

github-actions · 2024-09-27T17:59:26Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.41-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-09-30T22:41:16Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.41-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: [Search v2.3] - Default name is not displayed correctly for mult…

d62a4b0

…iline system message thread. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner September 20, 2024 09:29

melvin-bot bot requested a review from paultsimura September 20, 2024 09:29

melvin-bot bot removed the request for review from a team September 20, 2024 09:29

Krishna2323 added 2 commits September 23, 2024 20:07

Merge branch 'Expensify:main' into krishna2323/issue/49330

e3dbe77

use formatReportLastMessageText to retun report action message.

f577c7d

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

luacmartins self-requested a review September 23, 2024 23:52

paultsimura approved these changes Sep 24, 2024

View reviewed changes

luacmartins approved these changes Sep 24, 2024

View reviewed changes

luacmartins merged commit 9d051a7 into Expensify:main Sep 24, 2024
18 of 19 checks passed

This was referenced Sep 24, 2024

Investigate workflow job failing on main: test / test (job 2) #49669

Closed

Investigate workflow job failing on main: confirmPassingBuild #49670

Closed

Deploy Checklist: New Expensify 2024-09-27 #49855

Closed

This was referenced Oct 1, 2024

[HOLD for Payment OCT 08] [$250] [Search v2.3] - Default name is not displayed correctly for multiline system message thread #49330

Closed

Fix/37448: Incorrect title thread #38267

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: [Search v2.3] - Default name is not displayed correctly for multiline system message thread. #49518

fix: [Search v2.3] - Default name is not displayed correctly for multiline system message thread. #49518

Krishna2323 commented Sep 20, 2024 •

edited

Loading

melvin-bot bot commented Sep 20, 2024

paultsimura commented Sep 20, 2024 •

edited

Loading

paultsimura commented Sep 20, 2024

shawnborton commented Sep 20, 2024

paultsimura commented Sep 20, 2024

Krishna2323 commented Sep 20, 2024

paultsimura commented Sep 20, 2024

Krishna2323 commented Sep 23, 2024

Krishna2323 commented Sep 23, 2024

Krishna2323 commented Sep 23, 2024

paultsimura commented Sep 24, 2024

luacmartins commented Sep 24, 2024

dannymcclain commented Sep 24, 2024

paultsimura commented Sep 24, 2024

paultsimura left a comment

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

fix: [Search v2.3] - Default name is not displayed correctly for multiline system message thread. #49518

fix: [Search v2.3] - Default name is not displayed correctly for multiline system message thread. #49518

Conversation

Krishna2323 commented Sep 20, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 20, 2024

paultsimura commented Sep 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

paultsimura commented Sep 20, 2024

shawnborton commented Sep 20, 2024

paultsimura commented Sep 20, 2024

Krishna2323 commented Sep 20, 2024

paultsimura commented Sep 20, 2024

Krishna2323 commented Sep 23, 2024

Krishna2323 commented Sep 23, 2024

Krishna2323 commented Sep 23, 2024

paultsimura commented Sep 24, 2024

luacmartins commented Sep 24, 2024

dannymcclain commented Sep 24, 2024

paultsimura commented Sep 24, 2024

paultsimura left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

Krishna2323 commented Sep 20, 2024 •

edited

Loading

paultsimura commented Sep 20, 2024 •

edited

Loading