Show expense report in LHN if user doesn't have access to parent policyChat (removed manager condition) #49557

Beamanator · 2024-09-20T20:45:48Z

Details

This is a follow-up to #48661, where I'm realizing we don't even care if the user is the report manager -> If the user doesn't have access to the expense report's parent report, we want to show this report in the LHN so the user always has access somehow

Fixed Issues

$ #49318
$ https://github.com/Expensify/Expensify/issues/422963

Tests

Create a Control policy in OldDot, make sure it has policy expense chats enabled, make sure it has "Advanced Approvals" enabled in members tab
- To enable policy expense chats, enter this into the console on the policy screen in OldDot: p = Policy.getCurrent(); p.policy.isPolicyExpenseChatEnabled = "true"; p.save();
Either In OldDot or NewDot, invite 3 people as users (non-admins): A submitter and 2 approvers
In members tab in OldDot, make sure the submitter's submitsTo is set to Approver 1. Approver 1 and Approver 2 should NOT have a forwardsTo set.
- Note: You can also do this flow in NewDot if preferred
As the submitter, log in to NewDot & go to the workspace chat that was just created for you
- Submit an expense and submit the report to Approver 1
- Keep this tab open! Keep track of the reportID so you have it for later.
In a new tab / device, as the policy owner, go to the approval workflow settings (either NewDot or OldDot)
- Change the submitter's submitsTo to Approver 2
Verify Approver 1 no longer has access to the workspace chat
Also Verify that Approver 1 can now see the expense report in the LHN
As Approver 1, Open the previously created report
Verify Approver 1 sees GBR to that report in the LHN & that Approver 1 sees the Approve button in the report header
Click Approve, make sure it works w/out errors
Click into a different report, verify the expense report still shows up in Approver 1's LHN

Verify that no errors appear in the JS console

Offline tests

N/A - the above steps require internet

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-09-20T20:45:52Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator · 2024-09-20T20:48:14Z

@jjcoffee - this PR is ready for review - it's only a slight modification to previous PRs so I haven't thoroughly tested 😬 but I do plan to test on Monday 🙏

jjcoffee · 2024-09-23T12:23:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-09-23_15.50.17.mp4

Android: mWeb Chrome

android-chrome-2024-09-23_15.59.38.mp4

iOS: Native

ios-app-2024-09-23_16.17.25.mp4

iOS: mWeb Safari

ios-safari-2024-09-23_16.21.26.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-09-23_14.59.44.mp4

MacOS: Desktop

desktop-app-2024-09-23_15.32.29.mp4

jjcoffee · 2024-09-23T13:29:12Z

@Beamanator It seems like the expense report disappears from the LHN if I don't keep it open (as approver 1) when switching the submitsTo to approver 2. Signing out and back in fixes this (and all previous test reports "come back", so I don't know if there's maybe a pending BE change for this?

(Another thing is if I do keep the expense open, the GBR only appears if I refresh (or cycle to another report and use the back button to navigate back).

desktop-app-2024-09-23_15.22.55.mp4

Beamanator · 2024-09-23T21:29:01Z

@jjcoffee ooh yes those are very good points - at this exact moment we are still pending those backend changes, so as long as the front end works great i think we're good to go with this PR 🙏

jjcoffee

LGTM, pending some BE changes.

melvin-bot · 2024-09-24T07:32:10Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blimpich

LGTM, @Beamanator will let you merge at your discretion since we're missing those BE changes.

Beamanator · 2024-09-26T02:08:07Z

Thanks gents! I'll handle the backend changes in the issue! 👍

OSBotify · 2024-09-26T02:18:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-09-27T17:59:35Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.0.41-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-09-30T22:41:25Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.41-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ikevin127 · 2024-11-22T22:34:23Z

src/libs/ReportUtils.ts

-function isExpenseReportManagerWithoutParentAccess(report: OnyxEntry<Report>) {
-    return isExpenseReport(report) && report?.hasParentAccess === false && report?.managerID === currentUserAccountID;
+function isExpenseReportWithoutParentAccess(report: OnyxEntry<Report>) {
+    return isExpenseReport(report) && report?.hasParentAccess === false;


This check function and its usage led to the following issue:

[$250] [HOLD for payment 2024-11-28] Having the 'hidden' notification preference" the reports are displayed in LHN and not marked as read by the migration #52396

which we fixed by removing the isExpenseReportWithoutParentAccess check after this discussion.

Remove manager condition

7db6f63

Beamanator self-assigned this Sep 20, 2024

Beamanator requested a review from a team as a code owner September 20, 2024 20:45

melvin-bot bot requested a review from jjcoffee September 20, 2024 20:45

melvin-bot bot removed the request for review from a team September 20, 2024 20:45

Beamanator changed the title ~~Remove manager condition~~ Show expense report in LHN if user doesn't have access to parent policyChat (removed manager condition) Sep 20, 2024

jjcoffee approved these changes Sep 24, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich September 24, 2024 07:32

blimpich approved these changes Sep 24, 2024

View reviewed changes

Beamanator merged commit b655040 into main Sep 26, 2024
17 of 19 checks passed

Beamanator deleted the beaman-alwaysShowUnaccessibleExpenseReportsInLHN branch September 26, 2024 02:07

github-actions bot mentioned this pull request Sep 27, 2024

Deploy Checklist: New Expensify 2024-09-27 #49855

Closed

jjcoffee mentioned this pull request Oct 1, 2024

[Payment Due 2024-10-07] There are reports with GBR indicators that appear when search for them, but they do not show up in the LHN for approval. #49318

Closed

6 tasks

VickyStash mentioned this pull request Oct 25, 2024

[HOLD Expensify/issues/448335] Updating Approval Workflow causes LHN to fall out of sync between devices #51349

Open

8 tasks

This was referenced Nov 14, 2024

[$250] [HOLD for payment 2024-11-28] Having the 'hidden' notification preference" the reports are displayed in LHN and not marked as read by the migration #52396

Closed

Priority Mode: Focus - Hide LHN reports that don't have parent access #52533

Merged

ikevin127 reviewed Nov 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show expense report in LHN if user doesn't have access to parent policyChat (removed manager condition) #49557

Show expense report in LHN if user doesn't have access to parent policyChat (removed manager condition) #49557

Beamanator commented Sep 20, 2024 •

edited

Loading

melvin-bot bot commented Sep 20, 2024

Beamanator commented Sep 20, 2024

jjcoffee commented Sep 23, 2024 •

edited

Loading

jjcoffee commented Sep 23, 2024 •

edited

Loading

Beamanator commented Sep 23, 2024

jjcoffee left a comment

melvin-bot bot commented Sep 24, 2024

blimpich left a comment

Beamanator commented Sep 26, 2024

OSBotify commented Sep 26, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

ikevin127 Nov 22, 2024

Show expense report in LHN if user doesn't have access to parent policyChat (removed manager condition) #49557

Show expense report in LHN if user doesn't have access to parent policyChat (removed manager condition) #49557

Conversation

Beamanator commented Sep 20, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 20, 2024

Beamanator commented Sep 20, 2024

jjcoffee commented Sep 23, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Sep 23, 2024 • edited Loading

Beamanator commented Sep 23, 2024

jjcoffee left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 24, 2024

blimpich left a comment

Choose a reason for hiding this comment

Beamanator commented Sep 26, 2024

OSBotify commented Sep 26, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

ikevin127 Nov 22, 2024

Choose a reason for hiding this comment

Beamanator commented Sep 20, 2024 •

edited

Loading

jjcoffee commented Sep 23, 2024 •

edited

Loading

jjcoffee commented Sep 23, 2024 •

edited

Loading