order options by the last expense request time in "Submit Expense" flow #49568

c3024 · 2024-09-21T08:46:41Z

Details

Change the order of options in the "Submit Expense" flow to:

Active Policy
Reports in the order of last IOU time
Other policies (where no IOU request was made) in the order of their last activity
All other reports in the order of their last activity

Fixed Issues

$ #48608
PROPOSAL: #48608 (comment)

Tests

Log in with a new account
Create a workspace 'W' (this is treated as the active policy)
Create another workspace 'X'
Send a DM to any user
Click on FAB > Submit Expense > Manual > Input some amount > Next
Verify that the workspace chat created for 'X' in step 3 is above the DM created in step 4 in the options shown
Submit an expense to another user 'U'
Send a DM to another user 'V'
Click on FAB > Submit Expense > Manual > Input some amount > Next
Verify that the chat with user 'U' in step 7 and workspace chat for 'X' created in step 3 are above the DM created with user 'V' in step 8 the options shown

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log in with a new account
Create a workspace 'W' (this is treated as the active policy)
Create another workspace 'X'
Send a DM to any user
Click on FAB > Submit Expense > Manual > Input some amount > Next
Verify that the workspace chat created for 'X' in step 3 is above the DM created in step 4 in the options shown
Submit an expense to another user 'U'
Send a DM to another user 'V'
Click on FAB > Submit Expense > Manual > Input some amount > Next
Verify that the chat with user 'U' in step 7 and workspace chat for 'X' created in step 3 are above the DM created with user 'V' in step 8 the options shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

iouAndroid.mp4

Android: mWeb Chrome

iouAndroidmWeb.mp4

iOS: Native

iouiOS.mp4

iOS: mWeb Safari

iouiOSmWeb.mp4

MacOS: Chrome / Safari

iouChrome.mp4

MacOS: Desktop

iouDesktop.mp4

melvin-bot · 2024-09-21T12:39:22Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2024-09-22T19:37:26Z

src/libs/OptionsListUtils.ts

@@ -1979,6 +1994,22 @@ function getOptions(
                recentReportOptions.push(reportOption);
            }

+            // Add a field to sort the recent reports by the time of last IOU request
+            if (action) {


A query I have is: Do we want to apply this ordering just to the create action? Because with at the moment this will also apply to sharing and categorizing.

Yes, I think we should use it only for CREATE.

Perhaps it would be a little cleaner if we made this condition dependent on preferRecentExpenseReports, seeing as we're defining that as action === CONST.IOU.ACTION.CREATE.

Ollyws · 2024-09-23T12:02:34Z

src/libs/OptionsListUtils.ts

@@ -2391,6 +2428,7 @@ function filterOptions(options: Options, searchInputValue: string, config?: Filt
        excludeLogins = [],
        preferChatroomsOverThreads = false,
        preferPolicyExpenseChat = false,
+        action,


perhaps it would be better to define preferRecentExpenseReports here and then we can put the action === CONST.IOU.ACTION.CREATE condition in MoneyRequestParticipantsSelector

Ollyws · 2024-09-25T10:01:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Ollyws

LGTM.

MariaHCD · 2024-09-26T11:40:29Z

src/libs/ReportUtils.ts

@@ -459,6 +459,7 @@ type OptionData = {
    tabIndex?: 0 | -1;
    isConciergeChat?: boolean;
    isBold?: boolean;
+    lastIOUTime?: string;


Suggested change

lastIOUTime?: string;

lastIOUCreationDate?: string;

Just trying to see if we can make this a bit more descriptive

MariaHCD · 2024-09-26T11:40:48Z

src/libs/OptionsListUtils.ts

@@ -1599,8 +1610,11 @@ function orderOptions(options: ReportUtils.OptionData[], searchValue: string | u
                // When option.login is an exact match with the search value, returning 0 puts it at the top of the option list
                return 0;
            },
+            // For Submit Expense flow, prioritze the most recent expense reports and then policy expense chats (without expense requests)


Suggested change

// For Submit Expense flow, prioritze the most recent expense reports and then policy expense chats (without expense requests)

// For Submit Expense flow, prioritize the most recent expense reports and then policy expense chats (without expense requests)

OSBotify · 2024-09-26T12:26:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-09-27T17:59:41Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.41-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-09-30T22:41:31Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.41-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

c3024 added 5 commits September 21, 2024 11:31

improve order of options in submit expense flow

9659570

Merge branch 'main' into improve-order-of-options-in-submit-expense-flow

6bd112c

fix type and lint errors

1e18107

get IOU Report from reportPreviewAction

0d6b776

string comparsion and comment

39b2172

c3024 marked this pull request as ready for review September 21, 2024 12:39

c3024 requested a review from a team as a code owner September 21, 2024 12:39

melvin-bot bot requested a review from Ollyws September 21, 2024 12:39

melvin-bot bot removed the request for review from a team September 21, 2024 12:39

D-01576 approved these changes Sep 22, 2024

View reviewed changes

Ollyws reviewed Sep 22, 2024

View reviewed changes

c3024 added 3 commits September 23, 2024 10:07

new order only for create action

3fa7a8f

extract comparison to preferRecentExpenseReports

277bea7

Merge branch 'main' into improve-order-of-options-in-submit-expense-flow

3a3cfe5

Ollyws reviewed Sep 23, 2024

View reviewed changes

c3024 added 3 commits September 23, 2024 17:38

pass boolean instead of action in config

9c9634e

Merge branch 'main' into improve-order-of-options-in-submit-expense-flow

c8a3caf

Merge branch 'main' into improve-order-of-options-in-submit-expense-flow

46840cd

Ollyws approved these changes Sep 25, 2024

View reviewed changes

melvin-bot bot requested a review from MariaHCD September 25, 2024 10:02

MariaHCD reviewed Sep 26, 2024

View reviewed changes

rename variable for better clarity

b76fb45

c3024 requested a review from MariaHCD September 26, 2024 12:15

MariaHCD approved these changes Sep 26, 2024

View reviewed changes

MariaHCD merged commit da37289 into Expensify:main Sep 26, 2024
16 checks passed

github-actions bot mentioned this pull request Sep 27, 2024

Deploy Checklist: New Expensify 2024-09-27 #49855

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

order options by the last expense request time in "Submit Expense" flow #49568

order options by the last expense request time in "Submit Expense" flow #49568

c3024 commented Sep 21, 2024 •

edited

Loading

melvin-bot bot commented Sep 21, 2024

Ollyws Sep 22, 2024

c3024 Sep 23, 2024

Ollyws Sep 23, 2024

Ollyws Sep 23, 2024

Ollyws commented Sep 25, 2024

Ollyws left a comment

MariaHCD Sep 26, 2024

MariaHCD Sep 26, 2024

OSBotify commented Sep 26, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

	// For Submit Expense flow, prioritze the most recent expense reports and then policy expense chats (without expense requests)
	// For Submit Expense flow, prioritize the most recent expense reports and then policy expense chats (without expense requests)

order options by the last expense request time in "Submit Expense" flow #49568

order options by the last expense request time in "Submit Expense" flow #49568

Conversation

c3024 commented Sep 21, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 21, 2024

Ollyws Sep 22, 2024

Choose a reason for hiding this comment

c3024 Sep 23, 2024

Choose a reason for hiding this comment

Ollyws Sep 23, 2024

Choose a reason for hiding this comment

Ollyws Sep 23, 2024

Choose a reason for hiding this comment

Ollyws commented Sep 25, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

MariaHCD Sep 26, 2024

Choose a reason for hiding this comment

MariaHCD Sep 26, 2024

Choose a reason for hiding this comment

OSBotify commented Sep 26, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

c3024 commented Sep 21, 2024 •

edited

Loading