Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NewDot and HybridApp onboarding flow #49586

Merged
merged 29 commits into from
Sep 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
00f6568
Refactor completeOnboarding function to update onboarding status
blazejkustra Sep 23, 2024
67ef4d2
Set hasCompletedGuidedSetupFlow to false
blazejkustra Sep 23, 2024
4ae48e5
Clean navigation to onboarding logic
blazejkustra Sep 23, 2024
eda9b65
Remove unused imports
blazejkustra Sep 23, 2024
1ab2303
Merge branch 'main' into fix/onboarding-offline
blazejkustra Sep 24, 2024
f07f55e
Add useful comments
blazejkustra Sep 24, 2024
647622b
Remove onboarding logic from bottom tabs
blazejkustra Sep 24, 2024
a94e8b5
Adjust onboardinf flow with hybrid app considerations
blazejkustra Sep 24, 2024
bb1cd88
Fix the logic and remove console.log
blazejkustra Sep 24, 2024
2bad563
Add comments for selectors
blazejkustra Sep 24, 2024
11b901d
Refactor onboarding logic and improve logging
blazejkustra Sep 24, 2024
c1aecb0
Remove unused import
blazejkustra Sep 24, 2024
e4dd280
Add comments to useOnboardingFlow hook
blazejkustra Sep 24, 2024
4ce6479
Send the completeHybridAppOnboarding request only if HybridApp module…
blazejkustra Sep 24, 2024
13c9c7d
Merge branch 'main' into fix/onboarding-offline
blazejkustra Sep 24, 2024
baf8497
Remove unused useOnyx
blazejkustra Sep 24, 2024
e2a855c
Fix imports
blazejkustra Sep 24, 2024
ab69af2
Init HybridApp with information about HybridApp onboarding
mateuuszzzzz Sep 25, 2024
cdfe1c7
Make the hybrid app flow weven easier
blazejkustra Sep 26, 2024
15a0eda
Remove unsued variables
blazejkustra Sep 26, 2024
3794824
Merge branch 'fix/onboarding-offline' of github.com:software-mansion-…
blazejkustra Sep 26, 2024
7c746c3
Merge branch 'main' into fix/onboarding-offline
blazejkustra Sep 26, 2024
9938392
Refactor useOnboardingFlow to use useOnboardingFlowRouter
blazejkustra Sep 26, 2024
12b4a39
Change names to be more consistent
blazejkustra Sep 26, 2024
d452435
Fix prettier
blazejkustra Sep 26, 2024
6d70f43
Merge branch 'main' into fix/onboarding-offline
blazejkustra Sep 27, 2024
907dcc3
Merge branch 'main' into fix/onboarding-offline
blazejkustra Sep 30, 2024
03c94dc
Merge branch 'main' into fix/onboarding-offline
blazejkustra Sep 30, 2024
075af14
Merge branch 'main' into fix/onboarding-offline
blazejkustra Sep 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/libs/actions/Report.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3582,6 +3582,11 @@ function completeOnboarding(
key: ONYXKEYS.NVP_INTRO_SELECTED,
value: {choice: engagementChoice},
},
{
onyxMethod: Onyx.METHOD.MERGE,
key: ONYXKEYS.NVP_ONBOARDING,
value: {hasCompletedGuidedSetupFlow: true},
},
);

const successData: OnyxUpdate[] = [...tasksForSuccessData];
Expand Down Expand Up @@ -3637,6 +3642,11 @@ function completeOnboarding(
key: ONYXKEYS.NVP_INTRO_SELECTED,
value: {choice: null},
},
{
onyxMethod: Onyx.METHOD.MERGE,
key: ONYXKEYS.NVP_ONBOARDING,
value: {hasCompletedGuidedSetupFlow: null},
blazejkustra marked this conversation as resolved.
Show resolved Hide resolved
},
);

const guidedSetupData: GuidedSetupData = [
blazejkustra marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading