-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle optimistic data when creating new expenses in Control w/ Instant Submit #49677
Handle optimistic data when creating new expenses in Control w/ Instant Submit #49677
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Native49677.Android.mp449677.Android.Offline.mp4Android: mWeb Chrome49677.mWeb-Chrome.mp449677.mWeb-Chrome.Offline.mp4iOS: Native49677.iOS.moviOS: mWeb Safari49677.mWeb-Safari.movMacOS: Chrome / Safari49677.Web.mp4MacOS: Desktop49677.Desktop.mp4 |
@youssef-lr I don't see the screenshot, could you help me this? Thanks! |
@youssef-lr I assume the configuration has another account that acts as a second approver? Is that correct? 49677.Web.mp4Also, could you pull the latest main? Thank you! |
That's correct. I merged main. Please check again @mollfpr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.54-0 🚀
|
@jasperhuangg @mollfpr Can you please share the advance approval set up?
|
@kavimuru configuration should have another user forward the expense, similar to this. |
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀
|
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/411554
Tests
Policy.getCurrent().policy.autoReportingFrequency = 'instant'; Policy.getCurrent().save();
Policy.getCurrent().policy.isPolicyExpenseChatEnabled = true; Policy.getCurrent().save();
Offline tests
The same steps as above, go offline before requesting, make sure a new report preview is created optimistically when the existing report is already approved.
QA Steps
Policy.getCurrent().policy.autoReportingFrequency = 'instant'; Policy.getCurrent().save();
Policy.getCurrent().policy.isPolicyExpenseChatEnabled = true; Policy.getCurrent().save();
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop