-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[getCardIssuedMessage] fix lint error #49734
Conversation
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the only one of these that's an actual lint error (as discussed). But... is there a way we can suppress these other ones? They're just going to keep confusing us, and they're currently impossible to fix (particularly the DOUBLE one on 1757, why??!?!)
Asked in #expensify-swm |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Failing eslint check is from the function the deprecation warning says to use |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/grgia in version: 9.0.41-0 🚀
|
@kavimuru This PR is only intended to fix some lint errors so I think we can just check it off, it doesn't change any behavior. |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.41-10 🚀
|
Details
#49172 (comment)
Fixed Issues
$ N/A Lint error from #49172 (comment)
Tests
Offline tests
QA Steps
Copied from original PR #49177
PREREQUISITES:
User is assigned a physical card.
User does not have personal details.
Go to workspace chat.
Click Add shipping details.
Complete the flow.
Right click on the system message "x added shipping details" > Copy to clipboard.
Paste the system message.
Copied and pasted messages should match - but instead of the handle there will be display name
LHN message should match the message in the report.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop