[QBD] Handle the initial connection for QBD

[hoangzinh]

Details

Fixed Issues

$ #49697
PROPOSAL:

Tests

Prerequisites: Turn on Beta quickbooksDesktopOnNewDot on your account

In Web/Desktop

1. Sign in on an account that enabled beta quickbooksDesktopOnNewDot
2. Go to any Workspace
3. Enable Accounting if it hasn't enabled
4. Go to Workspace's Accounting
5. Verify that the QuickBooks Desktop connection is available
6. Click on "Connect" button
7. Verify that it shows "QuickBooks Desktop setup" page
8. Verify that the setup link is shown

In mWeb/Native apps

1. Sign in on an account that enabled beta quickbooksDesktopOnNewDot
2. Go to any Workspace
3. Enable Accounting if it hasn't enabled
4. Go to Workspace's Accounting
5. Verify that the QuickBooks Desktop connection is available
6. Click on "Connect" button
7. Verify that it shows "Can't connect from this device" page

• Verify that no errors appear in the JS console

Offline tests

Unable to test in offline

QA Steps

Same as above

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-05.at.22.26.52.mov

Android: mWeb Chrome

Screen.Recording.2024-10-05.at.22.01.32.android.chrome.mov

iOS: Native

Screen.Recording.2024-10-05.at.21.57.34.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-10-05.at.21.58.30.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-05.at.20.58.02.web.mov

MacOS: Desktop

Screen.Recording.2024-10-05.at.21.02.33.desktop.mov

[hoangzinh]

@Expensify/design hey team, I'm implementing this screen and I realize that this screen is not included in the Figma link

Can someone help to add it to the Figma link so I can export the computer icon and copy text colors. Thank you.

[hoangzinh]

Hi @ZhenjaHorbach @lakchote This PR is still waiting for some minor UI changes here and translation confirmation here. But given this project is urgent, I would like to have early feedback on this PR, please help me review it when you have time. Thank you.

[ZhenjaHorbach]

Changes look good !
Only I'm not sure about these designs and current impementation
I suppose we need to set a max width for the text
https://www.figma.com/design/E2lt5o4nXHjlDcepaOjg2D/%23control---QuickBooks-Desktop?node-id=9214-13104&node-type=frame&t=OpVkX9IXy0Z0Ak8j-0

[ZhenjaHorbach]

#50216 (comment)
As I can see we have dot here

[hoangzinh]

Oh yeah, the mockup is too small. Let's wait response here then I will update later

[ZhenjaHorbach]

Agree !

[hoangzinh]

Changes look good ! Only I'm not sure about these designs and current impementation I suppose we need to set a max width for the text https://www.figma.com/design/E2lt5o4nXHjlDcepaOjg2D/%23control---QuickBooks-Desktop?node-id=9214-13104&node-type=frame&t=OpVkX9IXy0Z0Ak8j-0

Oh, nice catch. I think we should follow Figma design. I will update it soon.

[dannymcclain]

@hoangzinh Added that screen here in Figma

Here are the illustrations:

• Laptop with Second Screen X.svg.zip
• Laptop with Second Screen Sync.svg.zip

I suppose we need to set a max width for the text

I don't know why the screen looked like that in Figma, but I've updated it and it should look like this. Basically just following the normal padding conventions we have for screens like this. No special custom max-width.

[hoangzinh]

Great! Thank you @dannymcclain

[lakchote]

@hoangzinh this is going in the right direction. Once the PR will be ready, I'll trigger an ad hoc build so Design team can review it.

[hoangzinh]

could you modify the order of appearance in the policy's accounting page please?

@lakchote I updated in this commit 971db88

[lakchote]

Left a comment other than that looks good!

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/50216/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/50216/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/50216/NewExpensify.dmg	https://50216.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[lakchote]

@Expensify/design feel free to test if everything looks good!

[dubielzyk-expensify]

Happy to test. I can't find quickbooksDesktopOnNewDot on Betaify. Maybe I'm looking in the wrong place?

[lakchote]

Happy to test. I can't find quickbooksDesktopOnNewDot on Betaify. Maybe I'm looking in the wrong place?

@dubielzyk-expensify you can log in with an @expensifail.com account, you'll already have all the permissions.

The beta's code hasn't been deployed to prod yet, so it might explain why you didn't find the beta.

[hoangzinh]

This project has a tight deadline. So it would be great if we could merge this PR soon. It would also unblock some other issues. Let us know if you need any other help to verify this PR @dubielzyk-expensify

[dubielzyk-expensify]

This illustration looks a bit tight to the headline and a tad big:

Can we align it a tad more closely with the mock?

Otherwise this looks good

[hoangzinh]

Sure @dubielzyk-expensify these are quick screenshots after updated

[dubielzyk-expensify]

Great stuff! Looks good to me from a visual end. I'll let the code people take the rest 😄

[hoangzinh]

Thank you so much for your help @dubielzyk-expensify

[hoangzinh]

all yours @lakchote @ZhenjaHorbach

[ZhenjaHorbach]

Looks good !

[lakchote]

LGTM

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.47-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.47-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅