[QBD] Import settings main page #50501

hoangzinh · 2024-10-09T13:09:49Z

Details

Fixed Issues

$ #49702
PROPOSAL:

Tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Import" menu under QuickBooks Desktop connection
Verify it opens Import settings main page
Verify it displays 4 menu items: "Chart of accounts", "Classes", "Customers/projects" and "Items"

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-09.at.21.58.06.android.mov

Android: mWeb Chrome

Screen.Recording.2024-10-09.at.22.00.48.android.chrome.mov

iOS: Native

Screen.Recording.2024-10-09.at.22.01.47.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-10-09.at.22.04.34.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-09.at.21.09.20.web.mov

MacOS: Desktop

Screen.Recording.2024-10-09.at.21.14.23.desktop.mov

hoangzinh · 2024-10-09T14:11:29Z

src/languages/es.ts

+            importDescription: 'Elige que configuraciónes de codificación son importadas desde QuickBooks Online a Expensify.',
+            classes: 'Clases',
+            items: 'Artículos',
+            customers: 'Clientes/proyectos',


Most of them are copied from QBO

App/src/languages/es.ts

Lines 2395 to 2398 in 1c0d2fa

importDescription: 'Elige que configuraciónes de codificación son importadas desde QuickBooks Online a Expensify.',

classes: 'Clases',

locations: 'Lugares',

customers: 'Clientes/proyectos',

For the "items", it's confirmed here https://expensify.slack.com/archives/C01GTK53T8Q/p1728342231722529

melvin-bot · 2024-10-09T15:17:34Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2024-10-09T15:18:37Z

@c3024 unlucky again :(. @ZhenjaHorbach will review this PR because it's in QBD project.

c3024 · 2024-10-09T15:20:37Z

I think it is better to ask the internal engineer to assign the C+ to the concerned issue before making the PR ready for review if it had already been decided which C+ would review the PR.

As far as practicable we can avoid disturbing the auto assigner 'queue'. 😃

c3024 · 2024-10-09T15:24:52Z

Or just add me to the QBO project as well because that is what the Auto Assigner Overlord seems to be asking. 😆

ZhenjaHorbach · 2024-10-09T15:29:37Z

I will review today !

ZhenjaHorbach · 2024-10-09T15:42:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

ZhenjaHorbach · 2024-10-09T19:05:41Z

Changes look good !

OSBotify · 2024-10-10T08:13:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-10T23:11:41Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

m-natarajan · 2024-10-11T11:54:27Z

@mountiny @c3024 @lakchote Applause QA team does not have QBD credentials. Could this be verified internally?

lakchote · 2024-10-11T15:39:49Z

@mountiny @c3024 @lakchote Applause QA team does not have QBD credentials. Could this be verified internally?

Asked internally, will report back when I have the answer.

marcaaron · 2024-10-14T21:01:24Z

Seeing as this is behind a beta I am going to assume we will test it before removing the beta and so it can be checked off.

github-actions · 2024-10-15T03:17:22Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.48-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

lakchote · 2024-10-15T05:38:11Z

@mountiny @c3024 @lakchote Applause QA team does not have QBD credentials. Could this be verified internally?

You'll be using the credentials that will be stored in 1P in the QA vault.

cc @mallenexpensify @kadiealexander

mallenexpensify · 2024-10-16T17:25:49Z

@m-natarajan tagging you too :)

You'll be using the credentials that will be stored in 1P in the QA vault.

hoangzinh added 6 commits October 9, 2024 20:03

Implement QBD import setting main page

a249e79

Add beta check

d495f1f

Centralize routes of quickbooks desktop

ff84f10

Correct mapping keys of QBD import configs

270ec8e

Update comment

234db1f

Update translation

d9565c4

hoangzinh commented Oct 9, 2024

View reviewed changes

hoangzinh added 2 commits October 9, 2024 21:55

Update TODO comments

0e06969

Update translation

076ecf9

hoangzinh marked this pull request as ready for review October 9, 2024 15:17

hoangzinh requested a review from a team as a code owner October 9, 2024 15:17

melvin-bot bot requested review from c3024 and removed request for a team October 9, 2024 15:17

ZhenjaHorbach approved these changes Oct 9, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote October 9, 2024 19:05

lakchote approved these changes Oct 10, 2024

View reviewed changes

lakchote merged commit 175af25 into Expensify:main Oct 10, 2024
19 of 20 checks passed

github-actions bot mentioned this pull request Oct 10, 2024

Deploy Checklist: New Expensify 2024-10-10 #50603

Closed

38 tasks

melvin-bot bot mentioned this pull request Oct 15, 2024

[$250] [HOLD for payment 2024-10-22] [HOLD #49697] [Wave Control] [QBD] Import settings main page #49702

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QBD] Import settings main page #50501

[QBD] Import settings main page #50501

hoangzinh commented Oct 9, 2024 •

edited

Loading

hoangzinh Oct 9, 2024

melvin-bot bot commented Oct 9, 2024

hoangzinh commented Oct 9, 2024

c3024 commented Oct 9, 2024 •

edited

Loading

c3024 commented Oct 9, 2024

ZhenjaHorbach commented Oct 9, 2024

ZhenjaHorbach commented Oct 9, 2024 •

edited

Loading

ZhenjaHorbach commented Oct 9, 2024

OSBotify commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

m-natarajan commented Oct 11, 2024

lakchote commented Oct 11, 2024

marcaaron commented Oct 14, 2024

github-actions bot commented Oct 15, 2024

lakchote commented Oct 15, 2024

mallenexpensify commented Oct 16, 2024

	importDescription: 'Elige que configuraciónes de codificación son importadas desde QuickBooks Online a Expensify.',
	classes: 'Clases',
	locations: 'Lugares',
	customers: 'Clientes/proyectos',

[QBD] Import settings main page #50501

[QBD] Import settings main page #50501

Conversation

hoangzinh commented Oct 9, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

hoangzinh Oct 9, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Oct 9, 2024

hoangzinh commented Oct 9, 2024

c3024 commented Oct 9, 2024 • edited Loading

c3024 commented Oct 9, 2024

ZhenjaHorbach commented Oct 9, 2024

ZhenjaHorbach commented Oct 9, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ZhenjaHorbach commented Oct 9, 2024

OSBotify commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

m-natarajan commented Oct 11, 2024

lakchote commented Oct 11, 2024

marcaaron commented Oct 14, 2024

github-actions bot commented Oct 15, 2024

lakchote commented Oct 15, 2024

mallenexpensify commented Oct 16, 2024

hoangzinh commented Oct 9, 2024 •

edited

Loading

c3024 commented Oct 9, 2024 •

edited

Loading

ZhenjaHorbach commented Oct 9, 2024 •

edited

Loading