-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate IOURequestStepDistanceRate
to useOnyx
#50537
Conversation
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
policyTags: OnyxEntry<OnyxTypes.PolicyTagLists>; | ||
type IOURequestStepDistanceRateProps = WithWritableReportOrNotFoundProps<typeof SCREENS.MONEY_REQUEST.STEP_DISTANCE_RATE> & { | ||
/** Holds data related to Money Request view state, rather than the underlying Money Request data. */ | ||
transaction: OnyxEntry<OnyxTypes.Transaction>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkzie2 do we have a hook for transaction? Can we create one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm why do we need it?
withFullTransactionOrNotFound
is being used in many places and has a quite complicated logic- It is already using
useOnyx
That's why I think this is out of scope and should be handled in a separate withFullTransactionOrNotFound
migration issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, thanks for explaining
@rushatgabhane How's your testing? |
@mkzie2 do you know why tax amount is always 0 ? The tax rate is 5% |
@rushatgabhane Did you set the "Tax reclaimable on" value? Without it, the tax amount is always zero. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-10-15.at.17.59.55.movAndroid: mWeb ChromeiOS: mWeb SafariScreen.Recording.2024-10-15.at.18.31.48.movMacOS: Chrome / SafariScreen.Recording.2024-10-15.at.17.58.55.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks! @mkzie2 we need to fix conflicts though. Please DM me when that's done and I can merge this.
@neil-marcellini I resolved the conflict. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.50-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀
|
Details
Fixed Issues
$ #50334
PROPOSAL: #50334 (comment)
Tests
Offline tests
See Tests
QA Steps
See Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-10-10.at.16.39.17-compressed.mov
Android: mWeb Chrome
Screen.Recording.2024-10-10.at.16.41.43-compressed.mov
iOS: Native
Screen.Recording.2024-10-10.at.08.21.07-compressed.mov
iOS: mWeb Safari
Screen.Recording.2024-10-10.at.08.15.54-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2024-10-10.at.08.04.41-compressed.mov
MacOS: Desktop
Screen.Recording.2024-10-10.at.08.14.15-compressed.mov