Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report RHP turns to central pane after editing category and sending a message #50631

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix: report RHP turns to central pane after editing category and sending a message #50631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
372c647
fix: report RHP turns to central pane after editing category and send…
mkzie2 Oct 11, 2024
67d9f71
fix lint
mkzie2 Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/pages/home/report/ReportActionsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ function ReportActionsList({
const styles = useThemeStyles();
const {translate} = useLocalize();
const {windowHeight} = useWindowDimensions();
const {shouldUseNarrowLayout} = useResponsiveLayout();
const {isInNarrowPaneModal, shouldUseNarrowLayout} = useResponsiveLayout();

const {isOffline} = useNetwork();
const route = useRoute<RouteProp<AuthScreensParamList, typeof SCREENS.REPORT>>();
Expand Down Expand Up @@ -346,12 +346,15 @@ function ReportActionsList({
return;
}
if (!hasNewestReportActionRef.current) {
if (isInNarrowPaneModal) {
return;
}
Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
return;
}
InteractionManager.runAfterInteractions(() => reportScrollManager.scrollToBottom());
},
[reportScrollManager, report.reportID],
[isInNarrowPaneModal, reportScrollManager, report.reportID],
);
useEffect(() => {
// Why are we doing this, when in the cleanup of the useEffect we are already calling the unsubscribe function?
Expand Down
Loading