Fix popover position for copilot popup #51204

rushatgabhane · 2024-10-21T22:04:47Z

Details

Fixed Issues

$ #50774
PROPOSAL:

Tests

Go to Security > Add copilot.
Add a copilot.
Click 3-dot menu next to the copilot.
Verify that menu doesn't cut bottom of screen.
Verify that after resizing the window, the menu has correct position.
Verify you can change access level and remove copilot.

Verify that no errors appear in the JS console

Offline tests

QA Steps

same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-10-22.at.03.30.40.mov

MacOS: Desktop

Screen.Recording.2024-10-22.at.03.47.48.mov

melvin-bot · 2024-10-21T22:04:52Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-10-22T06:24:26Z

Screenshots look good from a design perspective 👍

dannymcclain · 2024-10-22T13:59:18Z

Ideally that three-dot icon would be success colored while the menu is open, but if that's not something we want to deal with in this PR the screenshots are looking good to me too.

dangrous · 2024-10-24T16:44:35Z

Oh I think we can make that change ^^^, shouldn't be hard

dangrous · 2024-10-25T17:50:56Z

do you think you can make that quick change @rushatgabhane ? should be able to just copy the existing similar code

rushatgabhane · 2024-10-28T01:50:33Z

hmm yeah have to pass success prop to the menuItem. need to figure out a logic to set selected menuItem

dangrous · 2024-10-29T15:59:53Z

Great! let us know when it's ready for another look

dangrous · 2024-11-01T17:46:16Z

How are we looking on that update @rushatgabhane? Thanks!

dangrous · 2024-11-05T16:18:17Z

Should we maybe push this as is and then fix the color later? Not sure what @rushatgabhane's workload is, and the position is more important (IMO)

EDIT: Also conflicts I guess

allgandalf · 2024-11-05T19:51:42Z

^ Works for me, @rushatgabhane wbu?

shawnborton · 2024-11-08T14:31:16Z

What's the latest on this one?

rushatgabhane · 2024-11-10T20:03:16Z

Added

Screen.Recording.2024-11-11.at.01.31.49.mov

shawnborton · 2024-11-11T09:16:52Z

cc @allgandalf to get this into final review

allgandalf · 2024-11-12T08:27:42Z

I will get to review today/ tomorrow early

dangrous · 2024-11-14T15:46:32Z

How are we looking on this one @allgandalf ?

allgandalf · 2024-11-14T19:24:48Z

this has conflicts, @rushatgabhane can you fix those please

dangrous · 2024-11-18T15:24:12Z

bump for conflicts @rushatgabhane so we can get this settled - thanks!

allgandalf · 2024-11-18T18:17:35Z

failing test @rushatgabhane

dangrous · 2024-11-20T17:43:56Z

looks like just need to migrate withOnyx to useOnyx

allgandalf · 2024-11-21T12:27:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-04.at.12.07.16.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-12-04.at.12.08.50.PM.mov

iOS: Native

Screen.Recording.2024-12-04.at.12.04.30.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-12-04.at.12.02.56.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-04.at.11.57.27.AM.mov

MacOS: Desktop

Screen.Recording.2024-12-04.at.12.01.41.PM.mov

allgandalf · 2024-11-21T14:15:06Z

bug: The position of the popover is not correct @rushatgabhane :

Screen.Recording.2024-11-21.at.7.43.33.PM.mov

dangrous · 2024-11-25T16:31:58Z

bump @rushatgabhane - do we think we can get this one out this week?

dangrous · 2024-12-02T16:25:02Z

Bump again @rushatgabhane, can we please get this into review again for tomorrow?

rushatgabhane · 2024-12-02T21:13:26Z

@allgandalf fixed

allgandalf · 2024-12-03T05:21:16Z

less goo!!!, I will finish review ASAP

allgandalf

Alright, we have come a long way, this LGTM! 🚀

dangrous

Great! Thanks for pushing through on this. I tested around changing sizes and scrolling around and it's never cut off!

OSBotify · 2024-12-04T16:58:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-05T15:16:46Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-05T16:01:53Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2024-12-06T10:39:04Z

@rushatgabhane QA are found issue when validation the PR on Web #53644

https://utest-dl.s3-accelerate.amazonaws.com/12102/26469/484909/6685419/bugAttachment/Bug6685419_1733421217931%21Recording__5.mp4?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20241206T103852Z&X-Amz-SignedHeaders=host&X-Amz-Credential=AKIAJ2UIWMJ2OMC3UCQQ%2F20241206%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Expires=86400&X-Amz-Signature=98e1ae12062edda390f58f7dddd7a1f8d81ca20a38534cc67eec00a55c9f4b82

dangrous · 2024-12-06T15:40:53Z

I don't think that console error is related... it's weird that it shows up on click but it's about google tag manager.... Do you have any ideas @rushatgabhane ? Not a blocker, and we closed that issue, just curious.

github-actions · 2024-12-09T16:05:08Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.72-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

rushatgabhane added 2 commits October 22, 2024 01:49

fix height being cut for popover

a061768

use popovermenu to set anchor position

fdbb357

rushatgabhane requested review from a team as code owners October 21, 2024 22:04

melvin-bot bot requested a review from allgandalf October 21, 2024 22:04

melvin-bot bot removed the request for review from a team October 21, 2024 22:04

rushatgabhane mentioned this pull request Oct 21, 2024

[HOLD for payment 2024-12-16] Copilot - The bottom line of the pop-up modal is not visible #50774

Open

6 tasks

rushatgabhane added 2 commits October 22, 2024 03:37

fix merge

301a8ee

rm unused

a59c0ce

rushatgabhane added 2 commits November 11, 2024 01:13

Merge branch 'main' into popover-position

3c9bc33

add green color to menu dot for copilot

0e0edac

Merge branch 'main' into popover-position

b8bf407

Merge branch 'Expensify:main' into popover-position

434f873

rushatgabhane added 2 commits December 3, 2024 02:19

Merge branch 'main' into popover-position

f6d3e2b

fix horizontal position of popover

8b48927

Merge branch 'Expensify:main' into popover-position

ab4369c

allgandalf approved these changes Dec 4, 2024

View reviewed changes

melvin-bot bot requested a review from dangrous December 4, 2024 06:44

dangrous approved these changes Dec 4, 2024

View reviewed changes

dangrous merged commit 35948c2 into Expensify:main Dec 4, 2024
17 checks passed

github-actions bot mentioned this pull request Dec 5, 2024

Deploy Checklist: New Expensify 2024-12-05 #53631

Closed

43 tasks

vincdargento mentioned this pull request Dec 5, 2024

Copilot - Console error appears when clicking Add copilot and Change access level #53644

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix popover position for copilot popup #51204

Fix popover position for copilot popup #51204

rushatgabhane commented Oct 21, 2024 •

edited

Loading

melvin-bot bot commented Oct 21, 2024

shawnborton commented Oct 22, 2024

dannymcclain commented Oct 22, 2024

dangrous commented Oct 24, 2024

dangrous commented Oct 25, 2024

rushatgabhane commented Oct 28, 2024 •

edited

Loading

dangrous commented Oct 29, 2024

dangrous commented Nov 1, 2024

dangrous commented Nov 5, 2024 •

edited

Loading

allgandalf commented Nov 5, 2024

shawnborton commented Nov 8, 2024

rushatgabhane commented Nov 10, 2024

shawnborton commented Nov 11, 2024

allgandalf commented Nov 12, 2024

dangrous commented Nov 14, 2024

allgandalf commented Nov 14, 2024

dangrous commented Nov 18, 2024

allgandalf commented Nov 18, 2024

dangrous commented Nov 20, 2024

allgandalf commented Nov 21, 2024 •

edited

Loading

allgandalf commented Nov 21, 2024

dangrous commented Nov 25, 2024

dangrous commented Dec 2, 2024

rushatgabhane commented Dec 2, 2024

allgandalf commented Dec 3, 2024

allgandalf left a comment

dangrous left a comment

OSBotify commented Dec 4, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

izarutskaya commented Dec 6, 2024

dangrous commented Dec 6, 2024

github-actions bot commented Dec 9, 2024

Fix popover position for copilot popup #51204

Fix popover position for copilot popup #51204

Conversation

rushatgabhane commented Oct 21, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 21, 2024

shawnborton commented Oct 22, 2024

dannymcclain commented Oct 22, 2024

dangrous commented Oct 24, 2024

dangrous commented Oct 25, 2024

rushatgabhane commented Oct 28, 2024 • edited Loading

dangrous commented Oct 29, 2024

dangrous commented Nov 1, 2024

dangrous commented Nov 5, 2024 • edited Loading

allgandalf commented Nov 5, 2024

shawnborton commented Nov 8, 2024

rushatgabhane commented Nov 10, 2024

shawnborton commented Nov 11, 2024

allgandalf commented Nov 12, 2024

dangrous commented Nov 14, 2024

allgandalf commented Nov 14, 2024

dangrous commented Nov 18, 2024

allgandalf commented Nov 18, 2024

dangrous commented Nov 20, 2024

allgandalf commented Nov 21, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf commented Nov 21, 2024

dangrous commented Nov 25, 2024

dangrous commented Dec 2, 2024

rushatgabhane commented Dec 2, 2024

allgandalf commented Dec 3, 2024

allgandalf left a comment

Choose a reason for hiding this comment

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 4, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

izarutskaya commented Dec 6, 2024

dangrous commented Dec 6, 2024

github-actions bot commented Dec 9, 2024

rushatgabhane commented Oct 21, 2024 •

edited

Loading

rushatgabhane commented Oct 28, 2024 •

edited

Loading

dangrous commented Nov 5, 2024 •

edited

Loading

allgandalf commented Nov 21, 2024 •

edited

Loading