[HybridApp] Implement POC of NewDot SignIn on HybridApp #51257

mateuuszzzzz · 2024-10-22T13:59:45Z

Details

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

jnowakow · 2024-10-31T09:31:11Z

src/libs/Navigation/AppNavigator/index.native.tsx

+            return authenticated;
+        }
+
+        return useNewDotLoginPage === false && authenticated;


Suggested change

return useNewDotLoginPage === false && authenticated;

return !useNewDotLoginPage && authenticated;

Refactored, can be resolved 😌

…ybridapp

# Conflicts: # src/libs/actions/Session/index.ts

…ult-for-hybridapp

* Implement ND bootsplash logic * Rename param * Adress review

# Conflicts: # src/ONYXKEYS.ts # src/libs/actions/Session/index.ts # src/types/modules/react-native.d.ts

* Add hybridAppSettings AppProp * Unify how we pass data on both platforms * fix after merge * fix comments --------- Co-authored-by: war-in <war-in@users.noreply.github.com>

* wip * block switching when error returned * make goBack work correctly * validate code form and SignIn button works (but require further investigation) * show error when unable to switch to OD * adjust new sign-up flow * add comment --------- Co-authored-by: war-in <war-in@users.noreply.github.com>

mateuuszzzzz and others added 4 commits October 22, 2024 15:57

Implement POC of NewDot login page on HybridApp

5eaa292

Merge branch 'main' into make-new-dot-signin-default-for-hybridapp

404047f

fix android crash

f81ec86

add HybridApp onyx key

290748d

jnowakow reviewed Oct 31, 2024

View reviewed changes

war-in and others added 25 commits October 31, 2024 12:03

wip - sending native events

05c4573

Merge branch 'refs/heads/main' into war-in/unmock-signing-in

b6e14aa

js logic

bb05ef9

fix switching to new experience

94ebb8f

block switching when still signing in to OD

a9ff586

reset onyx values on start

ec6315e

Merge branch 'refs/heads/main' into make-new-dot-signin-default-for-h…

db0d806

…ybridapp

preserve HYBRID_APP onyx key when signing out

e1562bb

fix

efde805

move part of resetting logic

a1b9e1a

move useNewDotSignInPage to HybridApp key

3ad1b62

fix lint & typecheck

f9b0e5a

correctly set onyx props when switching from OD

377b686

don't set HybridApp key in onyx (merge it)

90f7c0f

send error message on failed OD login

4b3e539

add useOldDot const

026ac7b

Merge branch 'main' into war-in/unmock-signing-in

624be42

# Conflicts: # src/libs/actions/Session/index.ts

Merge branch 'war-in/unmock-signing-in' into make-new-dot-signin-defa…

44dffc8

…ult-for-hybridapp

Bootsplash logic in hybridapp (#132)

d976148

* Implement ND bootsplash logic * Rename param * Adress review

Merge branch 'main' into make-new-dot-signin-default-for-hybridapp

11e444d

# Conflicts: # src/ONYXKEYS.ts # src/libs/actions/Session/index.ts # src/types/modules/react-native.d.ts

fix clearing onyx

a78141d

[HybridApp] Do not use query params in AppProp URL (#125)

deaba6f

* Add hybridAppSettings AppProp * Unify how we pass data on both platforms * fix after merge * fix comments --------- Co-authored-by: war-in <war-in@users.noreply.github.com>

add disabled to button

8859b6c

move sign in state to HybridApp key

a3436bc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HybridApp] Implement POC of NewDot SignIn on HybridApp #51257

[HybridApp] Implement POC of NewDot SignIn on HybridApp #51257

mateuuszzzzz commented Oct 22, 2024

jnowakow Oct 31, 2024

war-in Nov 13, 2024

	return useNewDotLoginPage === false && authenticated;
	return !useNewDotLoginPage && authenticated;

[HybridApp] Implement POC of NewDot SignIn on HybridApp #51257

Are you sure you want to change the base?

[HybridApp] Implement POC of NewDot SignIn on HybridApp #51257

Conversation

mateuuszzzzz commented Oct 22, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

jnowakow Oct 31, 2024

Choose a reason for hiding this comment

war-in Nov 13, 2024

Choose a reason for hiding this comment