Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: migrate withFullTransactionOrNotFound" #51283

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ishpaul777
Copy link
Contributor

@ishpaul777 ishpaul777 commented Oct 22, 2024

Reverts #50327

$ #51256

Screen.Recording.2024-10-23.at.12.14.13.AM.mov

@ishpaul777 ishpaul777 marked this pull request as ready for review October 22, 2024 18:46
@ishpaul777 ishpaul777 requested a review from a team as a code owner October 22, 2024 18:46
@melvin-bot melvin-bot bot requested a review from Gonals October 22, 2024 18:46
Copy link

melvin-bot bot commented Oct 22, 2024

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team October 22, 2024 18:46
@yuwenmemon yuwenmemon merged commit 96a68f8 into Expensify:main Oct 22, 2024
13 of 17 checks passed
@melvin-bot melvin-bot bot added the Emergency label Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@yuwenmemon
Copy link
Contributor

Not an emergency, clean revert

Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 22, 2024
Revert "fix: migrate withFullTransactionOrNotFound"

(cherry picked from commit 96a68f8)

(CP triggered by yuwenmemon)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 22, 2024
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.0.52-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants