fix: Submit button hang in middle page #51318

truph01 · 2024-10-23T09:22:09Z

Details

Fixed Issues

$ #50663
PROPOSAL: #50663 (comment)

Tests

Open ND
Tap FAB and select Submit expense.
Select Manual option.
Enter the amount, tap Next.
Select Workspace name.
Tap the Merchant field, enter merchant name.
Tap Save.
Observe the expense details page. Verify the Submit button is not hanging on the middle page.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-23.at.16.39.51.mov

Android: mWeb Chrome

Screen.Recording.2024-10-23.at.16.37.58.mov

iOS: Native

Screen.Recording.2024-10-23.at.16.35.05.mov

iOS: mWeb Safari

Screen.Recording.2024-10-23.at.16.24.14.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-23.at.16.30.57.mov

MacOS: Desktop

Screen.Recording.2024-10-23.at.16.37.11.mov

melvin-bot · 2024-10-23T09:42:58Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

truph01 · 2024-10-23T09:43:37Z

There is a ESLint error related to useOnyx migration, but I saw we already have a ticket to fix it.

eh2077 · 2024-10-23T14:04:47Z

@truph01 The issue is still there

Screen.Recording.2024-10-23.at.10.01.18.PM.mov

Your recordings didn't follow step 6 and 7. Can you retest on your end please?

Tap the Merchant field, enter merchant name.

Tap Save.

eh2077 · 2024-10-23T14:15:54Z

On mobile safari, select workspace also make the submit button hung in the middle, see recording

Screen.Recording.2024-10-23.at.10.13.07.PM.mov

eh2077 · 2024-10-27T14:26:45Z

@truph01 Friendly bump on the above comments!

truph01 · 2024-10-29T08:48:13Z

@eh2077 Sorry for my delay. I follow the test steps but still could not reproduce the bug when applying my change in Safari:

Screen.Recording.2024-10-29.at.15.44.05.mov

Can you help test again?

eh2077 · 2024-10-30T14:46:30Z

@truph01 Yes, saving description and merchant works now. But selecting a participant still not working. Below are the reproduction steps

FAB to submit an expense
Enter amount and next
Focusing on the input to open the keyboard. Note this step is important
Select one participant
Notice the submit button is still hung in the middle.

mobile-safari.mov

truph01 · 2024-11-01T09:45:49Z

I am still investigating the bug.

eh2077 · 2024-11-04T14:40:36Z

Hey @truph01, do you have any updates regarding the issue above?

truph01 · 2024-11-04T23:06:50Z

@eh2077 I am still investigating to find solution for that case.

truph01 · 2024-11-05T13:19:45Z

Daily update: Still investigating ...

truph01 · 2024-11-07T05:20:13Z

@eh2077, my proposed solution only works if Screen A has already been rendered (when navigating from A to B, then back to A). However, with the bug we’re addressing here, Screen A has not been rendered yet (navigating from X to A). IMO, I think that bug and the main bug are slightly different.

I explored a few options to fix that bug, but they introduced other issues on devices without keyboards. So, I’ve reverted to a solution that uses a setTimeout to show the Submit button after a set delay, like 500ms. What do you think?

eh2077 · 2024-11-07T16:11:55Z

@truph01 I'm just thinking - is it possible to lift up the keyboard opening state to a parent component?

truph01 · 2024-11-08T11:35:25Z

@eh2077 Thanks, your suggestion works well. I updated PR

eh2077 · 2024-11-11T16:18:07Z

It's EOD for me, so I'll update tmr

eh2077 · 2024-11-12T13:04:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

0-android.mp4

Android: mWeb Chrome

0-mobile-chrome.mp4

iOS: Native

0-ios.mp4

iOS: mWeb Safari

0-mobile-safari.mp4

MacOS: Chrome / Safari

N/A, as there's no visual keyboard

MacOS: Desktop

N/A, as there's no visual keyboard

eh2077 · 2024-11-12T15:03:04Z

src/hooks/useIsWindowHeightReducedByKeyboard/index.ts

+        [shouldUseNarrowLayout],
+    );
+    useEffect(() => {
+        if (!isWindowHeightReducedByKeyboard && windowHeight < prevWindowHeight - 100) {


Can you add comments for this effect? Copying from PDFView/index.tsx should be fine.

I just added comment

eh2077

LGTM and tested well!

Note: We can apply this improvement to other similar use cases in the app, but I prefer not to be overly aggressive since the issue mainly occurs in mobile Safari. Instead, we can proceed progressively: if there are no regressions after it goes to production, we can create a follow-up PR for a broader rollout.

thienlnam · 2024-11-13T17:21:57Z

Yeah, let's first roll this out here and see if it makes it through regression testing

OSBotify · 2024-11-13T17:33:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-14T00:52:47Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2024-11-15T14:16:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.62-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

fix: Submit button hang in middle page

3606eb4

truph01 marked this pull request as ready for review October 23, 2024 09:42

truph01 requested a review from a team as a code owner October 23, 2024 09:42

melvin-bot bot requested review from eh2077 and removed request for a team October 23, 2024 09:42

greg-schroeder mentioned this pull request Oct 24, 2024

[$250] mWeb/Safari - Expense - Submit button hangs in the middle of expense details page for 2 sec #50663

Closed

6 tasks

merge main

da303ba

truph01 added 2 commits November 1, 2024 15:34

merge main

3378345

fix: Submit button hang in middle when selecting participant

dfb70a5

truph01 added 2 commits November 5, 2024 20:06

merge main

d506dcd

fix: revert the fix when choosing participants

8836b75

merge main

744b0cc

truph01 added 2 commits November 8, 2024 18:02

merge main

9508d05

fix: create useIsWindowHeightReducedByKeyboard hook

937064c

eh2077 reviewed Nov 12, 2024

View reviewed changes

add comment to useEffect

9c4e662

eh2077 approved these changes Nov 13, 2024

View reviewed changes

melvin-bot bot requested a review from thienlnam November 13, 2024 01:17

thienlnam approved these changes Nov 13, 2024

View reviewed changes

thienlnam merged commit 4df913e into Expensify:main Nov 13, 2024
18 checks passed

github-actions bot mentioned this pull request Nov 14, 2024

Deploy Checklist: New Expensify 2024-11-14 #52512

Closed

47 tasks

lanitochka17 mentioned this pull request Nov 14, 2024

iOS - Expense - Submit button is gone briefly after merchant editor is dismissed on confirm page #52592

Closed

8 tasks

s77rt mentioned this pull request Nov 22, 2024

[$250] Expense - Submit button is missing after switching layout from mobile to web #52883

Closed

8 tasks

thienlnam mentioned this pull request Nov 22, 2024

Revert "fix: Submit button hang in middle page" #52976

Merged

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Submit button hang in middle page #51318

fix: Submit button hang in middle page #51318

truph01 commented Oct 23, 2024 •

edited

Loading

melvin-bot bot commented Oct 23, 2024

truph01 commented Oct 23, 2024

eh2077 commented Oct 23, 2024

eh2077 commented Oct 23, 2024

eh2077 commented Oct 27, 2024

truph01 commented Oct 29, 2024

eh2077 commented Oct 30, 2024

truph01 commented Nov 1, 2024

eh2077 commented Nov 4, 2024

truph01 commented Nov 4, 2024

truph01 commented Nov 5, 2024

truph01 commented Nov 7, 2024

eh2077 commented Nov 7, 2024

truph01 commented Nov 8, 2024

eh2077 commented Nov 11, 2024

eh2077 commented Nov 12, 2024 •

edited

Loading

eh2077 Nov 12, 2024

truph01 Nov 12, 2024

eh2077 left a comment

thienlnam commented Nov 13, 2024

OSBotify commented Nov 13, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 15, 2024

fix: Submit button hang in middle page #51318

fix: Submit button hang in middle page #51318

Conversation

truph01 commented Oct 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 23, 2024

truph01 commented Oct 23, 2024

eh2077 commented Oct 23, 2024

eh2077 commented Oct 23, 2024

eh2077 commented Oct 27, 2024

truph01 commented Oct 29, 2024

eh2077 commented Oct 30, 2024

truph01 commented Nov 1, 2024

eh2077 commented Nov 4, 2024

truph01 commented Nov 4, 2024

truph01 commented Nov 5, 2024

truph01 commented Nov 7, 2024

eh2077 commented Nov 7, 2024

truph01 commented Nov 8, 2024

eh2077 commented Nov 11, 2024

eh2077 commented Nov 12, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eh2077 Nov 12, 2024

Choose a reason for hiding this comment

truph01 Nov 12, 2024

Choose a reason for hiding this comment

eh2077 left a comment

Choose a reason for hiding this comment

thienlnam commented Nov 13, 2024

OSBotify commented Nov 13, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 15, 2024

truph01 commented Oct 23, 2024 •

edited

Loading

eh2077 commented Nov 12, 2024 •

edited

Loading