-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal QA]: Add News toggle to Support account #51326
[Internal QA]: Add News toggle to Support account #51326
Conversation
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeCannot test on supportalAndroid: mWeb ChromeCannot test on supportaliOS: NativeCannot test on supportaliOS: mWeb SafariCannot test on supportalMacOS: Chrome / SafariCannot test on supportalMacOS: DesktopCannot test on supportal |
@narefyev91 can you mark this on [Internal QA] please , QA doesn't have access to supportal, so @chiragsalian can help us with the testing on staging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory this should work now, unless the BE
blocks this which would need BE
update, so looks good on the frontend 🚀
Neat this works. In the backend we already allow this command to work for support agents with a catch i.e., they can disable a subscription but they cannot enable it. Which makes sense to me. PR LGTM. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.54-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀
|
Details
Allow support agents to unsubscribe on a user’s behalf via NewDot Supportal
Fixed Issues
$ #50842
PROPOSAL:
Currently we do not have Support account to test on dev - to make local tests just add here small code change:
App/src/libs/Request.ts
Line 15 in 2931b5e
Tests
Offline tests
Nothing changed to default offline mode for that feature
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
8mb.video-UzW-LcgBwcov.mp4
Android: mWeb Chrome
8mb.video-h9v-FA7jVouP.mp4
iOS: Native
8mb.video-iaT-qHzrTVFu.mp4
iOS: mWeb Safari
8mb.video-nYs-EdOS6mVk.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
8mb.video-xAL-28edlUpz.mp4