Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix: Reduced Emojipicker landscape modal height" #5160

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Sep 9, 2021

Reverts #5032

Fixes #5154

@roryabraham roryabraham requested a review from a team as a code owner September 9, 2021 16:20
@roryabraham roryabraham self-assigned this Sep 9, 2021
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team September 9, 2021 16:20
@justinpersaud
Copy link
Contributor

feel free to merge when tests pass

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@roryabraham roryabraham merged commit 16e5463 into main Sep 9, 2021
@roryabraham roryabraham deleted the revert-5032-fix/emojipicker-lanscape-modal-size branch September 9, 2021 17:09
github-actions bot pushed a commit that referenced this pull request Sep 9, 2021
…anscape-modal-size

(cherry picked from commit 16e5463)
@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2021

🚀 Cherry-picked to staging by @roryabraham in version: 1.0.95-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2021

🚀 Deployed to production by @yuwenmemon in version: 1.0.95-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2021

🚀 Deployed to staging by @roryabraham in version: 1.0.95-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iPad - Chat - Delete comment option is not available in the menu in landscape mode
4 participants