Give users on a domain the ability to join their colleagues when the company is already using Expensify #51681

allroundexperts · 2024-10-29T17:25:02Z

Details

$ #48189

Fixed Issues

$ #48189
PROPOSAL: #48189 (comment)

Tests

This PR is merging in some code that will not be live yet. Please only test the onboarding flows for any regressions.

PLEASE IGNORE TESTS BELOW THIS LINE

Login using an email that is private (Make sure that another user exists on the same private domain and has several workspaces created)
Verify that an onboarding modal appears, asking to input your name.
Enter your name, and verify that after clicking next, you're prompted to enter the OTP.
Enter the OTP, and verify that after clicking next, you're shown a list of workspaces to join.
Join any workspace, and verify that you're redirected to the workspace page.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as test steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-07.at.2.50.21.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-07.at.2.48.24.AM.mov

iOS: Native

Screen.Recording.2024-11-07.at.2.45.43.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-07.at.2.42.30.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-07.at.2.28.30.AM.mov

MacOS: Desktop

Screen.Recording.2024-11-07.at.2.35.28.AM.mov

github-actions · 2024-10-29T17:25:16Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

parasharrajat · 2024-10-30T14:42:00Z

@allroundexperts looks like you need to sign all the commits.

allroundexperts · 2024-10-30T14:43:26Z

Just trying to make the flow work right now. Will do this as soon as I'm done!

melvin-bot · 2024-11-06T22:00:37Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2024-11-07T13:45:57Z

Testing...

parasharrajat · 2024-11-08T21:15:50Z

BUG: Onboarding in running in loops when we skip validation step.

09.11.2024_02.44.23_REC.mp4

src/ONYXKEYS.ts

src/ROUTES.ts

src/libs/actions/Policy/Member.ts

src/libs/actions/User.ts

src/pages/OnboardingPrivateDomain/index.tsx

allroundexperts · 2024-11-10T18:38:20Z

BUG: Onboarding in running in loops when we skip validation step.

09.11.2024_02.44.23_REC.mp4

Fixed.

marcaaron · 2024-11-13T19:43:45Z

How's this one going?

allroundexperts · 2024-11-13T22:03:13Z

How's this one going?

Addressed all comments. Waiting on the review again.

parasharrajat · 2024-11-15T18:16:27Z

Rechecking..

danielrvidal · 2024-11-18T18:21:50Z

@parasharrajat anything to report back?

parasharrajat · 2024-11-18T20:33:45Z

I will drop the next review in the morning. It was supposed to be today but weekend stretched a bit.

Apologies for the delay.

parasharrajat · 2024-11-19T13:44:02Z

BUG: Pressing back on the Personal details modal, takes the user to the purpose selection screen. Then Pressing next does not take the user through private domain flow.

Steps:

Login.
Press back arrow on the onboarding modal from the personal details step.
Now select a purpose and complete the flow.

allroundexperts · 2024-12-10T22:01:07Z

BUG: When there are no workspaces to join, the page jumps back to onboarding purpose as expected. But there is an error below. IMO, there should be no error given.

@marcaaron Probably we'll need another API command / or pusher sending some data on OpenApp command to check if there are workspaces available to join for a particular private domain?

shawnborton · 2024-12-10T22:20:58Z

I'm not following this:

And makes me realize that it's a bit weird to say that there are workspaces to join. But there might not be. So, what do we show in that case?

What is the exact scenario where we tell the user that there are workspaces to join but there actually are none to join?

marcaaron · 2024-12-11T22:54:28Z

@marcaaron Probably we'll need another API command / or pusher sending some data on OpenApp command to check if there are workspaces available to join for a particular private domain?

I'm not sure we want to do that. It's not the fastest thing to look up and doing it for every private domain user could make the app init performance suffer. But more importantly, it doesn't seem like information we should provide to an unvalidated user.

QA Steps:

Signed in as unvalidated user with an email that has a private domain.
Onboarding modal shows
We show this screen
They enter magic code
There are no workspaces to join

So, I'd propose we'd tweak this copy to suggest something like: "Enter your magic code to validate and find out if there are accessible workspaces to join" or "skip".

marcaaron

Leaving a few comments and questions. Going to pull this branch and do some testing. Code LGTM though and AFAICT should be working so I'll see if I can repro any issues locally and make suggestions.

src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

src/libs/actions/Session/index.ts

src/libs/actions/User.ts

marcaaron · 2024-12-11T23:28:13Z

src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

@@ -77,6 +78,35 @@ function BaseOnboardingPersonalDetails({currentUserPersonalDetails, shouldUseNat
        [onboardingPurposeSelected, onboardingAdminsChatReportID, onboardingPolicyID, route.params?.backTo, activeWorkspaceID, canUseDefaultRooms, isSmallScreenWidth, shouldUseNarrowLayout],
    );

+    useEffect(() => {
+        const skippedPrivateDomainFlow = isPrivateDomain && onboardingPurposeSelected;


Please add a comment to that effect to explain why that would be the case since I agree it's not very obvious.

src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx

marcaaron · 2024-12-11T23:45:36Z

@parasharrajat the flow described here is weird, but not really sure it's something a user would do. Sign in with the same account on our staging server in the middle of the flow? What would compel them? 😄

marcaaron · 2024-12-11T23:59:06Z

BUG: On web, I don't see the onboarding flow after login. I have to refresh the page to see the flow.

Not seeing this at all on dev FWIW so maybe there is an undeployed fix or it's not happening anymore. I am also able to get this to appear on staging so maybe it is something related to the private domain mail service we are using to test this.

marcaaron · 2024-12-12T00:02:54Z

BUG: When there are no workspaces to join, the page jumps back to onboarding purpose as expected. But there is an error below. IMO, there should be no error given.

I did not encounter this error anymore.

This flow seems to work pretty well except for the case where the user has no policies to join could be smoother.

Let's keep moving on this?

This still needs to be fixed @allroundexperts

parasharrajat · 2024-12-12T08:50:40Z

#51681 (comment)

I agree this is something that is unusual. I was trying to mimic the behaviour where the user would drop the onboarding and try to login again with the same email after some time(where the browser cache got cleared).

allroundexperts · 2024-12-12T21:56:22Z

So, I'd propose we'd tweak this copy to suggest something like: "Enter your magic code to validate and find out if there are accessible workspaces to join" or "skip".

Do we have an agreement on this @marcaaron from the design team as well?

marcaaron · 2024-12-12T22:52:40Z

@allroundexperts not yet, but let's fix the bug with the indicator without delay. We can do a follow up to improve the flow design if there are any issues. This one has been open a bit longer than anticipated. Let's push forward.

allroundexperts · 2024-12-12T23:48:56Z

BUG: Onboarding in running in loops when we skip validation step.

09.11.2024_02.44.23_REC.mp4

Fixed.

allroundexperts · 2024-12-12T23:50:22Z

@marcaaron Disabled the private domain flow by default as agreed in the channel. To enable it, just uncomment this.

marcaaron · 2024-12-13T21:30:41Z

Cool. I think with the new design we will have something like user.hasAccessibleDomainPolicies and so we won't need that method but it's fine we can clean it up in the next PR.

marcaaron · 2024-12-13T21:45:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

marcaaron · 2024-12-13T21:48:13Z

I'm going to push this through so we can focus on the next steps.

Attn QA: Please just test the existing onboarding flow for regressions. But also keep in mind, there is a known issue that seems to be preventing the onboarding modal from showing up in certain cases that is still being investigated outside of this PR.

OSBotify · 2024-12-13T22:28:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-18T13:36:44Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

allroundexperts mentioned this pull request Oct 29, 2024

[$250] Give users on a domain the ability to join their colleagues when the company is already using Expensify #48189

Open

onboarding flow without errors

ad6007b

allroundexperts force-pushed the feat-48189 branch from 1fb84d7 to ad6007b Compare November 3, 2024 20:10

allroundexperts added 2 commits November 6, 2024 22:18

Merge branch 'main' into feat-48189

fa273c3

working version

7c5c611

allroundexperts marked this pull request as ready for review November 6, 2024 22:00

allroundexperts requested a review from a team as a code owner November 6, 2024 22:00

melvin-bot bot requested a review from parasharrajat November 6, 2024 22:00

melvin-bot bot removed the request for review from a team November 6, 2024 22:00

Merge branch 'main' into feat-48189

3cba659

parasharrajat suggested changes Nov 8, 2024

View reviewed changes

allroundexperts added 2 commits November 10, 2024 04:33

WIP: ad6007b onboarding flow without errors

938bdf2

fix: handle comments

a107528

marcaaron assigned allroundexperts Nov 13, 2024

allroundexperts added 2 commits November 14, 2024 02:11

merge with main

79cdc1c

add onboarding wrapper

4737f1a

allroundexperts requested a review from parasharrajat November 13, 2024 22:03

marcaaron requested changes Dec 11, 2024

View reviewed changes

allroundexperts added 3 commits December 13, 2024 03:59

Merge branch 'main' into feat-48189

44b73c4

handle comments

cf70577

fix: lint checks

3c497ac

allroundexperts requested a review from marcaaron December 12, 2024 23:48

disable private flow

9bf5636

remove unwanted files

0dd74d0

marcaaron previously approved these changes Dec 13, 2024

View reviewed changes

Merge branch 'main' into feat-48189

c71dacd

marcaaron dismissed their stale review via c71dacd December 13, 2024 21:45

marcaaron self-requested a review December 13, 2024 22:06

marcaaron approved these changes Dec 13, 2024

View reviewed changes

marcaaron merged commit d59c91c into Expensify:main Dec 13, 2024
17 checks passed

github-actions bot mentioned this pull request Dec 18, 2024

Deploy Checklist: New Expensify 2024-12-18 #54292

Open

63 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Give users on a domain the ability to join their colleagues when the company is already using Expensify #51681

Give users on a domain the ability to join their colleagues when the company is already using Expensify #51681

allroundexperts commented Oct 29, 2024 •

edited by marcaaron

Loading

github-actions bot commented Oct 29, 2024 •

edited

Loading

parasharrajat commented Oct 30, 2024

allroundexperts commented Oct 30, 2024

melvin-bot bot commented Nov 6, 2024

parasharrajat commented Nov 7, 2024

parasharrajat commented Nov 8, 2024

allroundexperts commented Nov 10, 2024

marcaaron commented Nov 13, 2024

allroundexperts commented Nov 13, 2024

parasharrajat commented Nov 15, 2024

danielrvidal commented Nov 18, 2024

parasharrajat commented Nov 18, 2024

parasharrajat commented Nov 19, 2024

allroundexperts commented Dec 10, 2024

shawnborton commented Dec 10, 2024

marcaaron commented Dec 11, 2024 •

edited

Loading

marcaaron left a comment

marcaaron Dec 11, 2024

marcaaron commented Dec 11, 2024

marcaaron commented Dec 11, 2024 •

edited

Loading

marcaaron commented Dec 12, 2024

parasharrajat commented Dec 12, 2024

allroundexperts commented Dec 12, 2024

marcaaron commented Dec 12, 2024

allroundexperts commented Dec 12, 2024

allroundexperts commented Dec 12, 2024 •

edited

Loading

marcaaron commented Dec 13, 2024 •

edited

Loading

marcaaron commented Dec 13, 2024 •

edited

Loading

marcaaron commented Dec 13, 2024

OSBotify commented Dec 13, 2024

github-actions bot commented Dec 18, 2024

Give users on a domain the ability to join their colleagues when the company is already using Expensify #51681

Give users on a domain the ability to join their colleagues when the company is already using Expensify #51681

Conversation

allroundexperts commented Oct 29, 2024 • edited by marcaaron Loading

Details

Fixed Issues

Tests

PLEASE IGNORE TESTS BELOW THIS LINE

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Oct 29, 2024 • edited Loading

parasharrajat commented Oct 30, 2024

allroundexperts commented Oct 30, 2024

melvin-bot bot commented Nov 6, 2024

parasharrajat commented Nov 7, 2024

parasharrajat commented Nov 8, 2024

allroundexperts commented Nov 10, 2024

marcaaron commented Nov 13, 2024

allroundexperts commented Nov 13, 2024

parasharrajat commented Nov 15, 2024

danielrvidal commented Nov 18, 2024

parasharrajat commented Nov 18, 2024

parasharrajat commented Nov 19, 2024

allroundexperts commented Dec 10, 2024

shawnborton commented Dec 10, 2024

marcaaron commented Dec 11, 2024 • edited Loading

marcaaron left a comment

Choose a reason for hiding this comment

marcaaron Dec 11, 2024

Choose a reason for hiding this comment

marcaaron commented Dec 11, 2024

marcaaron commented Dec 11, 2024 • edited Loading

marcaaron commented Dec 12, 2024

parasharrajat commented Dec 12, 2024

allroundexperts commented Dec 12, 2024

marcaaron commented Dec 12, 2024

allroundexperts commented Dec 12, 2024

allroundexperts commented Dec 12, 2024 • edited Loading

marcaaron commented Dec 13, 2024 • edited Loading

marcaaron commented Dec 13, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

marcaaron commented Dec 13, 2024

OSBotify commented Dec 13, 2024

github-actions bot commented Dec 18, 2024

allroundexperts commented Oct 29, 2024 •

edited by marcaaron

Loading

github-actions bot commented Oct 29, 2024 •

edited

Loading

marcaaron commented Dec 11, 2024 •

edited

Loading

marcaaron commented Dec 11, 2024 •

edited

Loading

allroundexperts commented Dec 12, 2024 •

edited

Loading

marcaaron commented Dec 13, 2024 •

edited

Loading

marcaaron commented Dec 13, 2024 •

edited

Loading