-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: App crashes when opening attachments in #expensify-roadmap public room on iOS #51783
Fix: App crashes when opening attachments in #expensify-roadmap public room on iOS #51783
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-11-06.at.8.56.46.PM.movAndroid: mWeb ChromeScreen.Recording.2024-11-06.at.8.04.41.PM.moviOS: NativeScreen.Recording.2024-11-06.at.8.29.14.PM.moviOS: mWeb SafariScreen.Recording.2024-11-06.at.8.01.06.PM.movMacOS: Chrome / SafariScreen.Recording.2024-11-06.at.7.58.27.PM.movMacOS: DesktopScreen.Recording.2024-11-06.at.8.11.15.PM.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.59-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀
|
Explanation of Change
Individual
runOnJS()
wrappers were removed from the gesture handler callbacks, instead of that, arunOnJS(true)
callabck is applied to the whole gesture.Fixed Issues
$ #51181
PROPOSAL: #51181 (comment)
Tests
Offline tests
N/A
QA Steps
Same as Tests section above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
iOS: Native
ios.mp4