-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room #52314
base: main
Are you sure you want to change the base?
Conversation
moveTasksToAdminsRoom.mp4 |
@@ -3437,10 +3437,10 @@ function completeOnboarding( | |||
} | |||
|
|||
const integrationName = userReportedIntegration ? CONST.ONBOARDING_ACCOUNTING_MAPPING[userReportedIntegration] : ''; | |||
const actorAccountID = CONST.ACCOUNT_ID.CONCIERGE; | |||
const targetChatReport = ReportUtils.getChatByParticipants([actorAccountID, currentUserAccountID]); | |||
const actorAccountID = engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM ? CONST.ACCOUNT_ID.QA_GUIDE : CONST.ACCOUNT_ID.CONCIERGE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use this, as discussed here https://expensify.slack.com/archives/C07HPDRELLD/p1731436691482209?thread_ts=1730777288.450589&cid=C07HPDRELLD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are required for generating optimistic actions.
However, I will remove it from the params passed to CompleteGuidedSetup
if it is not used in the backend.
Explanation of Change
This PR moves the onboarding tasks to #admins room.
Fixed Issues
$ #52219
PROPOSAL: NA
Tests
Offline tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop