fix navigation to room description #52485

Nodebrute · 2024-11-13T16:19:03Z

Explanation of Change

Fixed Issues

$ #51976
PROPOSAL: #51976 (comment)

Tests

Go to FAB > Send invoice.
Send an invoice to anyone.
Go to invoice chat.
Click on the invoice chat header.
Click Room description.
Enter a description and save it.
Go back to invoice chat.
Click on the room description text under "Say hello!".
Verify the app will open invoice room description

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Go to FAB > Send invoice.
Send an invoice to anyone.
Go to invoice chat.
Click on the invoice chat header.
Click Room description.
Enter a description and save it.
Go back to invoice chat.
Click on the room description text under "Say hello!".
Verify the app will open invoice room description

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-13.at.9.42.16.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-13.at.9.46.52.PM.mov

iOS: Native

Screen.Recording.2024-11-13.at.9.51.31.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-13.at.9.55.02.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-13.at.9.33.08.PM.mov

MacOS: Desktop

Screen.Recording.2024-11-13.at.9.47.49.PM.mov

melvin-bot · 2024-11-13T17:22:39Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov · 2024-11-13T17:26:43Z

src/components/ReportWelcomeText.tsx

@@ -123,12 +124,13 @@ function ReportWelcomeText({report, policy}: ReportWelcomeTextProps) {
                    (welcomeMessage?.messageHtml ? (
                        <PressableWithoutFeedback
                            onPress={() => {
-                                if (!canEditPolicyDescription) {
+                                if (!canEdit) {


Can you change it to more descriptive name like canEditReportDescription

Also update similar usage in line 159

Nodebrute · 2024-11-13T17:33:16Z

While testing, I noticed the behavior of the back button. If we open the description from the chat and press the back button, it takes the user to the report details page. This behavior is the same for the rooms page as well. It could be easily fixed by using Navigation.getActiveRoute() instead of Navigation.getReportRHPActiveRoute() in both places. However, I'm not entirely sure what the expected behavior should be here—could you confirm?

App/src/components/ReportWelcomeText.tsx

Line 156 in 4df913e

const activeRoute = Navigation.getReportRHPActiveRoute();

Screen.Recording.2024-11-13.at.10.21.11.PM.mov

alitoshmatov · 2024-11-17T15:12:03Z

@Nodebrute Yes, I also think we should fix that, lets apply your solution for both places.

techievivek · 2024-11-18T06:32:57Z

@Nodebrute How is the PR going? Will you be updating it today?

Nodebrute · 2024-11-18T22:42:58Z

I'll update this shortly.

Nodebrute · 2024-11-19T01:41:54Z

@alitoshmatov I've made the changes.

Nodebrute · 2024-11-21T11:56:34Z

@alitoshmatov bump ^

Nodebrute · 2024-11-26T02:07:38Z

@alitoshmatov bump fro review

techievivek · 2024-11-26T04:05:59Z

Bumped in slack.

alitoshmatov · 2024-11-26T07:57:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

invoice-android.mov

Android: mWeb Chrome

iOS: Native

invoice-ios.mp4

iOS: mWeb Safari

invoice-safari.mp4

MacOS: Chrome / Safari

invoice-web.mov

MacOS: Desktop

invoice-desktop.mov

alitoshmatov

LGTM!

OSBotify · 2024-11-26T09:15:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-26T16:40:36Z

🚀 Deployed to staging by https://github.com/techievivek in version: 9.0.67-0 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-28T14:21:39Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.67-9 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix navigation to room description

939dd09

Nodebrute marked this pull request as ready for review November 13, 2024 17:22

Nodebrute requested a review from a team as a code owner November 13, 2024 17:22

melvin-bot bot requested review from alitoshmatov and removed request for a team November 13, 2024 17:22

alitoshmatov reviewed Nov 13, 2024

View reviewed changes

change variable name

24ca215

Merge branch 'Expensify:main' into fixroomnavigation

b1d7832

fix back navigation

110403f

techievivek assigned Nodebrute Nov 19, 2024

techievivek requested a review from alitoshmatov November 19, 2024 02:19

alitoshmatov approved these changes Nov 26, 2024

View reviewed changes

melvin-bot bot requested a review from techievivek November 26, 2024 07:57

techievivek approved these changes Nov 26, 2024

View reviewed changes

techievivek merged commit 664f826 into Expensify:main Nov 26, 2024
17 checks passed

github-actions bot mentioned this pull request Nov 26, 2024

Deploy Checklist: New Expensify 2024-11-26 #53142

Closed

75 tasks

melvin-bot bot mentioned this pull request Nov 28, 2024

[HOLD for payment 2024-12-05] [$250] Invoices - App opens workspace description settings when clicking on invoice description text #51976

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix navigation to room description #52485

fix navigation to room description #52485

Nodebrute commented Nov 13, 2024 •

edited

Loading

melvin-bot bot commented Nov 13, 2024

alitoshmatov Nov 13, 2024

Nodebrute Nov 13, 2024

Nodebrute commented Nov 13, 2024

alitoshmatov commented Nov 17, 2024

techievivek commented Nov 18, 2024

Nodebrute commented Nov 18, 2024

Nodebrute commented Nov 19, 2024

Nodebrute commented Nov 21, 2024

Nodebrute commented Nov 26, 2024

techievivek commented Nov 26, 2024

alitoshmatov commented Nov 26, 2024

alitoshmatov left a comment

OSBotify commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 28, 2024

fix navigation to room description #52485

fix navigation to room description #52485

Conversation

Nodebrute commented Nov 13, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 13, 2024

alitoshmatov Nov 13, 2024

Choose a reason for hiding this comment

Nodebrute Nov 13, 2024

Choose a reason for hiding this comment

Nodebrute commented Nov 13, 2024

alitoshmatov commented Nov 17, 2024

techievivek commented Nov 18, 2024

Nodebrute commented Nov 18, 2024

Nodebrute commented Nov 19, 2024

Nodebrute commented Nov 21, 2024

Nodebrute commented Nov 26, 2024

techievivek commented Nov 26, 2024

alitoshmatov commented Nov 26, 2024

Reviewer Checklist

Screenshots/Videos

alitoshmatov left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 28, 2024

Nodebrute commented Nov 13, 2024 •

edited

Loading