-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA] Stop releasing standalone builds to prod #52916
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
* main: (255 commits) Update version to 9.0.66-0 Revert "fix: Submit button hang in middle page" rename transactionData rename param Update version to 9.0.65-5 Update Claim-And-Verify-A-Domain.md remove . to align sentence with others in list workspace delete message fix in profile Fix minor bug Update Receive-and-Pay-Bills.md Update card display on the members page Update Receive-and-Pay-Bills.md Update redirects.csv Update and rename Create-and-Pay-Bills.md to Receive-and-Pay-Bills.md Update copy on the app preferences page fix: delay navigation fix: add card name fix: add missing bank name fix: clear the data when closing the flow Update Netsuite-Troubleshooting.md ...
Ready for review -- I have removed other dependencies on production deploy. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.0.67-0 🚀
|
@Julesssss anything you want us to QA here? |
@mvtglobally no thanks, I forgot to add NOQA and will check it off. |
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.67-9 🚀
|
@AndrewGable @trjExpensify
Explanation of Change
This PR stops deploying standalone app builds to production. But we still upload to Testflight/Play Store internal track.
Fixed Issues
https://github.com/Expensify/Expensify/issues/445668
Tests
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop