Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the whole search LHN menu scrollable #53106

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Make the whole search LHN menu scrollable #53106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/pages/Search/SearchTypeMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,10 @@ function SearchTypeMenu({queryJSON, searchName}: SearchTypeMenuProps) {
const shouldShowSavedSearchesMenuItemTitle = Object.values(savedSearches ?? {}).filter((s) => s.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || isOffline).length > 0;

return (
<>
<ScrollView
onScroll={onScroll}
ref={scrollViewRef}
>
<View style={[styles.pb4, styles.mh3, styles.mt3]}>
{typeMenuItems.map((item, index) => {
const onPress = singleExecution(() => {
Expand Down Expand Up @@ -272,16 +275,11 @@ function SearchTypeMenu({queryJSON, searchName}: SearchTypeMenuProps) {
{shouldShowSavedSearchesMenuItemTitle && (
<>
<Text style={[styles.sectionTitle, styles.pb1, styles.mh3, styles.mt3]}>{translate('search.savedSearchesMenuItemTitle')}</Text>
<ScrollView
onScroll={onScroll}
ref={scrollViewRef}
>
{renderSavedSearchesSection(savedSearchesMenuItems())}
</ScrollView>
{renderSavedSearchesSection(savedSearchesMenuItems())}
<DeleteConfirmModal />
</>
)}
</>
</ScrollView>
);
}

Expand Down