Amex direct feeds polish #53122

VickyStash · 2024-11-26T10:59:11Z

Explanation of Change

Amex direct feeds polish

Fixed Issues

$ #53083
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open the workspace with the Company Cards feature on.
Go to the Company Cards page.
Connect the Amex direct feed and make sure after a successful connection, the RHP is closed. (not sure if we can test it on our own).
Make sure the feed name displays correctly in the switcher button.
Assign a card, make sure it displays as expected.

Onyx data for testing:

 Onyx.set('sharedNVP_private_domain_member_18461622', {
                                settings: {
                                    companyCards: {
                                        'oauth.americanexpressfdx.com 2003': {
                                            asrEnabled: false,
                                            forceReimbursable: 'force_no',
                                            liabilityType: 'personal',
                                            preferredPolicy: 'A7F617B9FE23D2F1',
                                            reportTitleFormat: '',
                                            shouldApplyCashbackToBill: true,
                                            statementPeriodEndDay: 1,
                                            uploadLayoutSettings: [],
                                        },
                                    },
                                    oAuthAccountDetails: {
                                        'oauth.americanexpressfdx.com 2003': {
                                            accountList: ['American Express Gold Card - 2003'],
                                            credentials:
                                                'v1iYh0zi20m163usWmnYA1gtBhNDviwwrnjX6Dbs9/YGDXe1LbVR/rSvcOPYZuaKFMwjb3n21znoT1tKr0SD50jw8gbM5U/96nvmnVhf69ph/KRRnR0kKKvjMYmGkO40OnuOdHdmR4WYjEKo14qDroLTzktOuu/NcC6GMIJCpNPvFM76BJ6v3uCL02Sm8lR5YFOil/uE/wExeH9LLkkzvoemWbYCQcCvLDm4A+yxYU964jjka6KtFAT1HTjM6vizhTCIsFTsuI4mDlOTznhIitJ2DF+qBTom2p+N81SZ/MO+3Pf7YQi2SMfneQGW7lqVEFTmzUlCvbSP6dacYp5P5A5KiuiorLtWLQn42cbJmms7/3fT3+YnqKT7zR/PbN1q9RNXMDmAu6Ba1QyTLYThv5TZ+VQ+6QgHkoRPs5h6rk2D0nM=',
                                            expiration: 1732559288,
                                        },
                                    },
                                },
                            });
Onyx.set('cards_18461622_oauth.americanexpressfdx.com 2003', {
                                '21570652': {
                                    accountID: 18439984,
                                    bank: 'oauth.americanexpressfdx.com 2003',
                                    cardID: 21570652,
                                    cardName: 'American Express Gold Card - 2003',
                                    domainName: 'expensify-policya7f617b9fe23d2f1.exfy',
                                    fraud: 'none',
                                    isVirtual: false,
                                    lastFourPAN: '2003',
                                    lastScrape: '',
                                    scrapeMinDate: '2024-08-27',
                                    state: 3,
                                },
                            });

Offline tests

Same, as in the Tests section.

QA Steps

Verify that no errors appear in the JS console

Same, as in the Tests section.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-11-26T14:12:58Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-11-26T16:56:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Screen.Recording.2024-11-26.at.11.17.04.PM.mov

allgandalf

this one was hard to test, I mocked the data, the updated code should work in theory :))

LGTM 🚀 , thanks for the changes @VickyStash 🙇

allgandalf · 2024-11-26T18:03:17Z

src/libs/CardUtils.ts

@@ -279,7 +279,14 @@ function getCardFeedName(feedType: CompanyCardFeed): string {
        [CONST.COMPANY_CARD.FEED_BANK_NAME.BREX]: 'Brex',
    };

-    return feedNamesMapping[feedType];
+    // In existing OldDot setups other variations of feeds could exist, ex: vcf2, vcf3, oauth.americanexpressfdx.com 2003
+    const feedKey = (Object.keys(feedNamesMapping) as CompanyCardFeed[]).find((feed) => feedType.startsWith(feed));


Okay this makes a lot of sense, I checked the const and they match the starting letters:

mountiny

changes look great, thank yyou!

github-actions · 2024-11-28T14:48:36Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.68-0 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-30T13:53:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.68-7 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

joekaufmanexpensify · 2024-12-02T17:27:29Z

Tested and works great!

joekaufmanexpensify · 2024-12-02T18:30:01Z

Make sure the feed name displays correctly in the switcher button.

One thing actually, the feed name is not correct in the switcher. cc @mountiny @VickyStash

joekaufmanexpensify · 2024-12-02T18:35:51Z

https://expensify.slack.com/archives/C06ML6X0W9L/p1733164539320359

VickyStash added 3 commits November 26, 2024 11:57

Fix getCardFeedName method and add tests

932bef8

Fix feed connection navigation

29aeb8b

Code improvements

a194899

VickyStash marked this pull request as ready for review November 26, 2024 14:12

VickyStash requested a review from a team as a code owner November 26, 2024 14:12

melvin-bot bot requested review from allgandalf and removed request for a team November 26, 2024 14:12

VickyStash mentioned this pull request Nov 26, 2024

[HOLD for payment 2024-12-07] Amex direct feeds polish #53083

Closed

mountiny assigned VickyStash Nov 26, 2024

mountiny self-requested a review November 26, 2024 15:47

allgandalf approved these changes Nov 26, 2024

View reviewed changes

mountiny approved these changes Nov 26, 2024

View reviewed changes

mountiny added the InternalQA This pull request required internal QA label Nov 26, 2024

mountiny merged commit 479edfc into Expensify:main Nov 26, 2024
18 of 21 checks passed

This was referenced Nov 26, 2024

[HOLD for payment 2024-12-11] Investigate workflow job failing on main: test / test (job 2) #53154

Closed

Investigate workflow job failing on main: confirmPassingBuild #53155

Closed

Deploy Checklist: New Expensify 2024-11-28 #53245

Closed

DylanDylann mentioned this pull request Dec 6, 2024

[HOLD for payment 2024-12-20] [$250] Screen briefly flashes Chase feed page after connecting Amex feed and back to expensify #53510

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amex direct feeds polish #53122

Amex direct feeds polish #53122

VickyStash commented Nov 26, 2024 •

edited

Loading

melvin-bot bot commented Nov 26, 2024

allgandalf commented Nov 26, 2024 •

edited

Loading

allgandalf left a comment

allgandalf Nov 26, 2024 •

edited

Loading

mountiny left a comment

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 30, 2024

joekaufmanexpensify commented Dec 2, 2024

joekaufmanexpensify commented Dec 2, 2024

joekaufmanexpensify commented Dec 2, 2024

Amex direct feeds polish #53122

Amex direct feeds polish #53122

Conversation

VickyStash commented Nov 26, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 26, 2024

allgandalf commented Nov 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf left a comment

Choose a reason for hiding this comment

allgandalf Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 30, 2024

joekaufmanexpensify commented Dec 2, 2024

joekaufmanexpensify commented Dec 2, 2024

joekaufmanexpensify commented Dec 2, 2024

VickyStash commented Nov 26, 2024 •

edited

Loading

allgandalf commented Nov 26, 2024 •

edited

Loading

allgandalf Nov 26, 2024 •

edited

Loading