[WIP] docs: Add documentation for OnyxUpdateManager
and deferred updates logic
#53160
+25
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcaaron @danieldoglas @arosiclair
Explanation of Change
The
OnyxUpdateManager
is in charge of ensuring data integrity and synchronization of updates received from the backend. This library is quite complicated and complex, especially since we added a new "deferred onyx updates" logic in #38748.@marcaaron, @danieldoglas, @arosiclair and I discussed and mentioned adding some documentation - and in particular a (flow) diagram - that explains this logic in more detail and makes it easier for developers to understand how we handle (missed) updates and how we persist them in order.
Discussed here:
OnyxUpdateManager
ends up in a recursive endless loop, when previously applied Onyx updates are not chained (caused crashes on web) #47429 (review)OnyxUpdateManager
ends up in a recursive endless loop, when previously applied Onyx updates are not chained (caused crashes on web) #47429 (review)OnyxUpdateManager
ends up in a recursive endless loop, when previously applied Onyx updates are not chained (caused crashes on web) #47429 (comment)I've already added a section under "Philosophy" and created a separate markdown file for the
OnyxUpdateManager
, which will include more detailed info about implementation, characteristics and usage of the library, as well as a flow diagram similar to the one in theREADME.md
for the data flow.Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop