-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move isOptimisticReport to reportMetadata #53203
refactor: move isOptimisticReport to reportMetadata #53203
Conversation
…OptimisticReport-to-metadata
…timisticReport-to-metadata
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@shubham1206agra will you be able to review this today? |
@puneetlath I will do this right now. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-05.at.10.46.30.PM.movAndroid: mWeb ChromeScreen.Recording.2024-12-05.at.10.17.20.PM.moviOS: NativeScreen.Recording.2024-12-05.at.10.35.31.PM.moviOS: mWeb SafariScreen.Recording.2024-12-05.at.10.03.55.PM.movMacOS: Chrome / SafariScreen.Recording.2024-12-05.at.9.54.34.PM.movMacOS: DesktopScreen.Recording.2024-12-05.at.10.27.18.PM.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
@TMisiukiewicz can you look into whether that is a legit performance regression or not? |
@puneetlath I think it's possible that those changes regressed the performance, because we are doing an additional merge actions when opening a report. At the same time I don't think there is a way to avoid it, so I'd say it's expected |
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.73-0 🚀
|
Found known issue when validation the PR - #53644 |
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.73-8 🚀
|
This PR uncovered a race condition, which caused #53822 |
Explanation of Change
This PR moves
isOptimisticReport
key fromreport
toreportMetadata
collection.Fixed Issues
$ #51867
PROPOSAL: #51867 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov